From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH v2] drm/vkms: Add overlay plane support Date: Wed, 6 Mar 2019 14:25:39 +0000 Message-ID: <20190306142539.wmloz352gaa2usza@intel.com> References: <20190305162447.GA15792@armorer> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0258B6E099 for ; Wed, 6 Mar 2019 14:25:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190305162447.GA15792@armorer> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mamta Shukla Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, manasi.d.navare@intel.com List-Id: dri-devel@lists.freedesktop.org T24gVHVlc2RheSwgMjAxOS0wMy0wNSAyMTo1NDo0NyArMDUzMCwgTWFtdGEgU2h1a2xhIHdyb3Rl Ogo+IEFkZCBvdmVybGF5IHBsYW5lIHN1cHBvcnQgaW4gdmttcyBhbGlnbmVkIHdpdGggY3Vyc29y IGFuZCBwcmltYXJ5Cj4gcGxhbmUgd2l0aCBtb2R1bGUgb3B0aW9uICdlbmFibGVfb3ZlcmxheScg dG8gZW5hYmxlL2Rpc2FibGUgb3ZlcmxheQo+IHBsYW5lIHdoaWxlIHRlc3RpbmcuCj4gCj4gVGhp cyBjdXJyZW50bHkgcGFzc2VzIHBsYW5lLXBvc2l0aW9uLWNvdmVyZWQtcGlwZS1BLXBsYW5lIHN1 YnRlc3QKPiBmcm9tIElHVCBrbXNfcGxhbmUgdGVzdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYW10 YSBTaHVrbGEgPG1hbXRhc2h1a2xhNTU1QGdtYWlsLmNvbT4KPiAtLS0KPiBjaGFuZ2UgaW4gdjI6 Cj4gLUZpeCB3YXJuaW5nOiByZXR1cm4gbWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIgd2l0aG91 dCBhIGNhc3QgdXNpbmcKPiAgRVJSX1BUUgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21z X2NyYy5jICAgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS92a21zL3ZrbXNfZHJ2LmMgICB8ICA0ICsrKysKPiAgZHJpdmVycy9ncHUvZHJtL3Zr bXMvdmttc19kcnYuaCAgIHwgIDggKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21z X3BsYW5lLmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gIDQgZmlsZXMg Y2hhbmdlZCwgNzkgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcmMuYyBiL2RyaXZlcnMvZ3B1L2RybS92a21z L3ZrbXNfY3JjLmMKPiBpbmRleCA0ZGQ2YzE1NTM2M2QuLmFjM2VkODYzY2YzNCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3ZrbXMvdmttc19jcmMuYwo+IEBAIC0xMDksNiArMTA5LDI1IEBAIHN0YXRpYyB2b2lkIGJs ZW5kKHZvaWQgKnZhZGRyX2RzdCwgdm9pZCAqdmFkZHJfc3JjLAo+ICAJfQo+ICB9Cj4gIAo+ICtz dGF0aWMgdm9pZCBjb21wb3NlX292ZXJsYXkoc3RydWN0IHZrbXNfY3JjX2RhdGEgKm92ZXJsYXlf Y3JjLAo+ICsJCQkgICAgc3RydWN0IHZrbXNfY3JjX2RhdGEgKnByaW1hcnlfY3JjLCB2b2lkICp2 YWRkcl9vdXQpCXsKPiArCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb3ZlcmxheV9vYmo7Cj4gKwlz dHJ1Y3Qgdmttc19nZW1fb2JqZWN0ICAqb3ZlcmxheV92a21zX29iajsKPiArCj4gKwlvdmVybGF5 X29iaiA9IGRybV9nZW1fZmJfZ2V0X29iaigmb3ZlcmxheV9jcmMtPmZiLCAwKTsKPiArCW92ZXJs YXlfdmttc19vYmogPSBkcm1fZ2VtX3RvX3ZrbXNfZ2VtKG92ZXJsYXlfb2JqKTsKPiArCW11dGV4 X2xvY2soJm92ZXJsYXlfdmttc19vYmotPnBhZ2VzX2xvY2spOwo+ICsJaWYoIW92ZXJsYXlfdmtt c19vYmotPnZhZGRyKXsKPiArCQlEUk1fV0FSTigib3ZlcmxheSBwYWxuZSB2YWRkciBpcyBOVUxM Iik7CgpzL3BhbG5lL3BsYW5lLwoKPiArCQlnb3RvIG91dDsKPiArCX0KPiArCj4gKwlibGVuZCh2 YWRkcl9vdXQsIG92ZXJsYXlfdmttc19vYmotPnZhZGRyLCBwcmltYXJ5X2NyYywgb3ZlcmxheV9j cmMpOwo+ICsKPiArb3V0Ogo+ICsJbXV0ZXhfdW5sb2NrKCZvdmVybGF5X3ZrbXNfb2JqLT5wYWdl c19sb2NrKTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgY29tcG9zZV9jdXJzb3Ioc3RydWN0IHZr bXNfY3JjX2RhdGEgKmN1cnNvcl9jcmMsCj4gIAkJCSAgIHN0cnVjdCB2a21zX2NyY19kYXRhICpw cmltYXJ5X2NyYywgdm9pZCAqdmFkZHJfb3V0KQo+ICB7Cj4gQEAgLTEzMSw3ICsxNTAsOCBAQCBz dGF0aWMgdm9pZCBjb21wb3NlX2N1cnNvcihzdHJ1Y3Qgdmttc19jcmNfZGF0YSAqY3Vyc29yX2Ny YywKPiAgfQo+ICAKPiAgc3RhdGljIHVpbnQzMl90IF92a21zX2dldF9jcmMoc3RydWN0IHZrbXNf Y3JjX2RhdGEgKnByaW1hcnlfY3JjLAo+IC0JCQkgICAgICBzdHJ1Y3Qgdmttc19jcmNfZGF0YSAq Y3Vyc29yX2NyYykKPiArCQkJICAgICAgc3RydWN0IHZrbXNfY3JjX2RhdGEgKmN1cnNvcl9jcmMs Cj4gKwkJCSAgICAgIHN0cnVjdCB2a21zX2NyY19kYXRhICpvdmVybGF5X2NyYykKPiAgewo+ICAJ c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSAmcHJpbWFyeV9jcmMtPmZiOwo+ICAJc3RydWN0 IGRybV9nZW1fb2JqZWN0ICpnZW1fb2JqID0gZHJtX2dlbV9mYl9nZXRfb2JqKGZiLCAwKTsKPiBA QCAtMTU0LDYgKzE3NCw4IEBAIHN0YXRpYyB1aW50MzJfdCBfdmttc19nZXRfY3JjKHN0cnVjdCB2 a21zX2NyY19kYXRhICpwcmltYXJ5X2NyYywKPiAgCW1lbWNweSh2YWRkcl9vdXQsIHZrbXNfb2Jq LT52YWRkciwgdmttc19vYmotPmdlbS5zaXplKTsKPiAgCW11dGV4X3VubG9jaygmdmttc19vYmot PnBhZ2VzX2xvY2spOwo+ICAKPiArCWlmIChvdmVybGF5X2NyYykKPiArCQljb21wb3NlX292ZXJs YXkob3ZlcmxheV9jcmMsIHByaW1hcnlfY3JjLCB2YWRkcl9vdXQpOwo+ICAJaWYgKGN1cnNvcl9j cmMpCj4gIAkJY29tcG9zZV9jdXJzb3IoY3Vyc29yX2NyYywgcHJpbWFyeV9jcmMsIHZhZGRyX291 dCk7Cj4gIAo+IEBAIC0xODQsNiArMjA2LDcgQEAgdm9pZCB2a21zX2NyY193b3JrX2hhbmRsZShz dHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAkJCQkJCW91dHB1dCk7Cj4gIAlzdHJ1Y3Qgdmtt c19jcmNfZGF0YSAqcHJpbWFyeV9jcmMgPSBOVUxMOwo+ICAJc3RydWN0IHZrbXNfY3JjX2RhdGEg KmN1cnNvcl9jcmMgPSBOVUxMOwo+ICsJc3RydWN0IHZrbXNfY3JjX2RhdGEgKm92ZXJsYXlfY3Jj ID0gTlVMTDsKPiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ICAJdTMyIGNyYzMyID0gMDsK PiAgCXU2NCBmcmFtZV9zdGFydCwgZnJhbWVfZW5kOwo+IEBAIC0yMTAsMTIgKzIzMywxNyBAQCB2 b2lkIHZrbXNfY3JjX3dvcmtfaGFuZGxlKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCj4g IAkJaWYgKHBsYW5lLT50eXBlID09IERSTV9QTEFORV9UWVBFX1BSSU1BUlkpCj4gIAkJCXByaW1h cnlfY3JjID0gY3JjX2RhdGE7Cj4gLQkJZWxzZQo+ICsKPiArCQlpZiAocGxhbmUtPnR5cGUgPT0g RFJNX1BMQU5FX1RZUEVfQ1VSU09SKQo+ICAJCQljdXJzb3JfY3JjID0gY3JjX2RhdGE7Cj4gKwo+ ICsJCWlmIChwbGFuZS0+dHlwZSA9PSBEUk1fUExBTkVfVFlQRV9PVkVSTEFZKQo+ICsJCQlvdmVy bGF5X2NyYyA9IGNyY19kYXRhOwoKTWF5YmUgdHVybiB0aGF0IGludG8gYSBzd2l0Y2goKSA/Cgo+ ICAJfQo+ICAKPiAtCWlmIChwcmltYXJ5X2NyYykKPiAtCQljcmMzMiA9IF92a21zX2dldF9jcmMo cHJpbWFyeV9jcmMsIGN1cnNvcl9jcmMpOwo+ICsJaWYgKHByaW1hcnlfY3JjKXsKPiArCQljcmMz MiA9IF92a21zX2dldF9jcmMocHJpbWFyeV9jcmMsIGN1cnNvcl9jcmMsIG92ZXJsYXlfY3JjKTsK PiArCX0KPiAgCj4gIAlmcmFtZV9lbmQgPSBkcm1fY3J0Y19hY2N1cmF0ZV92YmxhbmtfY291bnQo Y3J0Yyk7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5j IGIvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19kcnYuYwo+IGluZGV4IDczOGRkNjIwNmQ4NS4u YjA4YWQ2Zjk1Njc1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5jCj4gQEAgLTI5LDYgKzI5 LDEwIEBAIGJvb2wgZW5hYmxlX2N1cnNvcjsKPiAgbW9kdWxlX3BhcmFtX25hbWVkKGVuYWJsZV9j dXJzb3IsIGVuYWJsZV9jdXJzb3IsIGJvb2wsIDA0NDQpOwo+ICBNT0RVTEVfUEFSTV9ERVNDKGVu YWJsZV9jdXJzb3IsICJFbmFibGUvRGlzYWJsZSBjdXJzb3Igc3VwcG9ydCIpOwo+ICAKPiArYm9v bCBlbmFibGVfb3ZlcmxheTsKPiArbW9kdWxlX3BhcmFtX25hbWVkKGVuYWJsZV9vdmVybGF5LCBl bmFibGVfb3ZlcmxheSwgYm9vbCwgMDQ0NCk7Cj4gK01PRFVMRV9QQVJNX0RFU0MoZW5hYmxlX292 ZXJsYXksICJFbmFibGUvRGlzYWJsZSBvdmVybGF5IHN1cHBvcnQiKTsKPiArCj4gIHN0YXRpYyBj b25zdCBzdHJ1Y3QgZmlsZV9vcGVyYXRpb25zIHZrbXNfZHJpdmVyX2ZvcHMgPSB7Cj4gIAkub3du ZXIJCT0gVEhJU19NT0RVTEUsCj4gIAkub3BlbgkJPSBkcm1fb3BlbiwKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS92a21zL3Zr bXNfZHJ2LmgKPiBpbmRleCA4MWYxY2ZiZWI5MzYuLjgxZGNlYWRmZGU2MiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3ZrbXMvdmttc19kcnYuaAo+IEBAIC0yMCw2ICsyMCw4IEBACj4gIAo+ICBleHRlcm4gYm9vbCBl bmFibGVfY3Vyc29yOwo+ICAKPiArZXh0ZXJuIGJvb2wgZW5hYmxlX292ZXJsYXk7Cj4gKwo+ICBz dGF0aWMgY29uc3QgdTMyIHZrbXNfZm9ybWF0c1tdID0gewo+ICAJRFJNX0ZPUk1BVF9YUkdCODg4 OCwKPiAgfTsKPiBAQCAtMjgsNiArMzAsMTAgQEAgc3RhdGljIGNvbnN0IHUzMiB2a21zX2N1cnNv cl9mb3JtYXRzW10gPSB7Cj4gIAlEUk1fRk9STUFUX0FSR0I4ODg4LAo+ICB9Owo+ICAKPiArc3Rh dGljIGNvbnN0IHUzMiB2a21zX292ZXJsYXlfZm9ybWF0c1tdID17Cj4gKwlEUk1fRk9STUFUX0FS R0I4ODg4LAo+ICt9Owo+ICsKPiAgc3RydWN0IHZrbXNfY3JjX2RhdGEgewo+ICAJc3RydWN0IGRy bV9mcmFtZWJ1ZmZlciBmYjsKPiAgCXN0cnVjdCBkcm1fcmVjdCBzcmMsIGRzdDsKPiBAQCAtMTE4 LDYgKzEyNCw4IEBAIGludCB2a21zX291dHB1dF9pbml0KHN0cnVjdCB2a21zX2RldmljZSAqdmtt c2Rldik7Cj4gIHN0cnVjdCBkcm1fcGxhbmUgKnZrbXNfcGxhbmVfaW5pdChzdHJ1Y3Qgdmttc19k ZXZpY2UgKnZrbXNkZXYsCj4gIAkJCQkgIGVudW0gZHJtX3BsYW5lX3R5cGUgdHlwZSk7Cj4gIAo+ ICtzdHJ1Y3QgZHJtX3BsYW5lICp2a21zX292ZXJsYXlfaW5pdChzdHJ1Y3Qgdmttc19kZXZpY2Ug KnZrbXNkZXYpOwo+ICsKPiAgLyogR2VtIHN0dWZmICovCj4gIHN0cnVjdCBkcm1fZ2VtX29iamVj dCAqdmttc19nZW1fY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkgICAgICAg c3RydWN0IGRybV9maWxlICpmaWxlLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmtt cy92a21zX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX3BsYW5lLmMKPiBpbmRl eCAwZTY3ZDJkNDJmMGMuLmQ1NDBiOTUwMDYzMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vdmttcy92a21zX3BsYW5lLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX3Bs YW5lLmMKPiBAQCAtMTE0LDcgKzExNCw3IEBAIHN0YXRpYyBpbnQgdmttc19wbGFuZV9hdG9taWNf Y2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlpZiAoSVNfRVJSKGNydGNfc3RhdGUp KQo+ICAJCXJldHVybiBQVFJfRVJSKGNydGNfc3RhdGUpOwo+ICAKPiAtCWlmIChwbGFuZS0+dHlw ZSA9PSBEUk1fUExBTkVfVFlQRV9DVVJTT1IpCj4gKwlpZiAoKHBsYW5lLT50eXBlID09IERSTV9Q TEFORV9UWVBFX0NVUlNPUil8KHBsYW5lLT50eXBlID09IERSTV9QTEFORV9UWVBFX09WRVJMQVkp KQoKcy98LyB8fCAvCgo+ICAJCWNhbl9wb3NpdGlvbiA9IHRydWU7Cj4gIAo+ICAJcmV0ID0gZHJt X2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVfc3RhdGUoc3RhdGUsIGNydGNfc3RhdGUsCj4gQEAg LTE2Nyw2ICsxNjcsNDAgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfaGVscGVyX2Z1 bmNzIHZrbXNfcHJpbWFyeV9oZWxwZXJfZnVuY3MgPSB7Cj4gIAkuY2xlYW51cF9mYgkJPSB2a21z X2NsZWFudXBfZmIsCj4gIH07Cj4gIAo+ICtzdHJ1Y3QgZHJtX3BsYW5lICp2a21zX292ZXJsYXlf aW5pdChzdHJ1Y3Qgdmttc19kZXZpY2UgKnZrbXNkZXYpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2 aWNlICpkZXYgPSAmdmttc2Rldi0+ZHJtOwo+ICsJY29uc3Qgc3RydWN0IGRybV9wbGFuZV9oZWxw ZXJfZnVuY3MgKmZ1bmNzOwo+ICsJc3RydWN0IGRybV9wbGFuZSAqb3ZlcmxheTsKPiArCWNvbnN0 IHUzMiAqZm9ybWF0czsKPiArCWludCByZXQsIG5mb3JtYXRzOwo+ICsJdW5zaWduZWQgaW50IGJs ZW5kX2NhcHMgID0gQklUKERSTV9NT0RFX0JMRU5EX1BJWEVMX05PTkUpIHwKPiArCQkJCUJJVChE Uk1fTU9ERV9CTEVORF9QUkVNVUxUSSk7Cj4gKwo+ICsJb3ZlcmxheSA9IGt6YWxsb2Moc2l6ZW9m KCpvdmVybGF5KSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIW92ZXJsYXkpCj4gKwkJcmV0dXJuIEVS Ul9QVFIoLUVOT01FTSk7Cj4gKwo+ICsJZm9ybWF0cyA9IHZrbXNfb3ZlcmxheV9mb3JtYXRzOwo+ ICsJbmZvcm1hdHMgPSBBUlJBWV9TSVpFKHZrbXNfb3ZlcmxheV9mb3JtYXRzKTsKPiArCWZ1bmNz ID0gJnZrbXNfcHJpbWFyeV9oZWxwZXJfZnVuY3M7Cj4gKwlkcm1fcGxhbmVfaGVscGVyX2FkZChv dmVybGF5LCBmdW5jcyk7Cj4gKwlkcm1fcGxhbmVfY3JlYXRlX2FscGhhX3Byb3BlcnR5KG92ZXJs YXkpOwo+ICsJZHJtX3BsYW5lX2NyZWF0ZV9ibGVuZF9tb2RlX3Byb3BlcnR5KG92ZXJsYXksIGJs ZW5kX2NhcHMpOwo+ICsKPiArCXJldCA9IGRybV91bml2ZXJzYWxfcGxhbmVfaW5pdChkZXYsIG92 ZXJsYXksIDAsCj4gKwkJCQkJJnZrbXNfcGxhbmVfZnVuY3MsCj4gKwkJCQkJZm9ybWF0cywgbmZv cm1hdHMsCj4gKwkJCQkJTlVMTCwKPiArCQkJCQlEUk1fUExBTkVfVFlQRV9PVkVSTEFZLCBOVUxM KTsKPiArCWlmIChyZXQpewo+ICsJCWtmcmVlKG92ZXJsYXkpOwo+ICsJCXJldHVybiBFUlJfUFRS KHJldCk7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIG92ZXJsYXk7Cj4gK30KPiArCj4gIHN0cnVjdCBk cm1fcGxhbmUgKnZrbXNfcGxhbmVfaW5pdChzdHJ1Y3Qgdmttc19kZXZpY2UgKnZrbXNkZXYsCj4g IAkJCQkgIGVudW0gZHJtX3BsYW5lX3R5cGUgdHlwZSkKPiAgewo+IC0tIAo+IDIuMTcuMQo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=