Re: [PATCH] [v5, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

[Sam Ravnborg <sam@ravnborg.org>]

Hi Jerry.

I am missing a little intro to the patch - other than the subject.

With this, and the few comments addrerssed that follows you can add:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

On Sat, Mar 09, 2019 at 10:46:50AM +0800, Jerry Han wrote:
> Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> panel.
> 
> v5:
> - Added changelog
> 
> v4:
> - Frefix all function maes with boe_ (Sam)
> - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
> - Sort include lines alphabetically (Sam)
> - Fixed entries in the makefile must be sorted alphabetically (Sam)
> - Add send_mipi_cmds function to avoid duplicating the code (Sam)
> - Add the necessary delay(reset_delay_t5) between reset and sending
>     the initialization command (Rock wang)
> 
> v3:
> - Remove unnecessary delays in sending initialization commands (Jitao Shi)
> 
> V2:
> - Use SPDX identifier (Sam)
> - Use necessary header files replace drmP.h (Sam)
> - Delete unnecessary header files #include <linux/err.h> (Sam)
> - Specifies a GPIOs array to control the reset timing,
>     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> - Delete backlight_disable() function when already disabled (Sam)
> - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
> - Move the necessary data in the DTS to the current file,
>     like porch, display_mode and Init code etc. (Sam)
> - Add compatible device "boe,himax8279d10p" (Sam)
> 
> Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> Cc: Jitao Shi <jitao.shi@mediatek.com>
> Cc: Derek Basehore <dbasehore@chromium.org>
> Cc: Rock wang <rock_wang@himax.com.cn>
> ---
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -17,6 +17,17 @@ config DRM_PANEL_ARM_VERSATILE
>  	  reference designs. The panel is detected using special registers
>  	  in the Versatile family syscon registers.
>  
> +config DRM_PANEL_BOE_HIMAX8279D
> +	tristate "Boe Himax8279d panel"
> +	depends on OF
> +	depends on DRM_MIPI_DSI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	help
> +	  Say Y here if you want to enable support for Boe Himax8279d
> +	  TFT-LCD modules. The panel has a 1200x1920 resolution and uses
> +	  24 bit RGB per pixel. It provides a MIPI DSI interface to
> +	  the host and has a built-in LED backlight.
> +
>  config DRM_PANEL_LVDS
>  	tristate "Generic LVDS panel driver"
>  	depends on OF
> @@ -186,4 +197,15 @@ config DRM_PANEL_SITRONIX_ST7789V
>  	  Say Y here if you want to enable support for the Sitronix
>  	  ST7789V controller for 240x320 LCD panels
>  
> +config DRM_PANEL_BOE_HIMAX8279D
> +	tristate "Boe Himax8279d panel"
> +	depends on OF
> +	depends on DRM_MIPI_DSI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	help
> +	  Say Y here if you want to enable support for Same type
> +	  TFT-LCD modules. The panel has a 1200x1920 resolution and uses
> +	  24 bit RGB per pixel. It provides a MIPI DSI interface to
> +	  the host and has a built-in LED backlight.
> +

The config DRM_PANEL_BOE_HIMAX8279D appears twice.
Drop one of them.


> diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> new file mode 100644
> index 0000000..aa7d912
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> @@ -0,0 +1,1070 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd
> + *
> + * Author: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> + *
> + */
> +
> +#include <linux/backlight.h>
> +#include <linux/delay.h>
> +#include <linux/fb.h>
You may not need fb.h - please check.

> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +
> +#include <linux/gpio/consumer.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <drm/drm_device.h>
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_print.h>
> +
> +#include <video/mipi_display.h>
> +
> +
> +void set_gpios(struct panel_info *pinfo, int enable)
> +{
> +	gpiod_set_value(pinfo->enable_gpio, enable);
> +	gpiod_set_value(pinfo->pp33_gpio, enable);
> +	gpiod_set_value(pinfo->pp18_gpio, enable);
> +}
static, as it is not used outside this module.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel