From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/9] drm/bridge: tc358767: Simplify polling in tc_link_training() Date: Tue, 12 Mar 2019 17:15:15 +0200 Message-ID: <20190312151515.GA17924@pendragon.ideasonboard.com> References: <20190226193609.9862-1-andrew.smirnov@gmail.com> <20190226193609.9862-6-andrew.smirnov@gmail.com> <20190304123052.GG6325@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13407896ED for ; Tue, 12 Mar 2019 15:15:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrey Smirnov Cc: linux-kernel , dri-devel@lists.freedesktop.org, Chris Healy List-Id: dri-devel@lists.freedesktop.org SGkgQW5kcmV5LAoKT24gTW9uLCBNYXIgMTEsIDIwMTkgYXQgMTE6MjY6MjBBTSAtMDcwMCwgQW5k cmV5IFNtaXJub3Ygd3JvdGU6Cj4gT24gTW9uLCBNYXIgNCwgMjAxOSBhdCA0OjMwIEFNIExhdXJl bnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBUdWUsIEZlYiAyNiwgMjAxOSBhdCAxMTozNjowNUFN IC0wODAwLCBBbmRyZXkgU21pcm5vdiB3cm90ZToKPiA+PiBSZXBsYWNlIGV4cGxpY2l0IHBvbGxp bmcgaW4gdGNfbGlua190cmFpbmluZygpIHdpdGggZXF1aXZhbGVudCBjYWxsIHRvCj4gPj4gcmVn bWFwX3JlYWRfcG9sbF90aW1lb3V0KCkgZm9yIHNpbXBsaWNpdHkuIE5vIGZ1bmN0aW9uYWwgY2hh bmdlCj4gPj4gaW50ZW5kZWQgKG5vdCBpbmNsdWRpbmcgc2xpZ2h0bHkgYWx0ZXJlZCBkZWJ1ZyBv dXRwdXQpLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogQW5kcmV5IFNtaXJub3YgPGFuZHJldy5z bWlybm92QGdtYWlsLmNvbT4KPiA+PiBDYzogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVy b3JhLm9yZz4KPiA+PiBDYzogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiA+ PiBDYzogTGF1cmVudCBQaW5jaGFydCA8TGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29t Pgo+ID4+IENjOiBDaHJpcyBIZWFseSA8Y3BoZWFseUBnbWFpbC5jb20+Cj4gPj4gQ2M6IEx1Y2Fz IFN0YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPgo+ID4+IENjOiBkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gPj4gQ2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiA+ PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS90YzM1ODc2Ny5jIHwgMTQgKysrKyst LS0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlv bnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RjMzU4 NzY3LmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RjMzU4NzY3LmMKPiA+PiBpbmRleCA2NDU1 ZTY0ODQ3MjIuLmVhMzBjZWM0YTBjMyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YnJpZGdlL3RjMzU4NzY3LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RjMzU4 NzY3LmMKPiA+PiBAQCAtNzM1LDcgKzczNSw2IEBAIHN0YXRpYyBpbnQgdGNfbGlua190cmFpbmlu ZyhzdHJ1Y3QgdGNfZGF0YSAqdGMsIGludCBwYXR0ZXJuKQo+ID4+ICAgICAgIGNvbnN0IGNoYXIg KiBjb25zdCAqZXJyb3JzOwo+ID4+ICAgICAgIHUzMiBzcmNjdHJsID0gdGNfc3JjY3RybCh0Yykg fCBEUDBfU1JDQ1RSTF9TQ1JNQkxESVMgfAo+ID4+ICAgICAgICAgICAgICAgICAgICAgRFAwX1NS Q0NUUkxfQVVUT0NPUlJFQ1Q7Cj4gPj4gLSAgICAgaW50IHRpbWVvdXQ7Cj4gPj4gICAgICAgaW50 IHJldHJ5Owo+ID4+ICAgICAgIHUzMiB2YWx1ZTsKPiA+PiAgICAgICBpbnQgcmV0Owo+ID4+IEBA IC03NjUsMjAgKzc2NCwxNyBAQCBzdGF0aWMgaW50IHRjX2xpbmtfdHJhaW5pbmcoc3RydWN0IHRj X2RhdGEgKnRjLCBpbnQgcGF0dGVybikKPiA+PiAgICAgICAgICAgICAgIHRjX3dyaXRlKERQMENU TCwgRFBfRU4pOwo+ID4+Cj4gPj4gICAgICAgICAgICAgICAvKiB3YWl0ICovCj4gPj4gLSAgICAg ICAgICAgICB0aW1lb3V0ID0gMTAwMDsKPiA+PiAtICAgICAgICAgICAgIGRvIHsKPiA+PiAtICAg ICAgICAgICAgICAgICAgICAgdGNfcmVhZChEUDBfTFRTVEFULCAmdmFsdWUpOwo+ID4+IC0gICAg ICAgICAgICAgICAgICAgICB1ZGVsYXkoMSk7Cj4gPj4gLSAgICAgICAgICAgICB9IHdoaWxlICgo ISh2YWx1ZSAmIExUX0xPT1BET05FKSkgJiYgKC0tdGltZW91dCkpOwo+ID4+IC0gICAgICAgICAg ICAgaWYgKHRpbWVvdXQgPT0gMCkgewo+ID4+ICsgICAgICAgICAgICAgcmV0ID0gcmVnbWFwX3Jl YWRfcG9sbF90aW1lb3V0KHRjLT5yZWdtYXAsIERQMF9MVFNUQVQsIHZhbHVlLAo+ID4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlICYgTFRfTE9PUERP TkUsIDEsIDEwMDApOwo+ID4+ICsgICAgICAgICAgICAgaWYgKHJldCkgewo+ID4+ICAgICAgICAg ICAgICAgICAgICAgICBkZXZfZXJyKHRjLT5kZXYsICJMaW5rIHRyYWluaW5nIHRpbWVvdXQhXG4i KTsKPiA+PiAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4gPj4gICAgICAgICAgICAgICAgICAgICAg IGludCBwYXR0ZXJuID0gKHZhbHVlID4+IDExKSAmIDB4MzsKPiA+PiAgICAgICAgICAgICAgICAg ICAgICAgaW50IGVycm9yID0gKHZhbHVlID4+IDgpICYgMHg3Owo+ID4+Cj4gPj4gICAgICAgICAg ICAgICAgICAgICAgIGRldl9kYmcodGMtPmRldiwKPiA+PiAtICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiTGluayB0cmFpbmluZyBwaGFzZSAlZCBkb25lIGFmdGVyICVkIHVTOiAlc1xuIiwK PiA+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXR0ZXJuLCAxMDAwIC0gdGltZW91 dCwgZXJyb3JzW2Vycm9yXSk7Cj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIkxp bmsgdHJhaW5pbmcgcGhhc2UgJWQgZG9uZTogJXNcbiIsCj4gPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcGF0dGVybiwgZXJyb3JzW2Vycm9yXSk7Cj4gPgo+ID4gSXQncyBwcm9iYWJs eSBub3QgYSBiaWcgZGVhbCBpbiB0aGlzIHNwZWNpZmljIGNhc2UsIGJ1dCBpbiBnZW5lcmFsIGl0 Cj4gPiBjYW4gYmUgdXNlZnVsIHRvIGtub3cgaG93IGxvbmcgdGhlIHBvbGwgdG9vay4KPiAKPiBJ IGRvbid0IGRpc2FncmVlLCBidXQgYmVhciBpbiBtaW5kIHRoYXQgdGhlIHdheSB0aW1lIGlzIG1l YXN1cmVkIGluCj4gb3JpZ2luYWwgbG9vcCBhc3N1bWVzIHRoYXQgdGNfcmVhZCwgYW4gSTJDIHRy YW5zYWN0aW9uIG92ZXIgMTAwS0h6Cj4gYnVzLCB0YWtlcyBpbnNpZ25pZmljYW50IGFtb3VudCBv ZiB0aW1lIGNvbXBhcmVkIHRvIDEgdVMgZGVsYXkuIEkKPiB0aGluayBvcmlnaW5hbCBkZWJ1ZyBz dGF0ZW1lbnQgZG9lcyBhIGJpdCBvZiBhIGZhbHNlIGFkdmVydGlzaW5nIHdoZW4KPiBpdCBwcmVz ZW50cyBhIG51bWJlciBvZiBwb2xsaW5nIGxvb3AgaXRlcmF0aW9ucyBhcyBpZiBpdCBpcyB0aW1l IGl0Cj4gdG9vayB0byBlc3RhYmxpc2ggYSBsaW5rIGluIG1pY3Jvc2Vjb25kcy4KPiAKPiA+IEFu eSBob3BlIHRvIGVuaGFuY2UgcmVnbWFwX3JlYWRfcG9sbF90aW1lb3V0KCkgdG8gcmV0dXJuIGVp dGhlciB0aGUgZWxhcHNlZCB0aW1lIG9yIHRoZQo+ID4gcmVtYWluaW5nIHRpbWVvdXQgaW5zdGVh ZCBvZiAwIG9uIHN1Y2Nlc3MgPwo+IAo+IEknZCByYXRoZXIgbm90IGdvIHRoZXJlLiBUaGF0J2xs IHRha2UgY29udmluY2luZyBNYXJrIEJyb3duIHRvIGFjY2VwdAo+IHRoYXQgc2VtYW50aWNzIGNo YW5nZSwgdGhlbiBmaXhpbmcgYWxsIG9mIHRoZSBjYWxsZXJzIGFjcm9zcyB0aGUgdHJlZQo+IHZp YSBhIHNlcGFyYXRlIHBhdGNoIHNlcmllcy4KPiAKPiBXaGF0IGlmIGluc3RlYWQgd2UganVzdCBh ZGQgYW4gZXh0cmEgZGVidWcgc3RhdGVtZW50IGJlZm9yZSBsaW5rCj4gdHJhaW5pbmcgc3RhcnRz LCBzbyB0aGF0IGR1cmF0aW9uIG9mIHRoZSBwcm9jZXNzIGNhbiBiZSBkaXNjZXJuZWQgZnJvbQo+ IGxvZ2dpbmcgdGltZXN0YW1wcz8gVGhpcyBkb2VzIHJlcXVpcmUgdXNlciBkb2luZyBhIGJpdCBv ZiBtYXRoIGJ5Cj4gaGFuZCwgYnV0IGl0J3MgYWN0dWFsbHkgbW9yZSBhY2N1cmF0ZSB0aW1pbmcg aW5mbyBjb21wYXJlZCB0byBvcmlnaW5hbAo+IGFuZCBpdCBkb2Vzbid0IHJlcXVpcmUgYW55IEFQ SSBtb2RpZmljYXRpb24uCgpUaGF0IHdvcmtzIGZvciBtZS4KCi0tIApSZWdhcmRzLAoKTGF1cmVu dCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=