From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v6 09/18] media: vsp1: drm: Split RPF format setting to separate function Date: Wed, 13 Mar 2019 13:17:44 +0200 Message-ID: <20190313111744.GC4722@pendragon.ideasonboard.com> References: <20190313000532.7087-1-laurent.pinchart+renesas@ideasonboard.com> <20190313000532.7087-10-laurent.pinchart+renesas@ideasonboard.com> <7b446a1c-823e-2cb9-64c4-26f6c828ac7a@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FD336E09F for ; Wed, 13 Mar 2019 11:17:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <7b446a1c-823e-2cb9-64c4-26f6c828ac7a@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: Laurent Pinchart , Liviu Dudau , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gV2VkLCBNYXIgMTMsIDIwMTkgYXQgMTE6MTI6NTdBTSArMDAwMCwgS2ll cmFuIEJpbmdoYW0gd3JvdGU6Cj4gT24gMTMvMDMvMjAxOSAwMDowNSwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiA+IFRoZSBjb2RlIHRoYXQgaW5pdGlhbGl6ZXMgdGhlIFJQRiBmb3JtYXQtcmVs YXRlZCBmaWVsZHMgZm9yIGRpc3BsYXkKPiA+IHBpcGVsaW5lcyB3aWxsIGFsc28gYmUgdXNlZnVs IGZvciB0aGUgV1BGIHRvIGltcGxlbWVudCB3cml0ZWJhY2sKPiA+IHN1cHBvcnQuIFNwbGl0IGl0 IGZyb20gdnNwMV9kdV9hdG9taWNfdXBkYXRlKCkgdG8gYSBuZXcKPiA+IHZzcDFfZHVfcGlwZWxp bmVfc2V0X3J3cGZfZm9ybWF0KCkgZnVuY3Rpb24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IExh dXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29t Pgo+ID4gLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMgfCA1 NSArKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzNSBpbnNl cnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv bWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfZHJtLmMKPiA+IGluZGV4IDRmMWJjNTFkMWVmNC4uNTYwMWE3ODc2ODhiIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMKPiA+ICsr KyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jCj4gPiBAQCAtNTY2LDYg KzU2NiwzNiBAQCBzdGF0aWMgdm9pZCB2c3AxX2R1X3BpcGVsaW5lX2NvbmZpZ3VyZShzdHJ1Y3Qg dnNwMV9waXBlbGluZSAqcGlwZSkKPiA+ICAJdnNwMV9kbF9saXN0X2NvbW1pdChkbCwgZGxfZmxh Z3MpOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgaW50IHZzcDFfZHVfcGlwZWxpbmVfc2V0X3J3 cGZfZm9ybWF0KHN0cnVjdCB2c3AxX2RldmljZSAqdnNwMSwKPiA+ICsJCQkJCSAgICBzdHJ1Y3Qg dnNwMV9yd3BmICpyd3BmLAo+ID4gKwkJCQkJICAgIHUzMiBwaXhlbGZvcm1hdCwgdW5zaWduZWQg aW50IHBpdGNoKQo+ID4gK3sKPiA+ICsJY29uc3Qgc3RydWN0IHZzcDFfZm9ybWF0X2luZm8gKmZt dGluZm87Cj4gPiArCXVuc2lnbmVkIGludCBjaHJvbWFfaHN1YjsKPiA+ICsKPiA+ICsJZm10aW5m byA9IHZzcDFfZ2V0X2Zvcm1hdF9pbmZvKHZzcDEsIHBpeGVsZm9ybWF0KTsKPiA+ICsJaWYgKCFm bXRpbmZvKSB7Cj4gPiArCQlkZXZfZGJnKHZzcDEtPmRldiwgIlVuc3VwcG9ydGVkIHBpeGVsIGZv cm1hdCAlMDh4IGZvciBSUEZcbiIsCj4gCj4gSXNuJ3QgdGhpcyBub3cgYSBSV1BGID8KCkl0IGlz LiBJJ2xsIGRyb3AgdGhlICJmb3IgUlBGIiBwYXJ0LgoKPiBPdGhlciB0aGFuIHRoYXQKPiAKPiBS ZXZpZXdlZC1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRlYXNv bmJvYXJkLmNvbT4KPiAKPiA+ICsJCQlwaXhlbGZvcm1hdCk7Cj4gPiArCQlyZXR1cm4gLUVJTlZB TDsKPiA+ICsJfQo+ID4gKwo+ID4gKwkvKgo+ID4gKwkgKiBPbmx5IGZvcm1hdHMgd2l0aCB0aHJl ZSBwbGFuZXMgY2FuIGFmZmVjdCB0aGUgY2hyb21hIHBsYW5lcyBwaXRjaC4KPiA+ICsJICogQWxs IGZvcm1hdHMgd2l0aCB0d28gcGxhbmVzIGhhdmUgYSBob3Jpem9udGFsIHN1YnNhbXBsaW5nIHZh bHVlIG9mIDIsCj4gPiArCSAqIGJ1dCBjb21iaW5lIFUgYW5kIFYgaW4gYSBzaW5nbGUgY2hyb21h IHBsYW5lLCB3aGljaCB0aHVzIHJlc3VsdHMgaW4KPiA+ICsJICogdGhlIGx1bWEgcGxhbmUgYW5k IGNocm9tYSBwbGFuZSBoYXZpbmcgdGhlIHNhbWUgcGl0Y2guCj4gPiArCSAqLwo+ID4gKwljaHJv bWFfaHN1YiA9IChmbXRpbmZvLT5wbGFuZXMgPT0gMykgPyBmbXRpbmZvLT5oc3ViIDogMTsKPiA+ ICsKPiA+ICsJcndwZi0+Zm10aW5mbyA9IGZtdGluZm87Cj4gPiArCXJ3cGYtPmZvcm1hdC5udW1f cGxhbmVzID0gZm10aW5mby0+cGxhbmVzOwo+ID4gKwlyd3BmLT5mb3JtYXQucGxhbmVfZm10WzBd LmJ5dGVzcGVybGluZSA9IHBpdGNoOwo+ID4gKwlyd3BmLT5mb3JtYXQucGxhbmVfZm10WzFdLmJ5 dGVzcGVybGluZSA9IHBpdGNoIC8gY2hyb21hX2hzdWI7Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ ID4gK30KPiA+ICsKPiA+ICAvKiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gICAqIERVIERyaXZl ciBBUEkKPiA+ICAgKi8KPiA+IEBAIC03NzMsOSArODAzLDggQEAgaW50IHZzcDFfZHVfYXRvbWlj X3VwZGF0ZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlX2luZGV4LAo+ID4g IHsKPiA+ICAJc3RydWN0IHZzcDFfZGV2aWNlICp2c3AxID0gZGV2X2dldF9kcnZkYXRhKGRldik7 Cj4gPiAgCXN0cnVjdCB2c3AxX2RybV9waXBlbGluZSAqZHJtX3BpcGUgPSAmdnNwMS0+ZHJtLT5w aXBlW3BpcGVfaW5kZXhdOwo+ID4gLQljb25zdCBzdHJ1Y3QgdnNwMV9mb3JtYXRfaW5mbyAqZm10 aW5mbzsKPiA+IC0JdW5zaWduZWQgaW50IGNocm9tYV9oc3ViOwo+ID4gIAlzdHJ1Y3QgdnNwMV9y d3BmICpycGY7Cj4gPiArCWludCByZXQ7Cj4gPiAgCj4gPiAgCWlmIChycGZfaW5kZXggPj0gdnNw MS0+aW5mby0+cnBmX2NvdW50KQo+ID4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiBAQCAtODA4LDI1 ICs4MzcsMTEgQEAgaW50IHZzcDFfZHVfYXRvbWljX3VwZGF0ZShzdHJ1Y3QgZGV2aWNlICpkZXYs IHVuc2lnbmVkIGludCBwaXBlX2luZGV4LAo+ID4gIAkgKiBTdG9yZSB0aGUgZm9ybWF0LCBzdHJp ZGUsIG1lbW9yeSBidWZmZXIgYWRkcmVzcywgY3JvcCBhbmQgY29tcG9zZQo+ID4gIAkgKiByZWN0 YW5nbGVzIGFuZCBaLW9yZGVyIHBvc2l0aW9uIGFuZCBmb3IgdGhlIGlucHV0Lgo+ID4gIAkgKi8K PiA+IC0JZm10aW5mbyA9IHZzcDFfZ2V0X2Zvcm1hdF9pbmZvKHZzcDEsIGNmZy0+cGl4ZWxmb3Jt YXQpOwo+ID4gLQlpZiAoIWZtdGluZm8pIHsKPiA+IC0JCWRldl9kYmcodnNwMS0+ZGV2LCAiVW5z dXBwb3J0ZWQgcGl4ZWwgZm9ybWF0ICUwOHggZm9yIFJQRlxuIiwKPiA+IC0JCQljZmctPnBpeGVs Zm9ybWF0KTsKPiA+IC0JCXJldHVybiAtRUlOVkFMOwo+ID4gLQl9Cj4gPiArCXJldCA9IHZzcDFf ZHVfcGlwZWxpbmVfc2V0X3J3cGZfZm9ybWF0KHZzcDEsIHJwZiwgY2ZnLT5waXhlbGZvcm1hdCwK PiA+ICsJCQkJCSAgICAgICBjZmctPnBpdGNoKTsKPiA+ICsJaWYgKHJldCA8IDApCj4gPiArCQly ZXR1cm4gcmV0Owo+ID4gIAo+ID4gLQkvKgo+ID4gLQkgKiBPbmx5IGZvcm1hdHMgd2l0aCB0aHJl ZSBwbGFuZXMgY2FuIGFmZmVjdCB0aGUgY2hyb21hIHBsYW5lcyBwaXRjaC4KPiA+IC0JICogQWxs IGZvcm1hdHMgd2l0aCB0d28gcGxhbmVzIGhhdmUgYSBob3Jpem9udGFsIHN1YnNhbXBsaW5nIHZh bHVlIG9mIDIsCj4gPiAtCSAqIGJ1dCBjb21iaW5lIFUgYW5kIFYgaW4gYSBzaW5nbGUgY2hyb21h IHBsYW5lLCB3aGljaCB0aHVzIHJlc3VsdHMgaW4KPiA+IC0JICogdGhlIGx1bWEgcGxhbmUgYW5k IGNocm9tYSBwbGFuZSBoYXZpbmcgdGhlIHNhbWUgcGl0Y2guCj4gPiAtCSAqLwo+ID4gLQljaHJv bWFfaHN1YiA9IChmbXRpbmZvLT5wbGFuZXMgPT0gMykgPyBmbXRpbmZvLT5oc3ViIDogMTsKPiA+ IC0KPiA+IC0JcnBmLT5mbXRpbmZvID0gZm10aW5mbzsKPiA+IC0JcnBmLT5mb3JtYXQubnVtX3Bs YW5lcyA9IGZtdGluZm8tPnBsYW5lczsKPiA+IC0JcnBmLT5mb3JtYXQucGxhbmVfZm10WzBdLmJ5 dGVzcGVybGluZSA9IGNmZy0+cGl0Y2g7Cj4gPiAtCXJwZi0+Zm9ybWF0LnBsYW5lX2ZtdFsxXS5i eXRlc3BlcmxpbmUgPSBjZmctPnBpdGNoIC8gY2hyb21hX2hzdWI7Cj4gPiAgCXJwZi0+YWxwaGEg PSBjZmctPmFscGhhOwo+ID4gIAo+ID4gIAlycGYtPm1lbS5hZGRyWzBdID0gY2ZnLT5tZW1bMF07 CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs