From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: fabrizio.castro@bp.renesas.com, devicetree@vger.kernel.org,
Songjun.Wu@atmel.com, dri-devel@lists.freedesktop.org,
peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
voice.shen@atmel.com
Subject: Re: [PATCH v3 1/6] drm/bridge: sii902x: add input_bus_flags
Date: Wed, 13 Mar 2019 18:23:02 +0200 [thread overview]
Message-ID: <20190313162302.GH4722@pendragon.ideasonboard.com> (raw)
In-Reply-To: <087bea83b75afa55f0b156da3893e99c49ebb186.1552492550.git.jsarha@ti.com>
Hello Jyri,
Thank you for the patch.
On Wed, Mar 13, 2019 at 06:01:03PM +0200, Jyri Sarha wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> The driver always sets InputBusFmt:EDGE to 0 (falling edge).
>
> Add drm_bridge_timings's input_bus_flags to reflect that the bridge
> samples on falling edges.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/sii902x.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index bfa902013aa4..1afa000141d5 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -459,6 +459,12 @@ static int sii902x_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)
> return 0;
> }
>
> +static const struct drm_bridge_timings default_sii902x_timings = {
> + .input_bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
> + | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE
> + | DRM_BUS_FLAG_DE_HIGH,
> +};
> +
> static int sii902x_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> @@ -529,6 +535,7 @@ static int sii902x_probe(struct i2c_client *client,
>
> sii902x->bridge.funcs = &sii902x_bridge_funcs;
> sii902x->bridge.of_node = dev->of_node;
> + sii902x->bridge.timings = &default_sii902x_timings;
> drm_bridge_add(&sii902x->bridge);
>
> i2c_set_clientdata(client, sii902x);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-13 16:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 16:01 [PATCH v3 0/6] drm/bridge: sii902x: HDMI-audio support and some fixes Jyri Sarha
2019-03-13 16:01 ` [PATCH v3 1/6] drm/bridge: sii902x: add input_bus_flags Jyri Sarha
2019-03-13 16:23 ` Laurent Pinchart [this message]
2019-03-13 16:01 ` [PATCH v3 2/6] drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID Jyri Sarha
2019-03-13 16:23 ` Laurent Pinchart
2019-03-13 16:01 ` [PATCH v3 3/6] drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz Jyri Sarha
2019-03-13 16:24 ` Laurent Pinchart
2019-03-13 16:01 ` [PATCH v3 4/6] dt-bindings: display: sii902x: Remove trailing white space Jyri Sarha
2019-03-13 16:24 ` Laurent Pinchart
2019-03-13 16:01 ` [PATCH v3 5/6] dt-bindings: display: sii902x: Add HDMI audio bindings Jyri Sarha
2019-03-13 16:29 ` Laurent Pinchart
2019-03-13 16:47 ` Laurent Pinchart
2019-03-13 17:52 ` Jyri Sarha
2019-03-13 18:12 ` Laurent Pinchart
2019-03-13 19:28 ` Jyri Sarha
2019-03-14 10:11 ` Olivier MOYSAN
2019-03-13 16:01 ` [PATCH v3 6/6] drm/bridge: sii902x: Implement HDMI audio support Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313162302.GH4722@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Songjun.Wu@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=jsarha@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox