From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/udl: use drm_gem_object_put_unlocked.
Date: Fri, 15 Mar 2019 12:22:28 +0100 [thread overview]
Message-ID: <20190315112228.GA2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190315014621.21816-1-airlied@gmail.com>
On Fri, Mar 15, 2019 at 11:46:20AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> When Daniel removed struct_mutex he didn't fix this call to the unlocked
> variant which is required since we no longer use struct mutex.
>
> This fixes a bunch of:
> WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 drm_gem_object_put+0x2b/0x30 [drm]
> Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t>
> CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2
>
> backtraces when you plug in a udl device.
>
> Fixes: ae358dacd217 (drm/udl: Get rid of dev->struct_mutex usage)
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/udl/udl_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
> index d5a23295dd80..bb7b58407039 100644
> --- a/drivers/gpu/drm/udl/udl_gem.c
> +++ b/drivers/gpu/drm/udl/udl_gem.c
> @@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
> *offset = drm_vma_node_offset_addr(&gobj->base.vma_node);
>
> out:
> - drm_gem_object_put(&gobj->base);
> + drm_gem_object_put_unlocked(&gobj->base);
> unlock:
> mutex_unlock(&udl->gem_lock);
> return ret;
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-03-15 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 1:46 [PATCH 1/2] drm/udl: use drm_gem_object_put_unlocked Dave Airlie
2019-03-15 1:46 ` [PATCH 2/2] drm/fb: avoid setting 0 depth Dave Airlie
2019-03-15 9:52 ` Linus Walleij
2019-03-15 11:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315112228.GA2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox