From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27 Date: Fri, 22 Mar 2019 10:47:00 +0100 Message-ID: <20190322094700.GE28640@ulmo> References: <0f864bee4e43c1fd7dbc2ab6917c99001510073c.1553086417.git.leonard.crestez@nxp.com> <20190321094903.p5smdd43r4tpj2kf@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1178365970==" Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77FA86E2EF for ; Fri, 22 Mar 2019 09:47:03 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id j9so1581592wrn.6 for ; Fri, 22 Mar 2019 02:47:03 -0700 (PDT) In-Reply-To: <20190321094903.p5smdd43r4tpj2kf@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Aisheng Dong , Abel Vesa , "dri-devel@lists.freedesktop.org" , dl-linux-imx , Fabio Estevam , Leonard Crestez , Shawn Guo , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org --===============1178365970== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="orO6xySwJI16pVnm" Content-Disposition: inline --orO6xySwJI16pVnm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 21, 2019 at 10:49:03AM +0100, Uwe Kleine-K=C3=B6nig wrote: > Hello, >=20 > On Wed, Mar 20, 2019 at 01:01:26PM +0000, Leonard Crestez wrote: > > Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new > > CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should > > enable it by default for imx. > >=20 > > Restoring the PWM driver fixes an infinite probe loop in 5.1-rc1 on > > various imx6qdl-sabresd boards. > >=20 > > Signed-off-by: Leonard Crestez > > Reported-by: Abel Vesa >=20 > This is prior art: >=20 > https://patchwork.ozlabs.org/project/linux-pwm/list/?series=3D85452&state= =3D%2A&archive=3Dboth >=20 > unfortunately this didn't get an Ack by Shawn and Thierry (added to > recipients) marked it as "Not Applicable". If I mark patches as "not applicable" it generally means that I don't intend to apply them to the PWM tree. Thierry > Given that the driver change is in Linus Torvald's tree now (since > v5.1-rc1~38) it doesn't matter much via which tree this goes in and > Shawn's tree is the easier now. >=20 > @Shawn: Would you please apply my patches? If you don't have them any > more, I can bounce them to you. See >=20 > git show v5.1-rc1~38^2~17 -- drivers/pwm/Kconfig >=20 > for their justification. >=20 > > --- > > arch/arm/configs/imx_v6_v7_defconfig | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > Probe loop repeats following lines: > >=20 > > [ 3.625031] pwm-backlight backlight-lvds: backlight-lvds supply powe= r not found, using dummy regulator > > [ 3.635868] panel-simple panel: panel supply power not found, using = dummy regulator > > [ 3.644844] [drm] Supports vblank timestamp caching Rev 2 (21.10.201= 3). > > [ 3.651478] [drm] No driver support for vblank timestamp query. > > [ 3.657660] imx-drm display-subsystem: bound imx-ipuv3-crtc.2 (ops i= pu_crtc_ops) > > [ 3.665240] imx-drm display-subsystem: bound imx-ipuv3-crtc.3 (ops i= pu_crtc_ops) > > [ 3.672819] imx-drm display-subsystem: bound imx-ipuv3-crtc.6 (ops i= pu_crtc_ops) > > [ 3.680393] imx-drm display-subsystem: bound imx-ipuv3-crtc.7 (ops i= pu_crtc_ops) > > [ 3.688312] dwhdmi-imx 120000.hdmi: Detected HDMI TX controller v1.3= 0a with HDCP (DWC HDMI 3D TX PHY) > > [ 3.699743] imx-drm display-subsystem: bound 120000.hdmi (ops dw_hdm= i_imx_ops) > > [ 3.707343] imx-drm display-subsystem: failed to bind ldb (ops imx_l= db_ops): -517 > > [ 3.716921] imx-drm display-subsystem: master bind failed: -517 > > > > Maybe it's an imx-drm bug which got exposed by accident? >=20 > IMHO this should be debugged independent of this patch. > =20 > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/im= x_v6_v7_defconfig > > index 5586a5074a96..2fa5074f5244 100644 > > --- a/arch/arm/configs/imx_v6_v7_defconfig > > +++ b/arch/arm/configs/imx_v6_v7_defconfig > > @@ -397,10 +397,11 @@ CONFIG_SENSORS_ISL29018=3Dy > > CONFIG_MAG3110=3Dy > > CONFIG_MPL3115=3Dy > > CONFIG_PWM=3Dy > > CONFIG_PWM_FSL_FTM=3Dy > > CONFIG_PWM_IMX=3Dy > > +CONFIG_PWM_IMX27=3Dy >=20 > PWM_IMX is gone, so this can be dropped (but see my patch referenced > above). >=20 > > CONFIG_NVMEM_IMX_OCOTP=3Dy > > CONFIG_NVMEM_VF610_OCOTP=3Dy > > CONFIG_TEE=3Dy > > CONFIG_OPTEE=3Dy > > CONFIG_MUX_MMIO=3Dy >=20 > Best regards > Uwe >=20 > --=20 > Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | > Industrial Linux Solutions | http://www.pengutronix.de/ | --orO6xySwJI16pVnm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlyUrw4ACgkQ3SOs138+ s6G4pRAAlxn4jfqwwCUOXJhTvbNLbWKIbQfkgmUNKcjb4LRbP20ZD6gNj1F+GgJw pmSvE7fUMWaATxQ1GefbROiwMAGxbEn+jSvVw8m5GFajT/Mys7SzkbPTIPOs1cNq EKXxunAkIznIJ6fp8mp2RHVLCnBRuNOp1ugTj9A2hWYbID6e0S303eh4UucZ16pR PyDeDuUCrAlLCwP/KTONeWaUS8nS37jo3NkoWpmLjsz/yx4SRJ/R1xiZNUGeEq8Y 4yQUDRaTkrKwF8mkHvI/YTqkgVuHzt0doVxb65pCe95t8Nu0SaDV1feKn7B7uUYO ttAGl8Q3P1Y2zTzxd6bJAhuPuC8CnF4wa1L3NVDm/97n/FXzT+cLr45w17Vw6vJr vV6l0/zLxOQOp6cL4k9HhJ8L6WyctQYqL+rMmUioeqTBv2UrFZ//Z7bUqrz5DoPg VLzNT2vNF24/HEoJy7g5ZlYKj2Qo/vA7UNHXZKlbAGorlmscwJwuFfRCLz43F6uY Nd24pjmmqjN6lZFAQSq08VjOkMtGYEWn1XPmWoReuAJZnUmNwTb3p+wMk8A3tP81 o4waGUjfGuVnPK2dEkqhGuvAcK0Qfek+L0MJNDh3/moG659I1sRXwL7z929w8Eht fJYiAWQD/PecwdAwYoDWL9ztdXttv+5p1lhH4NTh6ax8afm43V8= =fyjX -----END PGP SIGNATURE----- --orO6xySwJI16pVnm-- --===============1178365970== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1178365970==--