From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers Date: Thu, 28 Mar 2019 19:53:07 +0100 Message-ID: <20190328185307.GZ2665@phenom.ffwll.local> References: <20190320154809.14823-1-paul.kocialkowski@bootlin.com> <20190320154809.14823-2-paul.kocialkowski@bootlin.com> <87zhpph4c2.fsf@anholt.net> <82618ee8c2a2380a62b1fb894e5c35c602e20f3d.camel@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D0D16E7D3 for ; Thu, 28 Mar 2019 18:53:12 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id v21so18147377edq.4 for ; Thu, 28 Mar 2019 11:53:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <82618ee8c2a2380a62b1fb894e5c35c602e20f3d.camel@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Kocialkowski Cc: Thomas Petazzoni , Eben Upton , Maxime Ripard , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMDQ6Mjc6MDZQTSArMDEwMCwgUGF1bCBLb2NpYWxrb3dz a2kgd3JvdGU6Cj4gSGksCj4gCj4gTGUgbWVyY3JlZGkgMjAgbWFycyAyMDE5IMOgIDA5OjU2IC0w NzAwLCBFcmljIEFuaG9sdCBhIMOpY3JpdCA6Cj4gPiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5r b2NpYWxrb3dza2lAYm9vdGxpbi5jb20+IHdyaXRlczoKPiA+IAo+ID4gPiBUaGUgZmlyc3RvcGVu IERSTSBkcml2ZXIgaG9vayB3YXMgaW5pdGlhbGx5IHVzZWQgdG8gcGVyZm9ybSBoYXJkd2FyZQo+ ID4gPiBpbml0aWFsaXphdGlvbiwgd2hpY2ggaXMgbm93IGNvbnNpZGVyZWQgbGVnYWN5LiBPbmx5 IGEgc2luZ2xlIHVzZXIgb2YKPiA+ID4gZmlyc3RvcGVuIHJlbWFpbnMgYXQgdGhpcyBwb2ludCAo c2F2YWdlKS4KPiA+ID4gCj4gPiA+IEluIHNvbWUgc3BlY2lmaWMgY2FzZXMsIG5vbi1sZWdhY3kg ZHJpdmVycyBtYXkgYWxzbyBuZWVkIHRvIGltcGxlbWVudAo+ID4gPiB0aGVzZSBob29rcy4gRm9y IGluc3RhbmNlIG9uIFZDNCwgd2UgbmVlZCB0byBhbGxvY2F0ZSBhIDE2IE1pQiBidWZmZXIKPiA+ ID4gZm9yIHRoZSBHUFUuIEJlY2F1c2UgaXQncyBub3QgcmVxdWlyZWQgZm9yIGZiY29uLCBpdCdz IGEgd2FzdGUgdG8KPiA+ID4gYWxsb2NhdGUgaXQgYmVmb3JlIHVzZXJzcGFjZSBzdGFydHMgdXNp bmcgdGhlIERSTSBkZXZpY2UuCj4gPiA+IAo+ID4gPiBVc2luZyBmaXJzdG9wZW4gYW5kIGxhc3Rj bG9zZSBmb3IgdGhpcyBhbGxvY2F0aW9uIHNlZW1zIGxpa2UgdGhlIGJlc3QKPiA+ID4gZml0LCBz byByZS1oYWJpbGl0YXRlIHRoZSBob29rIHRvIGFsbG93IGl0IHRvIGJlIGNhbGxlZCBmb3Igbm9u LWxlZ2FjeQo+ID4gPiBkcml2ZXJzLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBL b2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tPgo+ID4gPiAtLS0KPiA+ ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmlsZS5jIHwgMyArLS0KPiA+ID4gIGluY2x1ZGUvZHJt L2RybV9kcnYuaCAgICAgIHwgMiArLQo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9maWxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZpbGUuYwo+ID4gPiBpbmRl eCBiMTgzOGE0MWFkNDMuLmMwMTFiNWNiZmI2YiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9maWxlLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9maWxlLmMK PiA+ID4gQEAgLTI2Niw4ICsyNjYsNyBAQCBzdGF0aWMgaW50IGRybV9zZXR1cChzdHJ1Y3QgZHJt X2RldmljZSAqIGRldikKPiA+ID4gIHsKPiA+ID4gIAlpbnQgcmV0Owo+ID4gPiAgCj4gPiA+IC0J aWYgKGRldi0+ZHJpdmVyLT5maXJzdG9wZW4gJiYKPiA+ID4gLQkgICAgZHJtX2NvcmVfY2hlY2tf ZmVhdHVyZShkZXYsIERSSVZFUl9MRUdBQ1kpKSB7Cj4gPiA+ICsJaWYgKGRldi0+ZHJpdmVyLT5m aXJzdG9wZW4pIHsKPiA+ID4gIAkJcmV0ID0gZGV2LT5kcml2ZXItPmZpcnN0b3BlbihkZXYpOwo+ ID4gPiAgCQlpZiAocmV0ICE9IDApCj4gPiA+ICAJCQlyZXR1cm4gcmV0Owo+ID4gPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9kcm0vZHJtX2Rydi5oIGIvaW5jbHVkZS9kcm0vZHJtX2Rydi5oCj4gPiA+ IGluZGV4IGNhNDZhNDVhOWNjZS4uYWExNDYwN2U1NGQ0IDEwMDY0NAo+ID4gPiAtLS0gYS9pbmNs dWRlL2RybS9kcm1fZHJ2LmgKPiA+ID4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2Rydi5oCj4gPiA+ IEBAIC0yMzYsNyArMjM2LDcgQEAgc3RydWN0IGRybV9kcml2ZXIgewo+ID4gPiAgCSAqIHRvIHNl dC91bnNldCB0aGUgVlQgaW50byByYXcgbW9kZS4KPiA+ID4gIAkgKgo+ID4gPiAgCSAqIExlZ2Fj eSBkcml2ZXJzIGluaXRpYWxpemUgdGhlIGhhcmR3YXJlIGluIHRoZSBAZmlyc3RvcGVuIGNhbGxi YWNrLAo+ID4gPiAtCSAqIHdoaWNoIGlzbid0IGV2ZW4gY2FsbGVkIGZvciBtb2Rlcm4gZHJpdmVy cy4KPiA+ID4gKwkgKiBtb2Rlcm4gZHJpdmVycyBjYW4gdXNlIGl0IGZvciBvdGhlciBwdXJwb3Nl cyBvbmx5Lgo+ID4gPiAgCSAqLwo+ID4gPiAgCXZvaWQgKCpsYXN0Y2xvc2UpIChzdHJ1Y3QgZHJt X2RldmljZSAqKTsKPiA+IAo+ID4gT3VyIHVzYWdlIGluIHZjNCBpcyBub3QgdmVyeSBkaWZmZXJl bnQgZnJvbSB3aGF0IHdlIGNhbGxlZCAiaGFyZHdhcmUKPiA+IGluaXRpYWxpemF0aW9uIiBpbiBv dGhlciBkZXZpY2VzLiAgSSB3b3VsZCByYXRoZXIganVzdCBkZWxldGUgdGhpcwo+ID4gc2VudGVu Y2UgZW50aXJlbHkuCj4gCj4gU291bmRzIGdvb2QgdG8gbWUhCj4gCj4gPiBUaGUgb25seSBhbHRl cm5hdGl2ZSBJIGNhbiB0aGluayBvZiB0byB1c2luZyBhIGZpcnN0b3Blbi9sYXN0Y2xvc2Utc3R5 bGUKPiA+IGFsbG9jYXRpb24gZm9yIHRoaXMgd291bGQgYmUgdG8gYWxsb2NhdGUgdGhlIGJpbiBi byBvbiB0aGUgZmlyc3QKPiA+IChub24tZHVtYj8pIFYzRCBCTyBhbGxvY2F0aW9uIGFuZCByZWZj b3VudCB0aG9zZSB0byBmcmVlIHRoZSBiaW5uZXIuCj4gCj4gSSBkb24ndCBzZWUgb3RoZXIgb3B0 aW9ucyBlaXRoZXIsIGFuZCB1c2luZyBmaXJzdGNsb3NlL2xhc3RvcGVuIGZlZWxzCj4gb3ZlcmFs bCBtb3JlIHJlYWRhYmxlIGluIHRoZSBkcml2ZXIgY29kZS4KPiAKPiBJJ20gbm90IHN1cmUgdGhl cmUgaXMgc3VjaCBhIGJpZyBvdmVyaGVhZCBhc3NvY2lhdGVkIHdpdGggYWxsb2NhdGluZwo+IHRo ZSBiaW5uZXIgQk8gKGl0IHNlZW1zIHRoYXQgdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gdHJp ZXMgdG8gYWxsb2MKPiB1bnRpbCB0aGUgc3BlY2lmaWMgbWVtb3J5IGNvbnN0cmFpbnRzIGZvciB0 aGUgYnVmZmVyIGFyZSBtZXQsIHNvCj4gcGVyaGFwcyB0aGF0IGNhbiB0YWtlIHRpbWUpLiBCdXQg aWYgdGhlcmUgaXMsIEkgc3VwcG9zZSBpdCdzIGJlc3QgdG8KPiBoYXZlIHRoYXQgd2hlbiBzdGFy dGluZyB1cCByYXRoZXIgdGhhbiBkZWxheWluZyB0aGUgZmlyc3QgcmVuZGVyCj4gb3BlcmF0aW9u LgoKSSdtIG5vdCBlbnRpcmVseSBidXlpbmcgdGhlICJ3ZSBkb24ndCBuZWVkIHRoaXMgZm9yIGZi Y29uIG9ubHkiIGFyZ3VtZW50IC0KdGhlcmUncyBwbGVudHkgb2YgZHVtYiBrbXMgY2xpZW50cyB0 b28gKGJvb3Qgc3BsYXNoIGFuZCB3aGF0ZXZlciBlbHNlCnRoZXJlIG1pZ2h0IGJlKS4gSWYgeW91 IGRvbid0IHdhbnQgdG8ga2VlcCB0aGlzIGFyb3VuZCBJIHRoaW5rIGFsbG9jYXRpbmcKb24gZmly c3Qgbm9uLWR1bWIgYm8gYWxsb2NhdGlvbiBhbmQgZHJvcHBpbmcgaXQgd2hlbiB0aGUgbGFzdCBz dWNoIGZkCmNsb3NlcyBzb3VuZHMgbGlrZSBhIG11Y2ggYmV0dGVyIGlkZWEuIE5lZWRzIGEgYml0 IG1vcmUgc3RhdGUsIHlvdSBuZWVkIHRvCnRyYWNrIHBlciBkcm1fZmlsZSB3aGV0aGVyIHlvdSd2 ZSBhbHJlYWR5IGFsbG9jYXRlZCBhIG5vbi1kdW1iIGJvLCBhbmQgYQpkcm1fZGV2aWNlIHJlZmNv dW50LCBidXQgdGhhdCdzIG5vdCBtdWNoLiBGaXJzdG9wZW4gZmVlbHMgbGlrZSB0aGUgd3JvbmcK dGhpbmcuCgpBbm90aGVyIG9wdGlvbiB3b3VsZCBiZSBmaXJzdF9yZW5kZXJvcGVuIG9yIHNvbWV0 aGluZyBsaWtlIHRoYXQsIGV4Y2VwdAp5b3UgY2FuIGFsc28gcmVuZGVyIG9uIHRoZSBsZWdhY3kg bm9kZSBhbmQgSSdtIG5vdCBzdXJlIGhvdyBtdWNoIHRoZXJlJ3MgYQpkZW1hbmQgZm9yIHRoaXMg aW4gb3RoZXIgZHJpdmVycy4gSW4gdGhlIGVuZCB5b3UgaGF2ZSBvcGVuL2Nsb3NlCmNhbGxiYWNr cywgeW91IGNhbiBkbyBhbGwgdGhlIGRyaXZlciBzcGVjaWZpYyB0aGluZ3MgeW91IHdhbnQgdG8g ZG8gaW4KdGhlcmUuCgpBc2lkZTogSSBraW5kYSBhbHNvIHdhbnQgdG8gZGl0Y2ggbGFzdGNsb3Nl IHVzYWdlLiBUaGVyZSdzIGZiZGV2ICh3ZSBoYXZlIGEKYmV0dGVyIHNvbHV0aW9uIHdpdGggTm9y YWxmJ3MgZHJtX2NsaWVudCBmb3IgdGhvc2UpIGFuZCBydW50aW1lIHBtICh3aGljaApmcmFua2x5 IGlzIGp1c3QgYSBjaGVhcCBoYWNrLCBJIHdhbnQgbXkgZ3B1IHRvIHN1c2VwZW5kIGFsc28gd2hl biBpdCdzIG5vdAppbiB1c2Ugd2hlbiBhbGwgdGhlIHNjcmVlbnMgYXJlIG9mZiwgbm90IG9ubHkg d2hlbiBJIGtpbGxlZCBYIGFuZApldmVyeXRoaW5nKS4KLURhbmllbAotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs