From: Sean Paul <sean@poorly.run>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Zain Wang <wzz@rock-chips.com>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Tomasz Figa <tfiga@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 3/5] drm/rockchip: Use the helpers for PSR
Date: Fri, 29 Mar 2019 15:12:24 -0400 [thread overview]
Message-ID: <20190329191224.GR114153@art_vandelay> (raw)
In-Reply-To: <2239852.haJQLvjc7A@diego>
On Fri, Mar 29, 2019 at 08:02:17PM +0100, Heiko Stübner wrote:
> Am Freitag, 29. März 2019, 20:00:10 CET schrieb Sean Paul:
> > On Fri, Mar 29, 2019 at 07:51:51PM +0100, Heiko Stübner wrote:
> > > Hi,
> > >
> > > Am Dienstag, 26. März 2019, 21:44:56 CET schrieb Sean Paul:
> > > > From: Sean Paul <seanpaul@chromium.org>
> > > >
> > > > Instead of rolling our own implementation for tracking when PSR should
> > > > be [in]active, use the new self refresh helpers to do the heavy lifting.
> > >
> > > I only got patches 3-5 and had to pull 1+2 from patchwork, the following
> > > applies to the whole series though.
> > >
> > > While my Kevin display does still generally work with these 5 patches
> > > applied functionality has regressed somehow.
> > >
> > > Environment is a standard Debian with framebuffer console and sddm
> > > login manager.
> >
> > Ahh, this is probably b/c fb_dirty is not triggering PSR exit. I had it
> > working in v1, but removed it in v2 since Daniel suggested we require the
> > fb_dirty helpers. I neglected to add support for the fb_dirty helpers, so fbcon
> > updates won't cause the screen to refresh. I'll add the helpers in v3 and make
> > sure I test it out with fbcon.
> >
> > Thanks for reporting this!
>
> The cursor-not-blinking case above was X11+modesetting+sddm though, so
> not directly fbcon-related probably ... 2nd issue?
Yep, definitely could be. If you have the chance, could you collect some
DRM_DEBUG_KMS logs for the second issue to see what's going on? My guess is
there's a legacy path (update_plane?) that's somehow not triggering psr exit.
Sean
>
> Heiko
>
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-29 19:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 20:44 [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers Sean Paul
2019-03-26 20:44 ` [PATCH v2 2/5] drm/rockchip: Check for fast link training before enabling psr Sean Paul
2019-03-26 20:44 ` [PATCH v2 3/5] drm/rockchip: Use the helpers for PSR Sean Paul
2019-03-29 18:51 ` Heiko Stübner
2019-03-29 19:00 ` Sean Paul
2019-03-29 19:02 ` Heiko Stübner
2019-03-29 19:12 ` Sean Paul [this message]
2019-03-29 19:24 ` Daniel Vetter
2019-03-26 20:44 ` [PATCH v2 4/5] drm/rockchip: Don't fully disable vop on self refresh Sean Paul
2019-03-26 20:44 ` [PATCH v2 5/5] drm/rockchip: Use drm_atomic_helper_commit_tail_rpm Sean Paul
2019-03-27 18:15 ` [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers Daniel Vetter
2019-03-28 21:03 ` Sean Paul
2019-03-29 8:21 ` Daniel Vetter
2019-03-29 13:16 ` Sean Paul
2019-03-29 15:36 ` Daniel Vetter
2019-03-29 18:10 ` Sean Paul
2019-03-29 19:21 ` Daniel Vetter
2019-04-01 13:49 ` Sean Paul
2019-04-02 7:49 ` Daniel Vetter
2019-04-02 13:24 ` Sean Paul
2019-04-02 16:05 ` Daniel Vetter
2019-04-02 16:47 ` Sean Paul
2019-04-03 6:52 ` Daniel Vetter
2019-04-02 14:16 ` Ville Syrjälä
2019-03-28 14:42 ` Dan Carpenter
2019-04-02 8:55 ` Neil Armstrong
2019-04-02 9:08 ` Daniel Vetter
2019-04-02 9:45 ` Neil Armstrong
2019-04-02 9:50 ` Daniel Vetter
2019-04-02 9:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329191224.GR114153@art_vandelay \
--to=sean@poorly.run \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
--cc=wzz@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox