From: Sam Ravnborg <sam@ravnborg.org>
To: Uma Shankar <uma.shankar@intel.com>
Cc: dcastagna@chromium.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, seanpaul@chromium.org,
ville.syrjala@intel.com, maarten.lankhorst@intel.com
Subject: Re: [v2 3/7] drm: Add gamma mode property
Date: Mon, 1 Apr 2019 20:37:26 +0200 [thread overview]
Message-ID: <20190401183726.GC886@ravnborg.org> (raw)
In-Reply-To: <1554139811-13280-4-git-send-email-uma.shankar@intel.com>
Hi Uma.
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -256,6 +256,13 @@ struct drm_crtc_state {
> struct drm_property_blob *gamma_mode_caps;
>
> /**
> + * @gamma_mode:
> + *
> + * FIXME
> + */
> + struct drm_property_blob *gamma_mode;
HEre the name matches, but please add documentation too.
>
> +struct drm_color_mode_lut {
> + /* DRM_MODE_LUT_* */
> + __u32 flags;
> + /* number of points on the curve */
> + __u32 count;
> + /* Name of Gamma Mode */
> + char name[DRM_PROP_NAME_LEN];
> + /* Pointer to Lut elements */
> + __u64 lut;
> +};
From an alignment point of view the __u64 should come before the char name[].
But the above may be fine depending on DRM_PROP_NAME_LEN
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-01 18:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 17:30 [v2 0/7] Add Multi Segment Gamma Support Uma Shankar
2019-04-01 17:30 ` [v2 1/7] drm: Add gamma mode caps property Uma Shankar
2019-04-01 18:33 ` Sam Ravnborg
2019-04-08 14:45 ` Shankar, Uma
2019-04-01 17:30 ` [v2 2/7] drm/i915: Define color lut range structure Uma Shankar
2019-04-08 10:09 ` Ville Syrjälä
2019-04-08 12:28 ` Shankar, Uma
2019-04-01 17:30 ` [v2 3/7] drm: Add gamma mode property Uma Shankar
2019-04-01 18:37 ` Sam Ravnborg [this message]
2019-04-08 14:49 ` Shankar, Uma
2019-04-01 17:30 ` [v2 4/7] drm/i915/icl: Add register definitions for Multi Segmented gamma Uma Shankar
2019-04-01 17:30 ` [v2 5/7] drm/i915/icl: Add support for multi segmented gamma mode Uma Shankar
2019-04-08 10:19 ` Ville Syrjälä
2019-04-08 12:51 ` Shankar, Uma
2019-04-01 17:30 ` [v2 6/7] drm/i915: Add gamma mode caps property Uma Shankar
2019-04-01 17:30 ` [v2 7/7] drm/i915: Attach gamma mode property Uma Shankar
2019-04-05 16:12 ` [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support Ville Syrjälä
2019-04-08 12:26 ` Shankar, Uma
2019-04-08 12:31 ` Ville Syrjälä
2019-04-08 14:40 ` Shankar, Uma
2019-04-08 14:57 ` [Intel-gfx] " Ville Syrjälä
2019-04-08 15:40 ` Shankar, Uma
2019-04-08 15:45 ` Ville Syrjälä
2019-04-08 15:59 ` Shankar, Uma
2019-04-08 16:07 ` [Intel-gfx] " Ville Syrjälä
2019-04-10 13:20 ` Shankar, Uma
2019-04-10 15:38 ` Ville Syrjälä
2019-04-11 7:59 ` [Intel-gfx] " Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401183726.GC886@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dcastagna@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
--cc=seanpaul@chromium.org \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).