From: Sam Ravnborg <sam@ravnborg.org>
To: Uma Shankar <uma.shankar@intel.com>
Cc: dcastagna@chromium.org, intel-gfx@lists.freedesktop.org,
emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org,
seanpaul@chromium.org, ville.syrjala@intel.com,
maarten.lankhorst@intel.com
Subject: Re: [v7 1/9] drm: Add HDR source metadata property
Date: Tue, 2 Apr 2019 22:39:42 +0200 [thread overview]
Message-ID: <20190402203942.GB15782@ravnborg.org> (raw)
In-Reply-To: <1554236430-7466-2-git-send-email-uma.shankar@intel.com>
Hi Uma.
Some kerneldoc nits below.
Sam
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -599,6 +599,13 @@ struct drm_connector_state {
> * and the connector bpc limitations obtained from edid.
> */
> u8 max_bpc;
> +
> + /**
> + * @metadata_blob_ptr:
> + * DRM blob property for HDR output metadata
> + */
> + struct drm_property_blob *hdr_output_metadata_blob_ptr;
The kerneldoc comment uses the wrong name.
> + u8 hdr_metadata_changed : 1;
kerneldoc is missing.
> };
>
> /**
> @@ -1239,6 +1246,9 @@ struct drm_connector {
> * &drm_mode_config.connector_free_work.
> */
> struct llist_node free_node;
> +
> + /* HDR metdata */
> + struct hdr_output_metadata hdr_metadata;
Please format as kerneldoc.
> };
>
> #define obj_to_connector(x) container_of(x, struct drm_connector, base)
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 7f60e8e..ef2656b 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -836,6 +836,12 @@ struct drm_mode_config {
> */
> struct drm_property *writeback_out_fence_ptr_property;
>
> + /*
> + * hdr_metadata_property: Connector property containing hdr metatda
> + * This will be provided by userspace compositors based on HDR content
> + */
> + struct drm_property *hdr_output_metadata_property;
> +
kerneldoc comment uses wrong name
> /* dumb ioctl parameters */
> uint32_t preferred_depth, prefer_shadow;
Please format as kerneldoc.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-02 20:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 20:20 [v7 0/9] Add HDR Metadata Parsing and handling in DRM layer Uma Shankar
2019-04-02 20:20 ` [v7 1/9] drm: Add HDR source metadata property Uma Shankar
2019-04-02 20:39 ` Sam Ravnborg [this message]
2019-04-08 10:20 ` Jonas Karlman
2019-04-09 16:17 ` Shankar, Uma
2019-04-02 20:20 ` [v7 2/9] drm: Parse HDR metadata info from EDID Uma Shankar
2019-04-02 20:20 ` [v7 3/9] drm: Enable HDR infoframe support Uma Shankar
2019-04-02 20:37 ` Sam Ravnborg
2019-04-02 20:20 ` [v7 4/9] drm/i915: Attach HDR metadata property to connector Uma Shankar
2019-04-02 20:20 ` [v7 5/9] drm/i915: Write HDR infoframe and send to panel Uma Shankar
2019-04-02 20:20 ` [v7 6/9] drm/i915: Add HLG EOTF Uma Shankar
2019-04-02 20:20 ` [v7 7/9] drm/i915: Enable infoframes on GLK+ for HDR Uma Shankar
2019-04-02 20:20 ` [v7 8/9] drm/i915:Enabled Modeset when HDR Infoframe changes Uma Shankar
2019-04-02 20:20 ` [v7 9/9] drm/i915: Set Infoframe for non modeset case for HDR Uma Shankar
2019-04-08 9:31 ` [v7 0/9] Add HDR Metadata Parsing and handling in DRM layer Sharma, Shashank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402203942.GB15782@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dcastagna@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
--cc=seanpaul@chromium.org \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).