From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: otm8009a: add delay at the end of initialization Date: Wed, 3 Apr 2019 18:22:26 +0200 Message-ID: <20190403162226.GO5238@ulmo> References: <1553155445-13407-1-git-send-email-yannick.fertre@st.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1759503662==" Return-path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A83C6E861 for ; Wed, 3 Apr 2019 16:22:30 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id z6so5234831wmi.0 for ; Wed, 03 Apr 2019 09:22:29 -0700 (PDT) In-Reply-To: <1553155445-13407-1-git-send-email-yannick.fertre@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yannick =?utf-8?Q?Fertr=C3=A9?= Cc: David Airlie , Philippe Cornu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com List-Id: dri-devel@lists.freedesktop.org --===============1759503662== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jozmn01XJZjDjM3N" Content-Disposition: inline --jozmn01XJZjDjM3N Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 21, 2019 at 09:04:05AM +0100, Yannick Fertr=C3=A9 wrote: > At the end of initialization, a delay is required by the panel. > Without this delay, the panel could received a frame early & > generate a crash of panel (black screen). >=20 > Signed-off-by: Yannick Fertr=C3=A9 > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 3 +++ > 1 file changed, 3 insertions(+) Applied. You might want to go over this panel and replace some of the mdelay() calls with msleep(). There are some that busy loop for 120 ms, which is somewhat rude. Even the mdelay(10) in this driver should be safe to convert to msleep(). Thierry --jozmn01XJZjDjM3N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlyk3cIACgkQ3SOs138+ s6EtVA//Z69QgKOAgOwcilMw4WqewduCjc0p/gQGzU2QXC3PpvigA8rtUpDznXP7 4TJ8GAxiQxXWR1oOxcGKM6ih1MmeLM6z3bk8TSxyndZznOLu3QUxpIsFlyBcJ67a R3n1YUf7NSyaT4uWhuJjRCdU/Tws59019ANk/iLC+udMMSxzNHbXxq4tRFtRvcHT YG0965BSp9Bp+Ij9qRiYeWkYcTWAS1Er1wBYrGR3jpRVa3HaKK2nRf5C6BM4CmdX iR0Jt6u7IL0M1Qub9f2JfVGVtJxLdbrsCYT8kfERwmJLxadLtc2B7qwF7uALD/V2 WVGCSLqjLK0S8nGTJTbsaVO7w1xt3o5G5UbprzHpHIdWUU8azgDdGSVk9si9SW1t 0z3L98aGk2e/8zmFxHeL0zgl6Uo+8kk0IwupwVOLEKvq6cxjEQ2PzJOHWXlBhgpz 544no7JxlvVaqkbEO9SpzRBaqR2GtXbCbIvER/u9AiFVOPNKI90PE0MJM04s6ovz Zb3q/mST3aw+lfoeGdmq+TScm2vRzx7VoHQHZlugUJBjQg4FMYaJsnfiD0AC2ERG uC8YrNltVUzKDyommtMpJmQz3rB0oIl0vBuz+RbagZZEujZDwYulz/6Sfh9FclRQ tR+5MTXzoAxHO/XVqiXh2zdH+KAhaBwAUuA9sN3r8tH5tAuEPYQ= =FgDU -----END PGP SIGNATURE----- --jozmn01XJZjDjM3N-- --===============1759503662== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1759503662==--