From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alyssa Rosenzweig Subject: Re: [PATCH 2/3] drm/panfrost: Expose HW counters to userspace Date: Thu, 4 Apr 2019 08:41:29 -0700 Message-ID: <20190404154129.GA2999@rosenzweig.io> References: <20190404152051.17996-1-boris.brezillon@collabora.com> <20190404152051.17996-3-boris.brezillon@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from rosenzweig.io (rosenzweig.io [107.170.207.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BC266EA14 for ; Thu, 4 Apr 2019 15:41:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190404152051.17996-3-boris.brezillon@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Rob Herring , kernel@collabora.com, dri-devel@lists.freedesktop.org, Neil Armstrong List-Id: dri-devel@lists.freedesktop.org PiArCS8qCj4gKwkgKiBJbiB2NCBIVyB3ZSBoYXZlIG9uZSB0aWxlciBwZXIgY29yZSBncm91cCwg d2l0aCB0aGUgbnVtYmVyCj4gKwkgKiBvZiBjb3JlIGdyb3VwcyBiZWluZyBlcXVhbCB0byB0aGUg bnVtYmVyIG9mIEwyIGNhY2hlcy4gT3RoZXIKPiArCSAqIEhXIHZlcnNpb25zIGp1c3QgaGF2ZSBv bmUgdGlsZXIgYW5kIHRoZSBudW1iZXIgb2YgTDIgY2FjaGVzCj4gKwkgKiBjYW4gYmUgZXh0cmFj dGVkIGZyb20gdGhlIG1lbV9mZWF0dXJlcyBmaWVsZC4KPiArCSAqLwoKTm9ybWFsaXppbmcgbGF5 b3V0IGluIGtlcm5lbCBzb3VuZHMgbGlrZSBhIGdvb2QgaWRlYSB0byBtZSwgbmljZSBvbmUgOikK KGtiYXNlIGRvZXMgbm90IGFuZCB1c2Vyc3BhY2UgaXMgbWVzc3kgYXMgYSByZXN1bHQpCgo+ICsv Kgo+ICsgKiBSZXR1cm5zIHRydWUgaWYgdGhlIDIgam9icyBoYXZlIGV4YWN0bHkgdGhlIHNhbWUg cGVyZmNudCBjb250ZXh0LCBmYWxzZQo+ICsgKiBvdGhlcndpc2UuCj4gKyAqLwo+ICtzdGF0aWMg Ym9vbCBwYW5mcm9zdF9wZXJmY250X2pvYl9jdHhfY21wKHN0cnVjdCBwYW5mcm9zdF9wZXJmY250 X2pvYl9jdHggKmEsCj4gKwkJCQkJIHN0cnVjdCBwYW5mcm9zdF9wZXJmY250X2pvYl9jdHggKmIp Cj4gK3sKPiArCXVuc2lnbmVkIGludCBpLCBqOwo+ICsKPiArCWlmIChhLT5wZXJmbW9uX2NvdW50 ICE9IGItPnBlcmZtb25fY291bnQpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCWZvciAoaSA9 IDA7IGkgPCBhLT5wZXJmbW9uX2NvdW50OyBpKyspIHsKPiArCQlmb3IgKGogPSAwOyBqIDwgYi0+ cGVyZm1vbl9jb3VudDsgaisrKSB7Cj4gKwkJCWlmIChhLT5wZXJmbW9uc1tpXSA9PSBiLT5wZXJm bW9uc1tqXSkKPiArCQkJCWJyZWFrOwo+ICsJCX0KPiArCj4gKwkJaWYgKGogPT0gYi0+cGVyZm1v bl9jb3VudCkKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICsJfQo+ICsKCldvdWxkIHVzaW5nIG1lbWNt cCgpIGJlIGNsZWFuZXIgaGVyZT8KCj4gKwlpZiAocGFuZnJvc3RfbW9kZWxfY21wKHBmZGV2LCAw eDEwMDApID49IDApCgpXaGF0IGRvZXMgMHgxMDAwIHJlZmVyIHRvIGhlcmU/IEknbSBhc3N1bWlu ZyBtYXliZSBCaWZyb3N0LCBidXQgaXQncyBub3QKb2J2aW91cy4uLiBwcm9iYWJseSBiZXR0ZXIg dG8gaGF2ZSBhICNkZWZpbmUgc29tZXdoZXJlIGFuZCB1c2UgdGhhdCAob3IKYW4gZW51bSBlcXVp dmFsZW50bHkpLgoKPiArCS8qCj4gKwkgKiBEdWUgdG8gUFJMQU0tODE4NiB3ZSBuZWVkIHRvIGRp c2FibGUgdGhlIFRpbGVyIGJlZm9yZSB3ZSBlbmFibGUgSFcKPiArCSAqIGNvdW50ZXJzLgo+ICsJ ICovCgpXaGF0IG9uIGVhcnRoIGlzIFBSTEFNLTgxODY/IDopCgpBY3R1YWxseSwgd2FpdCwgSSBj YW4gYW5zd2VyIHRoYXQgLS0gb2xkIGtiYXNlIHZlcnNpb25zIGhhZCBhbiBlcnJhdGEKbGlzdDoK CiAgICAgICAgLyogV3JpdGUgb2YgUFJGQ05UX0NPTkZJR19NT0RFX01BTlVBTCB0byBQUkZDTlRf Q09ORklHIGNhdXNlcyBhIGluc3RydW1lbnRhdGlvbiBkdW1wIGlmCiAgICAgICAgICAgUFJGQ05U X1RJTEVSX0VOIGlzIGVuYWJsZWQgKi8KICAgICAgICBCQVNFX0hXX0lTU1VFXzgxODYsCgpTbyB0 aGF0J3Mgd2h5LiBJZiBwZW9wbGUgd2FudCwgSSdtIGNvbnNpZGVyaW5nIG1vdmluZyB0aGVzZSBl cnJhdGEKZGVzY3JpcHRpb25zIGJhY2sgaW50byB0aGUga2VybmVsIHdoZXJlIHBvc3NpYmxlLCBz aW5jZSBvdGhlcndpc2UgY29kZQpsaWtlIHRoaXMgaXMgb3BhcXVlLgoKPiArCQl1bnNpZ25lZCBp bnQgbmwyYywgbmNvcmVzOwo+ICsKPiArCQkvKgo+ICsJCSAqIFRPRE86IGRlZmluZSBhIG1hY3Jv IHRvIGV4dHJhY3QgdGhlIG51bWJlciBvZiBsMiBjYWNoZXMgZnJvbQo+ICsJCSAqIG1lbV9mZWF0 dXJlcy4KPiArCQkgKi8KPiArCQlubDJjID0gKChwZmRldi0+ZmVhdHVyZXMubWVtX2ZlYXR1cmVz ID4+IDgpICYgR0VOTUFTSygzLCAwKSkgKyAxOwo+ICsKPiArCQkvKgo+ICsJCSAqIFRoZSBBUk0g ZHJpdmVyIGlzIGdyb3VwaW5nIGNvcmVzIHBlciBjb3JlIGdyb3VwIGFuZCB0aGVuCj4gKwkJICog b25seSB1c2luZyB0aGUgbnVtYmVyIG9mIGNvcmVzIGluIGdyb3VwIDAgdG8gY2FsY3VsYXRlIHRo ZQo+ICsJCSAqIHNpemUuIE5vdCBzdXJlIHdoeSB0aGlzIGlzIGRvbmUgbGlrZSB0aGF0LCBidXQg SSBndWVzcwo+ICsJCSAqIHNoYWRlcl9wcmVzZW50IHdpbGwgb25seSBzaG93IGNvcmVzIGluIHRo ZSBmaXJzdCBncm91cAo+ICsJCSAqIGFueXdheS4KPiArCQkgKi8KPiArCQluY29yZXMgPSBod2Vp Z2h0NjQocGZkZXYtPmZlYXR1cmVzLnNoYWRlcl9wcmVzZW50KTsKPiArCgpEZWphIHZ1LiBXYXMg dGhpcyBjb3B5cGFzdGUgZG1heWJlPwoKPiArCQkgIChwYW5mcm9zdF9tb2RlbF9jbXAocGZkZXYs IDB4MTAwMCkgPj0gMCA/CgpUSGVyZSdzIHRoYXQgcGVza3kgMHgxMDAwIGFnYWluLgoKPiBAQCAt NTUsNiArNjMsMTUgQEAgc3RydWN0IGRybV9wYW5mcm9zdF9zdWJtaXQgewo+ICAKPiAgCS8qKiBB IGNvbWJpbmF0aW9uIG9mIFBBTkZST1NUX0pEX1JFUV8qICovCj4gIAlfX3UzMiByZXF1aXJlbWVu dHM7Cj4gKwo+ICsJLyoqIFBvaW50ZXIgdG8gYSB1MzIgYXJyYXkgb2YgcGVyZm1vbnMgdGhhdCBz aG91bGQgYmUgYXR0YWNoZWQgdG8gdGhlIGpvYi4gKi8KPiArCV9fdTY0IHBlcmZtb25faGFuZGxl czsKPiArCj4gKwkvKiogTnVtYmVyIG9mIHBlcmZtb24gaGFuZGxlcyBwYXNzZWQgaW4gKHNpemUg aXMgdGhhdCB0aW1lcyA0KS4gKi8KPiArCV9fdTMyIHBlcmZtb25faGFuZGxlX2NvdW50Owo+ICsK PiArCS8qKiBVbnVzZWQgZmllbGQsIHNob3VsZCBiZSBzZXQgdG8gMC4gKi8KPiArCV9fdTMyIHBh ZGRpbmc7CgpCbGVlcCBibG9ycC4gSWYgd2UncmUgbW9kaWZ5aW5nIF9zdWJtaXQsIHdlJ2xsIG5l ZWQgdG8gYmUgc3dpZnQgYWJvdXQKbWVyZ2luZyB0aGlzIGFoZWFkIG9mIHRoZSBtYWluIGNvZGUg dG8gbWFrZSBzdXJlIHdlIGRvbid0IGJyZWFrIHRoZQpVQUJJLiBBbHRob3VnaCBJIGd1ZXNzIGlm IHdlJ3JlIGp1c3QgYWRkaW5nIGZpZWxkcyBhdCB0aGUgZW5kLCB0aGF0J3MgYQpub25pc3N1ZS4K Cj4gK3N0cnVjdCBkcm1fcGFuZnJvc3RfYmxvY2tfcGVyZmNvdW50ZXJzIHsKPiArCS8qCj4gKwkg KiBGb3IgRFJNX0lPQ1RMX1BBTkZST1NUX0dFVF9QRVJGQ05UX0xBWU9VVCwgZW5jb2RlcyB0aGUg YXZhaWxhYmxlCj4gKwkgKiBpbnN0YW5jZXMgZm9yIGEgc3BlY2lmaWMgZ2l2ZW4gYmxvY2sgdHlw ZS4KPiArCSAqIEZvciBEUk1fSU9DVExfUEFORlJPU1RfQ1JFQVRFX1BFUkZNT04sIGVuY29kZXMg dGhlIGluc3RhbmNlcyB0aGUKPiArCSAqIHVzZXIgd2FudHMgdG8gbW9uaXRvci4KPiArCSAqIE5v dGU6IHRoZSBiaXRtYXAgbWlnaHQgYmUgc3BhcnNlLgo+ICsJICovCj4gKwlfX3U2NCBpbnN0YW5j ZXM7Cj4gKwo+ICsJLyoKPiArCSAqIEZvciBEUk1fSU9DVExfUEFORlJPU1RfR0VUX1BFUkZDTlRf TEFZT1VULCBlbmNvZGVzIHRoZSBhdmFpbGFibGUKPiArCSAqIGNvdW50ZXJzIGF0dGFjaGVkIHRv IGEgc3BlY2lmaWMgYmxvY2sgdHlwZS4KPiArCSAqIEZvciBEUk1fSU9DVExfUEFORlJPU1RfQ1JF QVRFX1BFUkZNT04sIGVuY29kZXMgdGhlIGNvdW50ZXJzIHRoZSB1c2VyCj4gKwkgKiB3YW50cyB0 byBtb25pdG9yLgo+ICsJICogTm90ZTogdGhlIGJpdG1hcCBtaWdodCBiZSBzcGFyc2UuCj4gKwkg Ki8KPiArCV9fdTY0IGNvdW50ZXJzOwo+ICt9OwoKSSBkb24ndCB1bmRlcnN0YW5kIHRoaXMuIEFy ZW4ndCB0aGVyZSBtb3JlIHRoYW4gNjQgY291bnRlcnM/Cgo+ICtzdHJ1Y3QgZHJtX3BhbmZyb3N0 X2dldF9wZXJmY250X2xheW91dCB7Cj4gKwlzdHJ1Y3QgZHJtX3BhbmZyb3N0X2Jsb2NrX3BlcmZj b3VudGVycyBjb3VudGVyc1tQQU5GUk9TVF9OVU1fQkxPQ0tTXTsKPiArfTsKCi0tT2guIEl0J3Mg cGVyLWJsb2NrLiBHb3QgaXQuCgo+ICsgKiBVc2VkIHRvIGNyZWF0ZSBhIHBlcmZvcm1hbmNlIG1v bml0b3IuIEVhY2ggcGVyZm1vbmFuY2UgbW9uaXRvciBpcyBhc3NpZ25lZCBhbgoKVHlwby4KCi0t LQoKT3ZlcmFsbCwgdGhpcyBsb29rcyByZWFsbHkgZ3JlYXQhIFRoYW5rIHlvdSEgOikKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs