From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 5/6] drm: add drm_fb_xrgb8888_to_rgb888() function to drm_fb_helper.c Date: Thu, 4 Apr 2019 19:16:06 +0200 Message-ID: <20190404171606.GE23897@ravnborg.org> References: <20190404152430.8263-1-kraxel@redhat.com> <20190404152430.8263-6-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190404152430.8263-6-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , open list , David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org Hi Gerd. On Thu, Apr 04, 2019 at 05:24:29PM +0200, Gerd Hoffmann wrote: > Like drm_fb_xrgb8888_to_rgb565() but converts to 24bpp (DRM_FORMAT_RGB888). > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_fb_helper.h | 4 +++ > drivers/gpu/drm/drm_fb_helper.c | 49 +++++++++++++++++++++++++++++++++ > 2 files changed, 53 insertions(+) > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 1406057e1a93..a6e56fcd948e 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -648,5 +648,9 @@ void drm_fb_xrgb8888_to_rgb565(u16 *dst, void *vaddr, > struct drm_framebuffer *fb, > struct drm_rect *clip, > bool swap, bool dstclip); > +void drm_fb_xrgb8888_to_rgb888(u8 *dst, void *vaddr, > + struct drm_framebuffer *fb, > + struct drm_rect *clip, > + bool dstclip); We have here three functions that take a *dst parameter: void *dst u8 *dst u16 *dst My OCD triggers when things like this is not consistent. But that said I see why the three implementations takes three different types. Something I noticed, so passed in onwards to you. Feel free to ignore. Sam