From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 2/3] drm/panfrost: Expose HW counters to userspace Date: Thu, 4 Apr 2019 20:17:17 +0200 Message-ID: <20190404201717.78d6cf47@collabora.com> References: <20190404152051.17996-1-boris.brezillon@collabora.com> <20190404152051.17996-3-boris.brezillon@collabora.com> <20190404154129.GA2999@rosenzweig.io> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F62F6E359 for ; Thu, 4 Apr 2019 18:17:21 +0000 (UTC) In-Reply-To: <20190404154129.GA2999@rosenzweig.io> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alyssa Rosenzweig Cc: Rob Herring , kernel@collabora.com, dri-devel@lists.freedesktop.org, Neil Armstrong List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCA0IEFwciAyMDE5IDA4OjQxOjI5IC0wNzAwCkFseXNzYSBSb3Nlbnp3ZWlnIDxhbHlz c2FAcm9zZW56d2VpZy5pbz4gd3JvdGU6CgoKPiA+ICsvKgo+ID4gKyAqIFJldHVybnMgdHJ1ZSBp ZiB0aGUgMiBqb2JzIGhhdmUgZXhhY3RseSB0aGUgc2FtZSBwZXJmY250IGNvbnRleHQsIGZhbHNl Cj4gPiArICogb3RoZXJ3aXNlLgo+ID4gKyAqLwo+ID4gK3N0YXRpYyBib29sIHBhbmZyb3N0X3Bl cmZjbnRfam9iX2N0eF9jbXAoc3RydWN0IHBhbmZyb3N0X3BlcmZjbnRfam9iX2N0eCAqYSwKPiA+ ICsJCQkJCSBzdHJ1Y3QgcGFuZnJvc3RfcGVyZmNudF9qb2JfY3R4ICpiKQo+ID4gK3sKPiA+ICsJ dW5zaWduZWQgaW50IGksIGo7Cj4gPiArCj4gPiArCWlmIChhLT5wZXJmbW9uX2NvdW50ICE9IGIt PnBlcmZtb25fY291bnQpCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiArCj4gPiArCWZvciAoaSA9 IDA7IGkgPCBhLT5wZXJmbW9uX2NvdW50OyBpKyspIHsKPiA+ICsJCWZvciAoaiA9IDA7IGogPCBi LT5wZXJmbW9uX2NvdW50OyBqKyspIHsKPiA+ICsJCQlpZiAoYS0+cGVyZm1vbnNbaV0gPT0gYi0+ cGVyZm1vbnNbal0pCj4gPiArCQkJCWJyZWFrOwo+ID4gKwkJfQo+ID4gKwo+ID4gKwkJaWYgKGog PT0gYi0+cGVyZm1vbl9jb3VudCkKPiA+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gPiArCX0KPiA+ICsg IAo+IAo+IFdvdWxkIHVzaW5nIG1lbWNtcCgpIGJlIGNsZWFuZXIgaGVyZT8KCm1lbWNtcCgpIGRv ZXMgbm90IGFjY291bnQgZm9yIHRoZSBjYXNlIHdoZXJlIDIgam9icyBjb250YWluIGV4YWN0bHkg dGhlCnNhbWUgcGVyZm1vbnMgYnV0IGluIGEgZGlmZmVyZW50IG9yZGVyLiBUaGlzIGJlaW5nIHNh aWQsIGl0J3MgcmF0aGVyCnVubGlrZWx5IHRvIGhhcHBlbiwgc28gbWF5YmUgd2UgY2FuIGFjY2Vw dCB0aGUgcGVyZiBwZW5hbHR5IGZvciB0aGF0CmNhc2UuCgo+IAo+ID4gKwlpZiAocGFuZnJvc3Rf bW9kZWxfY21wKHBmZGV2LCAweDEwMDApID49IDApICAKPiAKPiBXaGF0IGRvZXMgMHgxMDAwIHJl ZmVyIHRvIGhlcmU/IEknbSBhc3N1bWluZyBtYXliZSBCaWZyb3N0LCBidXQgaXQncyBub3QKPiBv YnZpb3VzLi4uIHByb2JhYmx5IGJldHRlciB0byBoYXZlIGEgI2RlZmluZSBzb21ld2hlcmUgYW5k IHVzZSB0aGF0IChvcgo+IGFuIGVudW0gZXF1aXZhbGVudGx5KS4KClllcywgYWxsIG51bWJlcnMg YWJvdmUgMHhmZmYgYXJlIGJpZnJvc3QgR1BVcy4gSSdsbCBhZGQgYSBtYWNyby4KCj4gCj4gPiAr CS8qCj4gPiArCSAqIER1ZSB0byBQUkxBTS04MTg2IHdlIG5lZWQgdG8gZGlzYWJsZSB0aGUgVGls ZXIgYmVmb3JlIHdlIGVuYWJsZSBIVwo+ID4gKwkgKiBjb3VudGVycy4KPiA+ICsJICovICAKPiAK PiBXaGF0IG9uIGVhcnRoIGlzIFBSTEFNLTgxODY/IDopCj4gCj4gQWN0dWFsbHksIHdhaXQsIEkg Y2FuIGFuc3dlciB0aGF0IC0tIG9sZCBrYmFzZSB2ZXJzaW9ucyBoYWQgYW4gZXJyYXRhCj4gbGlz dDoKPiAKPiAgICAgICAgIC8qIFdyaXRlIG9mIFBSRkNOVF9DT05GSUdfTU9ERV9NQU5VQUwgdG8g UFJGQ05UX0NPTkZJRyBjYXVzZXMgYSBpbnN0cnVtZW50YXRpb24gZHVtcCBpZgo+ICAgICAgICAg ICAgUFJGQ05UX1RJTEVSX0VOIGlzIGVuYWJsZWQgKi8KPiAgICAgICAgIEJBU0VfSFdfSVNTVUVf ODE4NiwKPiAKPiBTbyB0aGF0J3Mgd2h5LiBJZiBwZW9wbGUgd2FudCwgSSdtIGNvbnNpZGVyaW5n IG1vdmluZyB0aGVzZSBlcnJhdGEKPiBkZXNjcmlwdGlvbnMgYmFjayBpbnRvIHRoZSBrZXJuZWwg d2hlcmUgcG9zc2libGUsIHNpbmNlIG90aGVyd2lzZSBjb2RlCj4gbGlrZSB0aGlzIGlzIG9wYXF1 ZS4KCldpbGwgY29weSB0aGUgZXJyYXRhLgoKPiAKPiA+ICsJCXVuc2lnbmVkIGludCBubDJjLCBu Y29yZXM7Cj4gPiArCj4gPiArCQkvKgo+ID4gKwkJICogVE9ETzogZGVmaW5lIGEgbWFjcm8gdG8g ZXh0cmFjdCB0aGUgbnVtYmVyIG9mIGwyIGNhY2hlcyBmcm9tCj4gPiArCQkgKiBtZW1fZmVhdHVy ZXMuCj4gPiArCQkgKi8KPiA+ICsJCW5sMmMgPSAoKHBmZGV2LT5mZWF0dXJlcy5tZW1fZmVhdHVy ZXMgPj4gOCkgJiBHRU5NQVNLKDMsIDApKSArIDE7Cj4gPiArCj4gPiArCQkvKgo+ID4gKwkJICog VGhlIEFSTSBkcml2ZXIgaXMgZ3JvdXBpbmcgY29yZXMgcGVyIGNvcmUgZ3JvdXAgYW5kIHRoZW4K PiA+ICsJCSAqIG9ubHkgdXNpbmcgdGhlIG51bWJlciBvZiBjb3JlcyBpbiBncm91cCAwIHRvIGNh bGN1bGF0ZSB0aGUKPiA+ICsJCSAqIHNpemUuIE5vdCBzdXJlIHdoeSB0aGlzIGlzIGRvbmUgbGlr ZSB0aGF0LCBidXQgSSBndWVzcwo+ID4gKwkJICogc2hhZGVyX3ByZXNlbnQgd2lsbCBvbmx5IHNo b3cgY29yZXMgaW4gdGhlIGZpcnN0IGdyb3VwCj4gPiArCQkgKiBhbnl3YXkuCj4gPiArCQkgKi8K PiA+ICsJCW5jb3JlcyA9IGh3ZWlnaHQ2NChwZmRldi0+ZmVhdHVyZXMuc2hhZGVyX3ByZXNlbnQp Owo+ID4gKyAgCj4gCj4gRGVqYSB2dS4gV2FzIHRoaXMgY29weXBhc3RlIGRtYXliZT8KCkFjdHVh bGx5LCB0aGF0IG9uZSBpcyBmcm9tIG1lLCBoZW5jZSB0aGUgJ25vdCBzdXJlIHdoeScgcGFydCA6 KS4KCj4gCj4gPiArCQkgIChwYW5mcm9zdF9tb2RlbF9jbXAocGZkZXYsIDB4MTAwMCkgPj0gMCA/ ICAKPiAKPiBUSGVyZSdzIHRoYXQgcGVza3kgMHgxMDAwIGFnYWluLgo+IAo+ID4gQEAgLTU1LDYg KzYzLDE1IEBAIHN0cnVjdCBkcm1fcGFuZnJvc3Rfc3VibWl0IHsKPiA+ICAKPiA+ICAJLyoqIEEg Y29tYmluYXRpb24gb2YgUEFORlJPU1RfSkRfUkVRXyogKi8KPiA+ICAJX191MzIgcmVxdWlyZW1l bnRzOwo+ID4gKwo+ID4gKwkvKiogUG9pbnRlciB0byBhIHUzMiBhcnJheSBvZiBwZXJmbW9ucyB0 aGF0IHNob3VsZCBiZSBhdHRhY2hlZCB0byB0aGUgam9iLiAqLwo+ID4gKwlfX3U2NCBwZXJmbW9u X2hhbmRsZXM7Cj4gPiArCj4gPiArCS8qKiBOdW1iZXIgb2YgcGVyZm1vbiBoYW5kbGVzIHBhc3Nl ZCBpbiAoc2l6ZSBpcyB0aGF0IHRpbWVzIDQpLiAqLwo+ID4gKwlfX3UzMiBwZXJmbW9uX2hhbmRs ZV9jb3VudDsKPiA+ICsKPiA+ICsJLyoqIFVudXNlZCBmaWVsZCwgc2hvdWxkIGJlIHNldCB0byAw LiAqLwo+ID4gKwlfX3UzMiBwYWRkaW5nOyAgCj4gCj4gQmxlZXAgYmxvcnAuIElmIHdlJ3JlIG1v ZGlmeWluZyBfc3VibWl0LCB3ZSdsbCBuZWVkIHRvIGJlIHN3aWZ0IGFib3V0Cj4gbWVyZ2luZyB0 aGlzIGFoZWFkIG9mIHRoZSBtYWluIGNvZGUgdG8gbWFrZSBzdXJlIHdlIGRvbid0IGJyZWFrIHRo ZQo+IFVBQkkuIEFsdGhvdWdoIEkgZ3Vlc3MgaWYgd2UncmUganVzdCBhZGRpbmcgZmllbGRzIGF0 IHRoZSBlbmQsIHRoYXQncyBhCj4gbm9uaXNzdWUuCgpPdGhlcnMgYXJlIHVzaW5nIHRoZSBzYW1l ICJpZiBkYXRhIHBhc3NlZCBpcyBzbWFsbGVyIHRoYW4gZXhwZWN0ZWQKc2l6ZSwgdW5hc3NpZ25l ZCBmaWVsZHMgYXJlIHplcm9lZCIuIFRoYXQgYWxsb3dzIHVzIHRvIGV4dGVuZCBhIHN0cnVjdAp3 aXRob3V0IGJyZWFraW5nIHRoZSBBQkkgYXMgbG9uZyBhcyB6ZXJvIGlzIGEgdmFsaWQgdmFsdWUg YW5kIGRvZXMgbm90CmNoYW5nZSB0aGUgYmVoYXZpb3IgY29tcGFyZWQgdG8gd2hlbiB0aGUgZmll bGQgd2FzIG5vdCBwcmVzZW50LgoKVGhpcyBpcyB0aGUgY2FzZSBoZXJlOiBwZXJmbW9uX2hhbmRs ZV9jb3VudCA9IDAgbWVhbnMgbm8gcGVyZm1vbgphdHRhY2hlZCB0byB0aGUgam9iLCBzbyB0aGUg ZHJpdmVyIGlzIGFjdGluZyBsaWtlIGl0IHByZXZpb3VzbHkgd2FzLgoKTm8gbmVlZCB0byBnZXQg dGhhdCBwYXJ0IG1lcmdlZCBpbiB0aGUgaW5pdGlhbCBwYXRjaCBzZXJpZXMgSU1PLgoKPiAKPiA+ ICtzdHJ1Y3QgZHJtX3BhbmZyb3N0X2Jsb2NrX3BlcmZjb3VudGVycyB7Cj4gPiArCS8qCj4gPiAr CSAqIEZvciBEUk1fSU9DVExfUEFORlJPU1RfR0VUX1BFUkZDTlRfTEFZT1VULCBlbmNvZGVzIHRo ZSBhdmFpbGFibGUKPiA+ICsJICogaW5zdGFuY2VzIGZvciBhIHNwZWNpZmljIGdpdmVuIGJsb2Nr IHR5cGUuCj4gPiArCSAqIEZvciBEUk1fSU9DVExfUEFORlJPU1RfQ1JFQVRFX1BFUkZNT04sIGVu Y29kZXMgdGhlIGluc3RhbmNlcyB0aGUKPiA+ICsJICogdXNlciB3YW50cyB0byBtb25pdG9yLgo+ ID4gKwkgKiBOb3RlOiB0aGUgYml0bWFwIG1pZ2h0IGJlIHNwYXJzZS4KPiA+ICsJICovCj4gPiAr CV9fdTY0IGluc3RhbmNlczsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogRm9yIERSTV9JT0NUTF9Q QU5GUk9TVF9HRVRfUEVSRkNOVF9MQVlPVVQsIGVuY29kZXMgdGhlIGF2YWlsYWJsZQo+ID4gKwkg KiBjb3VudGVycyBhdHRhY2hlZCB0byBhIHNwZWNpZmljIGJsb2NrIHR5cGUuCj4gPiArCSAqIEZv ciBEUk1fSU9DVExfUEFORlJPU1RfQ1JFQVRFX1BFUkZNT04sIGVuY29kZXMgdGhlIGNvdW50ZXJz IHRoZSB1c2VyCj4gPiArCSAqIHdhbnRzIHRvIG1vbml0b3IuCj4gPiArCSAqIE5vdGU6IHRoZSBi aXRtYXAgbWlnaHQgYmUgc3BhcnNlLgo+ID4gKwkgKi8KPiA+ICsJX191NjQgY291bnRlcnM7Cj4g PiArfTsgIAo+IAo+IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGlzLiBBcmVuJ3QgdGhlcmUgbW9yZSB0 aGFuIDY0IGNvdW50ZXJzPwo+IAo+ID4gK3N0cnVjdCBkcm1fcGFuZnJvc3RfZ2V0X3BlcmZjbnRf bGF5b3V0IHsKPiA+ICsJc3RydWN0IGRybV9wYW5mcm9zdF9ibG9ja19wZXJmY291bnRlcnMgY291 bnRlcnNbUEFORlJPU1RfTlVNX0JMT0NLU107Cj4gPiArfTsgIAo+IAo+IC0tT2guIEl0J3MgcGVy LWJsb2NrLiBHb3QgaXQuCj4gCj4gPiArICogVXNlZCB0byBjcmVhdGUgYSBwZXJmb3JtYW5jZSBt b25pdG9yLiBFYWNoIHBlcmZtb25hbmNlIG1vbml0b3IgaXMgYXNzaWduZWQgYW4gIAo+IAo+IFR5 cG8uCgpXaWxsIGZpeC4KCj4gCj4gLS0tCj4gCj4gT3ZlcmFsbCwgdGhpcyBsb29rcyByZWFsbHkg Z3JlYXQhIFRoYW5rIHlvdSEgOikKClRoYW5rcyBhIGxvdCBmb3IgeW91ciByZXZpZXdzLiBUaGF0 IHdhcyBwcmV0dHkgZGFtbiBmYXN0IQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw=