dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: megous via linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Maxime Ripard
	<maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Ondrej Jirman <megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>,
	Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>,
	Jose Abreu <joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Maxime Coquelin
	<mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Arend van Spriel
	<arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Franky Lin <franky.lin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Hante Meuleman
	<hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Chi-Hsien Lin
	<chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
	Wright Feng <wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
	Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Naveen Gupta
	<naveen.gupta-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, brcm802
Subject: [PATCH 09/12] pinctrl: sunxi: Prepare for alternative bias voltage setting methods
Date: Sat,  6 Apr 2019 01:45:11 +0200	[thread overview]
Message-ID: <20190405234514.6183-10-megous@megous.com> (raw)
In-Reply-To: <20190405234514.6183-1-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>

From: Ondrej Jirman <megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>

H6 has a different I/O voltage bias setting method than A80. Prepare
existing code for using alternative bias voltage setting methods.

Signed-off-by: Ondrej Jirman <megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
---
 drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c |  2 +-
 drivers/pinctrl/sunxi/pinctrl-sunxi.c     | 38 ++++++++++++-----------
 drivers/pinctrl/sunxi/pinctrl-sunxi.h     |  4 ++-
 3 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c b/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c
index da37d594a13d..3aa210079b18 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c
@@ -722,7 +722,7 @@ static const struct sunxi_pinctrl_desc sun9i_a80_pinctrl_data = {
 	.npins = ARRAY_SIZE(sun9i_a80_pins),
 	.irq_banks = 5,
 	.disable_strict_mode = true,
-	.has_io_bias_cfg = true,
+	.io_bias_cfg_variant = IO_BIAS_CFG_V1,
 };
 
 static int sun9i_a80_pinctrl_probe(struct platform_device *pdev)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 8dd25caea2cf..9f329fec77cf 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -610,7 +610,7 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl,
 	u32 val, reg;
 	int uV;
 
-	if (!pctl->desc->has_io_bias_cfg)
+	if (!pctl->desc->io_bias_cfg_variant)
 		return 0;
 
 	uV = regulator_get_voltage(supply);
@@ -621,23 +621,25 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl,
 	if (uV == 0)
 		return 0;
 
-	/* Configured value must be equal or greater to actual voltage */
-	if (uV <= 1800000)
-		val = 0x0; /* 1.8V */
-	else if (uV <= 2500000)
-		val = 0x6; /* 2.5V */
-	else if (uV <= 2800000)
-		val = 0x9; /* 2.8V */
-	else if (uV <= 3000000)
-		val = 0xA; /* 3.0V */
-	else
-		val = 0xD; /* 3.3V */
-
-	pin -= pctl->desc->pin_base;
-
-	reg = readl(pctl->membase + sunxi_grp_config_reg(pin));
-	reg &= ~IO_BIAS_MASK;
-	writel(reg | val, pctl->membase + sunxi_grp_config_reg(pin));
+	if (pctl->desc->io_bias_cfg_variant == IO_BIAS_CFG_V1) {
+		/* Configured value must be equal or greater to actual voltage */
+		if (uV <= 1800000)
+			val = 0x0; /* 1.8V */
+		else if (uV <= 2500000)
+			val = 0x6; /* 2.5V */
+		else if (uV <= 2800000)
+			val = 0x9; /* 2.8V */
+		else if (uV <= 3000000)
+			val = 0xA; /* 3.0V */
+		else
+			val = 0xD; /* 3.3V */
+
+		pin -= pctl->desc->pin_base;
+
+		reg = readl(pctl->membase + sunxi_grp_config_reg(pin));
+		reg &= ~IO_BIAS_MASK;
+		writel(reg | val, pctl->membase + sunxi_grp_config_reg(pin));
+	}
 
 	return 0;
 }
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h
index ee15ab067b5f..476772f91dba 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h
@@ -95,6 +95,8 @@
 #define PINCTRL_SUN7I_A20	BIT(7)
 #define PINCTRL_SUN8I_R40	BIT(8)
 
+#define IO_BIAS_CFG_V1		1
+
 struct sunxi_desc_function {
 	unsigned long	variant;
 	const char	*name;
@@ -117,7 +119,7 @@ struct sunxi_pinctrl_desc {
 	const unsigned int		*irq_bank_map;
 	bool				irq_read_needs_mux;
 	bool				disable_strict_mode;
-	bool				has_io_bias_cfg;
+	int				io_bias_cfg_variant;
 };
 
 struct sunxi_pinctrl_function {
-- 
2.21.0

  parent reply	other threads:[~2019-04-05 23:45 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 23:45 [PATCH 00/12] Add support for Orange Pi 3 megous via linux-sunxi
     [not found] ` <20190405234514.6183-1-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-05 23:45   ` [PATCH 01/12] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS megous via linux-sunxi
     [not found]     ` <20190405234514.6183-2-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  7:46       ` Maxime Ripard
2019-04-08 22:58         ` 'Ondřej Jirman' via linux-sunxi
     [not found]           ` <20190408225851.svelyf7h3fiw4wjw-9v8tmBix7cb9zxVx7UNMDg@public.gmane.org>
2019-04-09  7:22             ` Maxime Ripard
2019-04-05 23:45   ` [PATCH 02/12] drm: sun4i: Add support for enabling DDC I2C bus to dw_hdmi glue megous via linux-sunxi
     [not found]     ` <20190405234514.6183-3-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  7:23       ` Maxime Ripard
2019-04-08  7:28         ` [linux-sunxi] " Chen-Yu Tsai
     [not found]           ` <CAGb2v65W_H5HrnY9+DuW-noshXLHgErJhEpHHhzcG15n1u=8iw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-08  8:47             ` Maxime Ripard
2019-04-08 12:17               ` 'Ondřej Jirman' via linux-sunxi
     [not found]                 ` <20190408121727.4vdqdokr6w5thck6-9v8tmBix7cb9zxVx7UNMDg@public.gmane.org>
2019-04-09  7:45                   ` Maxime Ripard
2019-04-05 23:45   ` [PATCH 03/12] dt-bindings: display: sun4i-drm: Add DDC power supply megous via linux-sunxi
2019-04-05 23:45   ` [PATCH 04/12] arm64: dts: allwinner: orange-pi-3: Enable HDMI output megous via linux-sunxi
     [not found]     ` <20190405234514.6183-5-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  7:24       ` Maxime Ripard
2019-04-05 23:45   ` [PATCH 05/12] net: stmmac: sun8i: add support for Allwinner H6 EMAC megous via linux-sunxi
     [not found]     ` <20190405234514.6183-6-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  7:25       ` Maxime Ripard
2019-04-05 23:45   ` [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one megous via linux-sunxi
2019-04-06 10:24     ` Sergei Shtylyov
2019-04-05 23:45   ` [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet megous via linux-sunxi
     [not found]     ` <20190405234514.6183-8-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  6:11       ` Jagan Teki
     [not found]         ` <CAMty3ZCo53qHW4e+p=toWxLPrUua6XtaZX0YBuPfmDuW1V+e0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-08 22:26           ` 'Ondřej Jirman' via linux-sunxi
2019-04-08  7:40       ` Maxime Ripard
2019-04-08 23:22         ` 'Ondřej Jirman' via linux-sunxi
     [not found]           ` <20190408232232.fsl2ddthwo2rr4ql-9v8tmBix7cb9zxVx7UNMDg@public.gmane.org>
2019-04-09  7:23             ` Maxime Ripard
2019-04-09  7:35           ` Linus Walleij
2019-04-09  7:35           ` Linus Walleij
2019-04-05 23:45   ` [PATCH 08/12] arm64: dts: allwinner: h6: Add MMC1 pins megous via linux-sunxi
     [not found]     ` <20190405234514.6183-9-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  7:43       ` Maxime Ripard
2019-04-08 22:41         ` 'Ondřej Jirman' via linux-sunxi
     [not found]           ` <20190408224104.qwhk33qgem7bq5y7-9v8tmBix7cb9zxVx7UNMDg@public.gmane.org>
2019-04-09  7:20             ` Maxime Ripard
2019-04-05 23:45   ` megous via linux-sunxi [this message]
2019-04-08 12:53     ` [PATCH 09/12] pinctrl: sunxi: Prepare for alternative bias voltage setting methods Linus Walleij
2019-04-08 13:08       ` Ondřej Jirman
2019-04-05 23:45   ` [PATCH 10/12] pinctrl: sunxi: Support I/O bias voltage setting on H6 megous via linux-sunxi
     [not found]     ` <20190405234514.6183-11-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-08  1:31       ` 'Ondřej Jirman' via linux-sunxi
2019-04-08  7:42       ` Maxime Ripard
2019-04-05 23:45   ` [PATCH 11/12] brcmfmac: Loading the correct firmware for brcm43456 megous via linux-sunxi
2019-04-13 11:06     ` Kalle Valo
2019-04-13 11:06     ` Kalle Valo
     [not found]     ` <20190405234514.6183-12-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-13 11:06       ` Kalle Valo
2019-04-13 11:06     ` Kalle Valo
2019-04-05 23:45   ` [PATCH 12/12] arm64: dts: allwinner: orange-pi-3: Enable WiFi megous via linux-sunxi
     [not found]     ` <20190405234514.6183-13-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org>
2019-04-07 15:31       ` Clément Péron
2019-04-07 16:15         ` [linux-sunxi] " Ondřej Jirman
2019-04-07 13:36   ` [PATCH 00/12] Add support for Orange Pi 3 Clément Péron
     [not found]     ` <CAJiuCcew10Q3PUOk4VPoiyFc7ZhXwJzxXHQHNeVBUvVAQ3BkbQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-07 14:32       ` 'Ondřej Jirman' via linux-sunxi
     [not found]         ` <20190407143237.2qyoef4r5e3qvbmh-9v8tmBix7cb9zxVx7UNMDg@public.gmane.org>
2019-04-07 15:08           ` Clément Péron
2019-04-08  6:01         ` [linux-sunxi] " Jagan Teki
2019-04-08  6:01         ` Jagan Teki
     [not found]         ` <CAMty3ZDpppM5zBvxCBx3NjdVsRm4S93yz5kqi5Z5a0rhC-+zPg@mail.gmail.com>
     [not found]           ` <CAMty3ZDpppM5zBvxCBx3NjdVsRm4S93yz5kqi5Z5a0rhC-+zPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-08 12:46             ` 'Ondřej Jirman' via linux-sunxi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405234514.6183-10-megous@megous.com \
    --to=linux-sunxi-/jypxa39uh5tlh3mbocffw@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=alexandre.torgue-qxv4g6HH51o@public.gmane.org \
    --cc=arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=franky.lin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
    --cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org \
    --cc=naveen.gupta-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peppe.cavallaro-qxv4g6HH51o@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    --cc=wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox