From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 2/2] drm/prime: split drm_gem_prime_handle_to_fd() Date: Thu, 25 Apr 2019 19:15:34 +0200 Message-ID: <20190425171534.GB7051@ravnborg.org> References: <20190425155114.533-1-emil.l.velikov@gmail.com> <20190425155114.533-2-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190425155114.533-2-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgRW1pbC4KClRoYW5zLCBhZ2FpbiBhIG5pY2Ugc2ltcGxpZmljYXRpb24uCkJ1dCB0aGUgZXhw b3J0X2hhbmRsZV90b19idWYgbm93IGhhdmUgdG8gbXV0ZXhfdW5sb2NrLgpQbGVhc2UgdXNlIHBy b3BlciBnb3RvIGVycm9yIGhhbmRsaWduIHdpdGggYSBzaW5nbGUKdW5sb2NrIGluIHRoZSBlbmQg b2YgdGhlIGZ1Y3Rpb24uClRoaXMgbWFrZXMgaXQgc2ltcGxlIHRvIGNoZWNrIHRoYXQgd2UgYWx3 YXlzIGRvIHRoZSB1bmxvY2suCkxpa2V3aXNlIGluIG5leHQgZnVuY3Rpb24uIEF2b2lkIHR3byBt dXRleF91bmxvY2ssIHdlIHByZWZlciBnb3RvIGVycm9yCmhhbmRsaW5nLgoKCVNhbQoKT24gVGh1 LCBBcHIgMjUsIDIwMTkgYXQgMDQ6NTE6MTRQTSArMDEwMCwgRW1pbCBWZWxpa292IHdyb3RlOgo+ IEZyb206IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gCj4gQ3Vy cmVudGx5IGRybV9nZW1fcHJpbWVfaGFuZGxlX3RvX2ZkKCkgY29uc2lzdHMgb2YgaWxsZWdpYmxl IGFtb3VudCBvZgo+IGdvdG8gbGFiZWxzLCBmb3Igbm8gb2J2aW91cyByZWFzb24uCj4gCj4gU3Bs aXQgaXQgaW4gdHdvIChhcyBiZWxvdykgbWFraW5nIHRoZSBjb2RlIGZhciBzaW1wbGVyIGFuZCBv YnZpb3VzLgo+IAo+IGRybV9nZW1fcHJpbWVfaGFuZGxlX3RvX2ZkKCkKPiAgLSBwcmltZSBtdHgg aGFuZGxpbmcKPiAgLSBkcm1fZ2VtX29iamVjdCBsb29rdXAgYW5kIHJlZmNvdW50aW5nCj4gIC0g Y3JlYXRpbmcgYW4gZmQgZm9yIHRoZSBkbWFidWYKPiAgLSBoYXNoIHRhYmxlIGxvb2t1cAo+IAo+ IGV4cG9ydF9oYW5kbGVfdG9fYnVmKCkKPiAgLSBkcm1fZ2VtX29iamVjdCBleHBvcnQgYW5kIGxv Y2tpbmcKPiAgLSBhZGRpbmcgdGhlIGhhbmRsZS9mZCB0byB0aGUgaGFzaCB0YWJsZQo+IAo+IENj OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1ieTogRW1pbCBW ZWxpa292IDxlbWlsLnZlbGlrb3ZAY29sbGFib3JhLmNvbT4KPiAtLS0KPiBDdXJyZW50bHkgd2Ug ZG1hX2J1Zl9wdXQoKSBbaW4gdGhlIGVycm9yIHBhdGhdIGV2ZW4gZm9yIHJlLWV4cG9ydCBvZgo+ IG9yaWdpbmFsIGltcG9ydGVkIG9iamVjdCBhbmQgInNlbGYtZXhwb3J0IiAtIGFrYQo+IG9iai0+ aW1wb3J0X2F0dGFjaC0+ZG1hYnVmIGFuZCBvYmotPmRtYWJ1Zi4KPiAKPiBIYXZlIG5vdCBsb29r ZWQgYXQgaXQgdG9vIGNsb3NlbHksIGJ1dCBndXQgc3VnZ2VzdHMgdGhhdCBtYXkgYmUgb2ZmLgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMgfCAxMDYgKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1NyBpbnNlcnRpb25zKCsp LCA0OSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9w cmltZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gaW5kZXggMGQ4M2I5YmJmNzkz Li4yYjBiNmU3YTZhNDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gQEAgLTU0NSwxMSArNTQ1LDU0 IEBAIHN0YXRpYyBzdHJ1Y3QgZG1hX2J1ZiAqZXhwb3J0X2FuZF9yZWdpc3Rlcl9vYmplY3Qoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCSAqIHdpbGwgY2xlYW4gaXQgdXAuCj4gIAkgKi8KPiAg CW9iai0+ZG1hX2J1ZiA9IGRtYWJ1ZjsKPiAtCWdldF9kbWFfYnVmKG9iai0+ZG1hX2J1Zik7Cj4g IAo+ICAJcmV0dXJuIGRtYWJ1ZjsKPiAgfQo+ICAKPiArc3RhdGljIHN0cnVjdCBkbWFfYnVmICpl eHBvcnRfaGFuZGxlX3RvX2J1ZihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICsJCQkJCSAgICBz dHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPiArCQkJCQkgICAgc3RydWN0IGRybV9nZW1fb2Jq ZWN0ICpvYmosCj4gKwkJCQkJICAgIHVpbnQzMl90IGhhbmRsZSwKPiArCQkJCQkgICAgdWludDMy X3QgZmxhZ3MpCj4gK3sKPiArCXN0cnVjdCBkbWFfYnVmICpkbWFidWYgPSBOVUxMOwo+ICsJaW50 IHJldDsKPiArCj4gKwltdXRleF9sb2NrKCZkZXYtPm9iamVjdF9uYW1lX2xvY2spOwo+ICsJLyog cmUtZXhwb3J0IHRoZSBvcmlnaW5hbCBpbXBvcnRlZCBvYmplY3QgKi8KPiArCWlmIChvYmotPmlt cG9ydF9hdHRhY2gpCj4gKwkJZG1hYnVmID0gb2JqLT5pbXBvcnRfYXR0YWNoLT5kbWFidWY7Cj4g Kwo+ICsJaWYgKCFkbWFidWYpCj4gKwkJZG1hYnVmID0gb2JqLT5kbWFfYnVmOwo+ICsKPiArCWlm ICghZG1hYnVmKQo+ICsJCWRtYWJ1ZiA9IGV4cG9ydF9hbmRfcmVnaXN0ZXJfb2JqZWN0KGRldiwg b2JqLCBmbGFncyk7Cj4gKwo+ICsJaWYgKElTX0VSUihkbWFidWYpKSB7Cj4gKwkJLyogbm9ybWFs bHkgdGhlIGNyZWF0ZWQgZG1hLWJ1ZiB0YWtlcyBvd25lcnNoaXAgb2YgdGhlIHJlZiwKPiArCQkg KiBidXQgaWYgdGhhdCBmYWlscyB0aGVuIGRyb3AgdGhlIHJlZgo+ICsJCSAqLwo+ICsJCW11dGV4 X3VubG9jaygmZGV2LT5vYmplY3RfbmFtZV9sb2NrKTsKT25lIG11dGV4X3VubG9jawo+ICsJCXJl dHVybiBkbWFidWY7Cj4gKwl9Cj4gKwo+ICsJZ2V0X2RtYV9idWYoZG1hYnVmKTsKPiArCj4gKwkv Kgo+ICsJICogSWYgd2UndmUgZXhwb3J0ZWQgdGhpcyBidWZmZXIgdGhlbiBjaGVhdCBhbmQgYWRk IGl0IHRvIHRoZSBpbXBvcnQgbGlzdAo+ICsJICogc28gd2UgZ2V0IHRoZSBjb3JyZWN0IGhhbmRs ZSBiYWNrLiBXZSBtdXN0IGRvIHRoaXMgdW5kZXIgdGhlCj4gKwkgKiBwcm90ZWN0aW9uIG9mIGRl di0+b2JqZWN0X25hbWVfbG9jayB0byBlbnN1cmUgdGhhdCBhIHJhY2luZyBnZW0gY2xvc2UKPiAr CSAqIGlvY3RsIGRvZXNuJ3QgbWlzcyB0byByZW1vdmUgdGhpcyBidWZmZXIgaGFuZGxlIGZyb20g dGhlIGNhY2hlLgo+ICsJICovCj4gKwlyZXQgPSBkcm1fcHJpbWVfYWRkX2J1Zl9oYW5kbGUoJmZp bGVfcHJpdi0+cHJpbWUsIGRtYWJ1ZiwgaGFuZGxlKTsKPiArCW11dGV4X3VubG9jaygmZGV2LT5v YmplY3RfbmFtZV9sb2NrKTsKU2Vjb25kIG11dGV4X3VubG9jawoKPiArCWlmIChyZXQpIHsKPiAr CQlkbWFfYnVmX3B1dChkbWFidWYpOwo+ICsJCWRtYWJ1ZiA9IEVSUl9QVFIocmV0KTsKPiArCX0K VGhpcyBlcnJvciBoYW5kbGluZyBsb29rcyBhIGxpdHRsZSBvZmYuIEl0IGFzc3VtZSBpdCB3b3Jr cyBjb3JyZWN0LCBidXQKcGxlYXNlIHRyeSB0byBtYWtlIGl0IG1vcmUgb2J2aW91cy4KPiArCXJl dHVybiBkbWFidWY7Cj4gK30KPiAgLyoqCj4gICAqIGRybV9nZW1fcHJpbWVfaGFuZGxlX3RvX2Zk IC0gUFJJTUUgZXhwb3J0IGZ1bmN0aW9uIGZvciBHRU0gZHJpdmVycwo+ICAgKiBAZGV2OiBkZXYg dG8gZXhwb3J0IHRoZSBidWZmZXIgZnJvbQo+IEBAIC01NjksNyArNjEyLDcgQEAgaW50IGRybV9n ZW1fcHJpbWVfaGFuZGxlX3RvX2ZkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCSAgICAg ICBpbnQgKnByaW1lX2ZkKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iajsKPiAt CWludCByZXQgPSAwOwo+ICsJaW50IHJldDsKPiAgCXN0cnVjdCBkbWFfYnVmICpkbWFidWY7Cj4g IAo+ICAJbXV0ZXhfbG9jaygmZmlsZV9wcml2LT5wcmltZS5sb2NrKTsKSEVyZSB3ZSBoYXZlIHRo ZSBtdXRleF9sb2NrCj4gQEAgLTU4MCw0OSArNjIzLDE0IEBAIGludCBkcm1fZ2VtX3ByaW1lX2hh bmRsZV90b19mZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJfQo+ICAKPiAgCWRtYWJ1ZiA9 IGRybV9wcmltZV9sb29rdXBfYnVmX2J5X2hhbmRsZSgmZmlsZV9wcml2LT5wcmltZSwgaGFuZGxl KTsKPiAtCWlmIChkbWFidWYpIHsKPiAtCQlnZXRfZG1hX2J1ZihkbWFidWYpOwo+IC0JCWdvdG8g b3V0X2hhdmVfaGFuZGxlOwo+IC0JfQo+ICsJaWYgKCFkbWFidWYpCj4gKwkJZG1hYnVmID0gZXhw b3J0X2hhbmRsZV90b19idWYoZGV2LCBmaWxlX3ByaXYsIG9iaiwgaGFuZGxlLCBmbGFncyk7Cj4g IAo+IC0JbXV0ZXhfbG9jaygmZGV2LT5vYmplY3RfbmFtZV9sb2NrKTsKPiAtCS8qIHJlLWV4cG9y dCB0aGUgb3JpZ2luYWwgaW1wb3J0ZWQgb2JqZWN0ICovCj4gLQlpZiAob2JqLT5pbXBvcnRfYXR0 YWNoKSB7Cj4gLQkJZG1hYnVmID0gb2JqLT5pbXBvcnRfYXR0YWNoLT5kbWFidWY7Cj4gLQkJZ2V0 X2RtYV9idWYoZG1hYnVmKTsKPiAtCQlnb3RvIG91dF9oYXZlX29iajsKPiAtCX0KPiAtCj4gLQlp ZiAob2JqLT5kbWFfYnVmKSB7Cj4gLQkJZ2V0X2RtYV9idWYob2JqLT5kbWFfYnVmKTsKPiAtCQlk bWFidWYgPSBvYmotPmRtYV9idWY7Cj4gLQkJZ290byBvdXRfaGF2ZV9vYmo7Cj4gLQl9Cj4gLQo+ IC0JZG1hYnVmID0gZXhwb3J0X2FuZF9yZWdpc3Rlcl9vYmplY3QoZGV2LCBvYmosIGZsYWdzKTsK PiAgCWlmIChJU19FUlIoZG1hYnVmKSkgewo+IC0JCS8qIG5vcm1hbGx5IHRoZSBjcmVhdGVkIGRt YS1idWYgdGFrZXMgb3duZXJzaGlwIG9mIHRoZSByZWYsCj4gLQkJICogYnV0IGlmIHRoYXQgZmFp bHMgdGhlbiBkcm9wIHRoZSByZWYKPiAtCQkgKi8KPiAgCQlyZXQgPSBQVFJfRVJSKGRtYWJ1Zik7 Cj4gLQkJbXV0ZXhfdW5sb2NrKCZkZXYtPm9iamVjdF9uYW1lX2xvY2spOwo+IC0JCWdvdG8gb3V0 Owo+ICsJCWdvdG8gb3V0X29iamVjdF9wdXQ7CkhFcmUgeW91IG1vdmUgbXV0ZXhfdW5sb2NrIGRv d24gLSB0aGlzIGlzIGdvb2QhCj4gIAl9Cj4gIAo+IC1vdXRfaGF2ZV9vYmo6Cj4gLQkvKgo+IC0J ICogSWYgd2UndmUgZXhwb3J0ZWQgdGhpcyBidWZmZXIgdGhlbiBjaGVhdCBhbmQgYWRkIGl0IHRv IHRoZSBpbXBvcnQgbGlzdAo+IC0JICogc28gd2UgZ2V0IHRoZSBjb3JyZWN0IGhhbmRsZSBiYWNr LiBXZSBtdXN0IGRvIHRoaXMgdW5kZXIgdGhlCj4gLQkgKiBwcm90ZWN0aW9uIG9mIGRldi0+b2Jq ZWN0X25hbWVfbG9jayB0byBlbnN1cmUgdGhhdCBhIHJhY2luZyBnZW0gY2xvc2UKPiAtCSAqIGlv Y3RsIGRvZXNuJ3QgbWlzcyB0byByZW1vdmUgdGhpcyBidWZmZXIgaGFuZGxlIGZyb20gdGhlIGNh Y2hlLgo+IC0JICovCj4gLQlyZXQgPSBkcm1fcHJpbWVfYWRkX2J1Zl9oYW5kbGUoJmZpbGVfcHJp di0+cHJpbWUsCj4gLQkJCQkgICAgICAgZG1hYnVmLCBoYW5kbGUpOwo+IC0JbXV0ZXhfdW5sb2Nr KCZkZXYtPm9iamVjdF9uYW1lX2xvY2spOwo+IC0JaWYgKHJldCkKPiAtCQlnb3RvIGZhaWxfcHV0 X2RtYWJ1ZjsKPiAtCj4gLW91dF9oYXZlX2hhbmRsZToKPiAgCXJldCA9IGRtYV9idWZfZmQoZG1h YnVmLCBmbGFncyk7Cj4gIAkvKgo+ICAJICogV2UgbXVzdCBfbm90XyByZW1vdmUgdGhlIGJ1ZmZl ciBmcm9tIHRoZSBoYW5kbGUgY2FjaGUgc2luY2UgdGhlIG5ld2x5Cj4gQEAgLTYzMCwxOCArNjM4 LDE4IEBAIGludCBkcm1fZ2VtX3ByaW1lX2hhbmRsZV90b19mZChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+ICAJICogYW5kIHRoYXQgaXMgaW52YXJpYW50IGFzIGxvbmcgYXMgYSB1c2Vyc3BhY2Ug Z2VtIGhhbmRsZSBleGlzdHMuCj4gIAkgKiBDbG9zaW5nIHRoZSBoYW5kbGUgd2lsbCBjbGVhbiBv dXQgdGhlIGNhY2hlIGFueXdheSwgc28gd2UgZG9uJ3QgbGVhay4KPiAgCSAqLwo+IC0JaWYgKHJl dCA8IDApIHsKPiAtCQlnb3RvIGZhaWxfcHV0X2RtYWJ1ZjsKPiAtCX0gZWxzZSB7Cj4gLQkJKnBy aW1lX2ZkID0gcmV0Owo+IC0JCXJldCA9IDA7Cj4gLQl9Cj4gKwlpZiAocmV0IDwgMCkKPiArCQln b3RvIG91dF9kbWFidWZfcHV0Owo+ICAKPiAtCWdvdG8gb3V0Owo+ICsJKnByaW1lX2ZkID0gcmV0 Owo+ICAKPiAtZmFpbF9wdXRfZG1hYnVmOgo+ICsJZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2Vk KG9iaik7Cj4gKwltdXRleF91bmxvY2soJmZpbGVfcHJpdi0+cHJpbWUubG9jayk7CkhlcmUgaXMg b25lIG11dGV4X3VubG9jay4KCj4gKwlyZXR1cm4gMDsKPiArCj4gK291dF9kbWFidWZfcHV0Ogo+ ICAJZG1hX2J1Zl9wdXQoZG1hYnVmKTsKPiAtb3V0Ogo+ICtvdXRfb2JqZWN0X3B1dDoKPiAgCWRy bV9nZW1fb2JqZWN0X3B1dF91bmxvY2tlZChvYmopOwo+ICBvdXRfdW5sb2NrOgo+ICAJbXV0ZXhf dW5sb2NrKCZmaWxlX3ByaXYtPnByaW1lLmxvY2spOwpIZXJlIGlzIHRoZSBzZWNvbmQgbXV0ZXhf dW5sb2NrLgoKUmVkbyB0aGlzIHNvIHRoZXJlIGlzIG9ubHkgYSBzaW5nbGUgbXV0ZXhfdW5sb2Nr LgpTbyB3ZSBlbmQgdXAgd2l0aCBzb21ldGhpbmcgYmV0dGVyIHRoYW4gYmVmb3JlLgoKCVNhbQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=