From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] drm/msm/mdp5: Fix mdp5_cfg_init error return Date: Wed, 1 May 2019 09:51:15 -0700 Message-ID: <20190501165115.GH2938@tuxbook-pro> References: <20190501161437.15728-1-jeffrey.l.hugo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190501161437.15728-1-jeffrey.l.hugo@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeffrey Hugo Cc: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed 01 May 09:14 PDT 2019, Jeffrey Hugo wrote: > If mdp5_cfg_init fails because of an unknown major version, a null pointer > dereference occurs. This is because the caller of init expects error > pointers, but init returns NULL on error. Fix this by returning the > expected values on error. > > Fixes: 2e362e1772b8 (drm/msm/mdp5: introduce mdp5_cfg module) Reviewed-by: Bjorn Andersson > Signed-off-by: Jeffrey Hugo > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > index ea8f7d7daf7f..52e23780fce1 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > @@ -721,7 +721,7 @@ struct mdp5_cfg_handler *mdp5_cfg_init(struct mdp5_kms *mdp5_kms, > if (cfg_handler) > mdp5_cfg_destroy(cfg_handler); > > - return NULL; > + return ERR_PTR(ret); > } > > static struct mdp5_cfg_platform *mdp5_get_config(struct platform_device *dev) > -- > 2.17.1 >