From: Daniel Vetter <daniel@ffwll.ch>
To: James Clarke <jrtc27@jrtc27.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix drm.h uapi header for GNU/kFreeBSD
Date: Mon, 6 May 2019 10:16:21 +0200 [thread overview]
Message-ID: <20190506081621.GE17751@phenom.ffwll.local> (raw)
In-Reply-To: <C2E5BBDF-DD8B-4024-8995-8E21549385C7@jrtc27.com>
On Sat, May 04, 2019 at 09:43:14PM +0100, James Clarke wrote:
> On 15 Jan 2019, at 18:41, Eric Anholt <eric@anholt.net> wrote:
> >
> > Daniel Vetter <daniel@ffwll.ch> writes:
> >
> >> On Tue, Jan 15, 2019 at 03:04:18PM +0000, James Clarke wrote:
> >>> Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t
> >>> types, which differs from the BSDs' headers. Thus we should include
> >>> stdint.h to ensure we have all the required integer types.
> >>>
> >>> Signed-off-by: James Clarke <jrtc27@jrtc27.com>
> >>
> >> Would be good to get an ack from some other *bsd that this is still all
> >> fine. lgtm otherwise.
> >> -Daniel
> >
> > I think there was some need for inttypes.h instead of stdint like a
> > decade ago when I was working on BSDs, but that was already almost
> > irrelevant then.
>
> Hi, just following up on this; is there still the need for an ACK?
Yeah and ack without a "decades ago" qualifier would be nice.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-06 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:04 [PATCH] drm: Fix drm.h uapi header for GNU/kFreeBSD James Clarke
2019-01-15 15:17 ` Daniel Vetter
2019-01-15 18:41 ` Eric Anholt
2019-05-04 20:43 ` James Clarke
2019-05-06 8:16 ` Daniel Vetter [this message]
2019-05-06 23:10 ` James Clarke
2019-05-07 8:26 ` Daniel Vetter
2019-05-09 17:42 ` Eric Anholt
2019-05-16 16:37 ` Eric Anholt
2019-05-16 16:58 ` Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506081621.GE17751@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrtc27@jrtc27.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox