From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v4 01/11] drm: Add atomic variants of enable/disable to
 encoder helper funcs
Date: Wed, 8 May 2019 18:31:24 +0200
Message-ID: <20190508163124.GY17751@phenom.ffwll.local>
References: <20190508160920.144739-1-sean@poorly.run>
 <20190508160920.144739-2-sean@poorly.run>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com
 [IPv6:2a00:1450:4864:20::541])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7B77089690
 for <dri-devel@lists.freedesktop.org>; Wed,  8 May 2019 16:31:29 +0000 (UTC)
Received: by mail-ed1-x541.google.com with SMTP id f37so22614700edb.13
 for <dri-devel@lists.freedesktop.org>; Wed, 08 May 2019 09:31:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20190508160920.144739-2-sean@poorly.run>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Sean Paul <sean@poorly.run>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>, Sean Paul <seanpaul@chromium.org>
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBNYXkgMDgsIDIwMTkgYXQgMTI6MDk6MDZQTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl
Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IFRoaXMgcGF0
Y2ggYWRkcyBhdG9taWNfZW5hYmxlIGFuZCBhdG9taWNfZGlzYWJsZSBjYWxsYmFja3MgdG8gdGhl
Cj4gZW5jb2RlciBoZWxwZXJzLiBUaGlzIHdpbGwgYWxsb3cgZW5jb2RlcnMgdG8gbWFrZSBpbmZv
cm1lZCBkZWNpc2lvbnMgaW4KPiB0aGVpciBzdGFydC11cC9zaHV0ZG93biBiYXNlZCBvbiB0aGUg
Y29tbWl0dGVkIHN0YXRlLgo+IAo+IEFzaWRlIGZyb20gdGhlIG5ldyBob29rcywgdGhpcyBwYXRj
aCBhbHNvIGludHJvZHVjZXMgdGhlIG5ldyBzaWduYXR1cmUKPiBmb3IgLmF0b21pY18qIGZ1bmN0
aW9ucyBnb2luZyBmb3J3YXJkLiBJbnN0ZWFkIG9mIHBhc3Npbmcgb2JqZWN0IHN0YXRlCj4gKHdl
bGwsIGVuY29kZXJzIGRvbid0IGhhdmUgYXRvbWljIHN0YXRlLCBidXQgbGV0J3MgaWdub3JlIHRo
YXQpLCB3ZSBwYXNzCj4gdGhlIGVudGlyZSBhdG9taWMgc3RhdGUgc28gdGhlIGRyaXZlciBjYW4g
aW5zcGVjdCBtb3JlIHRoYW4gd2hhdCdzCj4gaGFwcGVuaW5nIGxvY2FsbHkuCj4gCj4gVGhpcyBp
cyBwYXJ0aWN1bGFybHkgaW1wb3J0YW50IGZvciB0aGUgdXBjb21pbmcgc2VsZiByZWZyZXNoIGhl
bHBlcnMuCj4gCj4gQ2hhbmdlcyBpbiB2MzoKPiAtIEFkZGVkIHBhdGNoIHRvIHRoZSBzZXQKPiBD
aGFuZ2VzIGluIHY0Ogo+IC0gTW92ZSBhdG9taWNfZGlzYWJsZSBhYm92ZSBwcmVwYXJlIChEYW5p
ZWwpCj4gLSBBZGQgYnJlYWRjcnVtYiB0byAuZW5hYmxlKCkgZG9jYm9vayAoRGFuaWVsKQoKV2h5
IG5vIHItYjogbWUgb3IgZGlkIHlvdSBub3QgYXBwbHkgYWxsIG15IHN1Z2dlc3Rpb25zPyBUb28g
bGF6eSB0byByZWFkCml0IGFsbCBhZ2FpbiA6LSkKLURhbmllbAoKPiAKPiBMaW5rIHRvIHYzOiBo
dHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMjAxOTA1MDIxOTQ5
NTYuMjE4NDQxLTItc2VhbkBwb29ybHkucnVuCj4gCj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmll
bEBmZndsbC5jaD4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9y
Zz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgICAgICB8ICA4
ICsrKy0KPiAgaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMuaCB8IDQ4ICsr
KysrKysrKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMo
KyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f
YXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBp
bmRleCA1NTM0MTVmZThlZGUuLmNjZjAxODMxZjI2NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw
dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv
bWljX2hlbHBlci5jCj4gQEAgLTk5OSw3ICs5OTksOSBAQCBkaXNhYmxlX291dHB1dHMoc3RydWN0
IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSkKPiAg
Cj4gIAkJLyogUmlnaHQgZnVuY3Rpb24gZGVwZW5kcyB1cG9uIHRhcmdldCBzdGF0ZS4gKi8KPiAg
CQlpZiAoZnVuY3MpIHsKPiAtCQkJaWYgKG5ld19jb25uX3N0YXRlLT5jcnRjICYmIGZ1bmNzLT5w
cmVwYXJlKQo+ICsJCQlpZiAoZnVuY3MtPmF0b21pY19kaXNhYmxlKQo+ICsJCQkJZnVuY3MtPmF0
b21pY19kaXNhYmxlKGVuY29kZXIsIG9sZF9zdGF0ZSk7Cj4gKwkJCWVsc2UgaWYgKG5ld19jb25u
X3N0YXRlLT5jcnRjICYmIGZ1bmNzLT5wcmVwYXJlKQo+ICAJCQkJZnVuY3MtPnByZXBhcmUoZW5j
b2Rlcik7Cj4gIAkJCWVsc2UgaWYgKGZ1bmNzLT5kaXNhYmxlKQo+ICAJCQkJZnVuY3MtPmRpc2Fi
bGUoZW5jb2Rlcik7Cj4gQEAgLTEzMDksNyArMTMxMSw5IEBAIHZvaWQgZHJtX2F0b21pY19oZWxw
ZXJfY29tbWl0X21vZGVzZXRfZW5hYmxlcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCWRy
bV9icmlkZ2VfcHJlX2VuYWJsZShlbmNvZGVyLT5icmlkZ2UpOwo+ICAKPiAgCQlpZiAoZnVuY3Mp
IHsKPiAtCQkJaWYgKGZ1bmNzLT5lbmFibGUpCj4gKwkJCWlmIChmdW5jcy0+YXRvbWljX2VuYWJs
ZSkKPiArCQkJCWZ1bmNzLT5hdG9taWNfZW5hYmxlKGVuY29kZXIsIG9sZF9zdGF0ZSk7Cj4gKwkJ
CWVsc2UgaWYgKGZ1bmNzLT5lbmFibGUpCj4gIAkJCQlmdW5jcy0+ZW5hYmxlKGVuY29kZXIpOwo+
ICAJCQllbHNlIGlmIChmdW5jcy0+Y29tbWl0KQo+ICAJCQkJZnVuY3MtPmNvbW1pdChlbmNvZGVy
KTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMu
aCBiL2luY2x1ZGUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlcl92dGFibGVzLmgKPiBpbmRleCA4ZjM2
MDI4MTFlYjUuLmFhNTA5YzEwNzA4MyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fbW9k
ZXNldF9oZWxwZXJfdnRhYmxlcy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVs
cGVyX3Z0YWJsZXMuaAo+IEBAIC02NzUsNiArNjc1LDUxIEBAIHN0cnVjdCBkcm1fZW5jb2Rlcl9o
ZWxwZXJfZnVuY3Mgewo+ICAJZW51bSBkcm1fY29ubmVjdG9yX3N0YXR1cyAoKmRldGVjdCkoc3Ry
dWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQkJCSAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rv
ciAqY29ubmVjdG9yKTsKPiAgCj4gKwkvKioKPiArCSAqIEBhdG9taWNfZGlzYWJsZToKPiArCSAq
Cj4gKwkgKiBUaGlzIGNhbGxiYWNrIHNob3VsZCBiZSB1c2VkIHRvIGRpc2FibGUgdGhlIGVuY29k
ZXIuIFdpdGggdGhlIGF0b21pYwo+ICsJICogZHJpdmVycyBpdCBpcyBjYWxsZWQgYmVmb3JlIHRo
aXMgZW5jb2RlcidzIENSVEMgaGFzIGJlZW4gc2h1dCBvZmYKPiArCSAqIHVzaW5nIHRoZWlyIG93
biAmZHJtX2NydGNfaGVscGVyX2Z1bmNzLmF0b21pY19kaXNhYmxlIGhvb2suIElmIHRoYXQKPiAr
CSAqIHNlcXVlbmNlIGlzIHRvbyBzaW1wbGUgZHJpdmVycyBjYW4ganVzdCBhZGQgdGhlaXIgb3du
IGRyaXZlciBwcml2YXRlCj4gKwkgKiBlbmNvZGVyIGhvb2tzIGFuZCBjYWxsIHRoZW0gZnJvbSBD
UlRDJ3MgY2FsbGJhY2sgYnkgbG9vcGluZyBvdmVyIGFsbAo+ICsJICogZW5jb2RlcnMgY29ubmVj
dGVkIHRvIGl0IHVzaW5nIGZvcl9lYWNoX2VuY29kZXJfb25fY3J0YygpLgo+ICsJICoKPiArCSAq
IFRoaXMgY2FsbGJhY2sgaXMgYSB2YXJpYW50IG9mIEBkaXNhYmxlIHRoYXQgcHJvdmlkZXMgdGhl
IGF0b21pYyBzdGF0ZQo+ICsJICogdG8gdGhlIGRyaXZlci4gSXQgdGFrZXMgcHJpb3JpdHkgb3Zl
ciBAZGlzYWJsZSBkdXJpbmcgYXRvbWljIGNvbW1pdHMuCj4gKwkgKgo+ICsJICogVGhpcyBob29r
IGlzIHVzZWQgb25seSBieSBhdG9taWMgaGVscGVycy4gQXRvbWljIGRyaXZlcnMgZG9uJ3QgbmVl
ZAo+ICsJICogdG8gaW1wbGVtZW50IGl0IGlmIHRoZXJlJ3Mgbm8gbmVlZCB0byBkaXNhYmxlIGFu
eXRoaW5nIGF0IHRoZSBlbmNvZGVyCj4gKwkgKiBsZXZlbC4gVG8gZW5zdXJlIHRoYXQgcnVudGlt
ZSBQTSBoYW5kbGluZyAodXNpbmcgZWl0aGVyIERQTVMgb3IgdGhlCj4gKwkgKiBuZXcgIkFDVElW
RSIgcHJvcGVydHkpIHdvcmtzIEBhdG9taWNfZGlzYWJsZSBtdXN0IGJlIHRoZSBpbnZlcnNlIG9m
Cj4gKwkgKiBAYXRvbWljX2VuYWJsZS4KPiArCSAqLwo+ICsJdm9pZCAoKmF0b21pY19kaXNhYmxl
KShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCSAgICAgICBzdHJ1Y3QgZHJtX2F0
b21pY19zdGF0ZSAqc3RhdGUpOwo+ICsKPiArCS8qKgo+ICsJICogQGF0b21pY19lbmFibGU6Cj4g
KwkgKgo+ICsJICogVGhpcyBjYWxsYmFjayBzaG91bGQgYmUgdXNlZCB0byBlbmFibGUgdGhlIGVu
Y29kZXIuIEl0IGlzIGNhbGxlZAo+ICsJICogYWZ0ZXIgdGhpcyBlbmNvZGVyJ3MgQ1JUQyBoYXMg
YmVlbiBlbmFibGVkIHVzaW5nIHRoZWlyIG93bgo+ICsJICogJmRybV9jcnRjX2hlbHBlcl9mdW5j
cy5hdG9taWNfZW5hYmxlIGhvb2suIElmIHRoYXQgc2VxdWVuY2UgaXMKPiArCSAqIHRvbyBzaW1w
bGUgZHJpdmVycyBjYW4ganVzdCBhZGQgdGhlaXIgb3duIGRyaXZlciBwcml2YXRlIGVuY29kZXIK
PiArCSAqIGhvb2tzIGFuZCBjYWxsIHRoZW0gZnJvbSBDUlRDJ3MgY2FsbGJhY2sgYnkgbG9vcGlu
ZyBvdmVyIGFsbCBlbmNvZGVycwo+ICsJICogY29ubmVjdGVkIHRvIGl0IHVzaW5nIGZvcl9lYWNo
X2VuY29kZXJfb25fY3J0YygpLgo+ICsJICoKPiArCSAqIFRoaXMgY2FsbGJhY2sgaXMgYSB2YXJp
YW50IG9mIEBlbmFibGUgdGhhdCBwcm92aWRlcyB0aGUgYXRvbWljIHN0YXRlCj4gKwkgKiB0byB0
aGUgZHJpdmVyLiBJdCBpcyBjYWxsZWQgaW4gcGxhY2Ugb2YgQGVuYWJsZSBkdXJpbmcgYXRvbWlj
Cj4gKwkgKiBjb21taXRzLgo+ICsJICoKPiArCSAqIFRoaXMgaG9vayBpcyB1c2VkIG9ubHkgYnkg
YXRvbWljIGhlbHBlcnMsIGZvciBzeW1tZXRyeSB3aXRoIEBkaXNhYmxlLgo+ICsJICogQXRvbWlj
IGRyaXZlcnMgZG9uJ3QgbmVlZCB0byBpbXBsZW1lbnQgaXQgaWYgdGhlcmUncyBubyBuZWVkIHRv
Cj4gKwkgKiBlbmFibGUgYW55dGhpbmcgYXQgdGhlIGVuY29kZXIgbGV2ZWwuIFRvIGVuc3VyZSB0
aGF0IHJ1bnRpbWUgUE0KPiArCSAqIGhhbmRsaW5nICh1c2luZyBlaXRoZXIgRFBNUyBvciB0aGUg
bmV3ICJBQ1RJVkUiIHByb3BlcnR5KSB3b3Jrcwo+ICsJICogQGVuYWJsZSBtdXN0IGJlIHRoZSBp
bnZlcnNlIG9mIEBkaXNhYmxlIGZvciBhdG9taWMgZHJpdmVycy4KPiArCSAqLwo+ICsJdm9pZCAo
KmF0b21pY19lbmFibGUpKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPiArCQkJICAgICAg
c3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKTsKPiArCj4gIAkvKioKPiAgCSAqIEBkaXNh
YmxlOgo+ICAJICoKPiBAQCAtNjkxLDYgKzczNiw5IEBAIHN0cnVjdCBkcm1fZW5jb2Rlcl9oZWxw
ZXJfZnVuY3Mgewo+ICAJICogaGFuZGxpbmcgKHVzaW5nIGVpdGhlciBEUE1TIG9yIHRoZSBuZXcg
IkFDVElWRSIgcHJvcGVydHkpIHdvcmtzCj4gIAkgKiBAZGlzYWJsZSBtdXN0IGJlIHRoZSBpbnZl
cnNlIG9mIEBlbmFibGUgZm9yIGF0b21pYyBkcml2ZXJzLgo+ICAJICoKPiArCSAqIEZvciBhdG9t
aWMgZHJpdmVycyBhbHNvIGNvbnNpZGVyIEBhdG9taWNfZGlzYWJsZSBhbmQgc2F2ZSB5b3Vyc2Vs
Zgo+ICsJICogZnJvbSBoYXZpbmcgdG8gcmVhZCB0aGUgTk9URSBiZWxvdyEKPiArCSAqCj4gIAkg
KiBOT1RFOgo+ICAJICoKPiAgCSAqIFdpdGggbGVnYWN5IENSVEMgaGVscGVycyB0aGVyZSdzIGEg
YmlnIHNlbWFudGljIGRpZmZlcmVuY2UgYmV0d2Vlbgo+IC0tIAo+IFNlYW4gUGF1bCwgU29mdHdh
cmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCj4gCgotLSAKRGFuaWVsIFZldHRlcgpT
b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs