From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4 02/11] drm: Add drm_atomic_get_(old|new-_connector_for_encoder() helpers Date: Wed, 8 May 2019 18:33:27 +0200 Message-ID: <20190508163327.GZ17751@phenom.ffwll.local> References: <20190508160920.144739-1-sean@poorly.run> <20190508160920.144739-3-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB4F78969E for ; Wed, 8 May 2019 16:33:32 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id w33so20333362edb.10 for ; Wed, 08 May 2019 09:33:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190508160920.144739-3-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Sean Paul , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMDgsIDIwMTkgYXQgMTI6MDk6MDdQTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJk LmNvbT4KPiAKPiBBZGQgZnVuY3Rpb25zIHRvIHRoZSBhdG9taWMgY29yZSB0byByZXRyaWV2ZSB0 aGUgb2xkIGFuZCBuZXcgY29ubmVjdG9ycwo+IGFzc29jaWF0ZWQgd2l0aCBhbiBlbmNvZGVyIGlu IGEgZHJtX2F0b21pY19zdGF0ZS4gVGhpcyBpcyB1c2VmdWwgZm9yCj4gZW5jb2RlcnMgYW5kIGJy aWRnZXMgdGhhdCBuZWVkIHRvIGFjY2VzcyB0aGUgY29ubmVjdG9yLCBmb3IgaW5zdGFuY2UgZm9y Cj4gdGhlIGRybV9kaXNwbGF5X2luZm8uCj4gCj4gVGhlIENSVEMgYXNzb2NpYXRlZCB3aXRoIHRo ZSBlbmNvZGVyIGNhbiBhbHNvIGJlIHJldHJpZXZlZCB0aHJvdWdoIHRoZQo+IGNvbm5lY3RvciBz dGF0ZSwgYW5kIGZyb20gaXQsIHRoZSBvbGQgYW5kIG5ldyBDUlRDIHN0YXRlcy4KPiAKPiBDaGFu Z2VkIGluIHY0Ogo+IC0gQWRkZWQgdG8gdGhlIHNldAo+IAo+IENjOiBEYW5pZWwgVmV0dGVyIDxk YW5pZWxAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVu dC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IAo+IFtzZWFucGF1bCByZW1vdmVkIFdBUk5z IGZyb20gaGVscGVycyBhbmQgYWRkZWQgZG9jcyB0byBleHBsYWluIHdoeQo+IHJldHVybmluZyBO VUxMIG1pZ2h0IGJlIHZhbGlkXQo+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxA Y2hyb21pdW0ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIHwgNzAg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9h dG9taWMuaCAgICAgfCAgNyArKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygr KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IDVlYjQwMTMwZmFmYi4uOTM2MDAyNDk1NTIz IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTc5Nyw2ICs3OTcsNzYgQEAgZHJtX2F0b21p Y19nZXRfcHJpdmF0ZV9vYmpfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19nZXRfcHJpdmF0ZV9vYmpfc3RhdGUpOwo+ ICAKPiArLyoqCj4gKyAqIGRybV9hdG9taWNfZ2V0X29sZF9jb25uZWN0b3JfZm9yX2VuY29kZXIg LSBHZXQgb2xkIGNvbm5lY3RvciBmb3IgYW4gZW5jb2Rlcgo+ICsgKiBAc3RhdGU6IEF0b21pYyBz dGF0ZQo+ICsgKiBAZW5jb2RlcjogVGhlIGVuY29kZXIgdG8gZmV0Y2ggdGhlIGNvbm5lY3RvciBz dGF0ZSBmb3IKPiArICoKPiArICogVGhpcyBmdW5jdGlvbiBmaW5kcyBhbmQgcmV0dXJucyB0aGUg Y29ubmVjdG9yIHRoYXQgd2FzIGNvbm5lY3RlZCB0byBAZW5jb2Rlcgo+ICsgKiBhcyBzcGVjaWZp ZWQgYnkgdGhlIEBzdGF0ZS4KPiArICoKPiArICogSWYgdGhlcmUgaXMgbm8gY29ubmVjdG9yIGlu IEBzdGF0ZSB3aGljaCBwcmV2aW91c2x5IGhhZCBAZW5jb2RlciBjb25uZWN0ZWQgdG8KPiArICog aXQsIHRoaXMgZnVuY3Rpb24gd2lsbCByZXR1cm4gTlVMTC4gV2hpbGUgdGhpcyBtYXkgc2VlbSBs aWtlIGFuIGludmFsaWQgdXNlCj4gKyAqIGNhc2UsIGl0IGlzIHNvbWV0aW1lcyBhIHVzZWZ1bCB0 byBkaWZmZXJlbnRpYXRlIGNvbW1pdHMgd2hpY2ggaGFkIG5vIHByaW9yCj4gKyAqIGNvbm5lY3Rv cnMgYXR0YWNoZWQgdG8gQGVuY29kZXIgdnMgb25lcyB0aGF0IGRpZCAoYW5kIHRvIGluc3BlY3Qg dGhlaXIKPiArICogQHN0YXRlKS4gVGhpcyBpcyBlc3BlY2lhbGx5IHRydWUgaW4gZW5hYmxlIGhv b2tzIGJlY2F1c2UgdGhlIHBpcGVsaW5lIGhhcwo+ICsgKiBjaGFuZ2VkL3dpbGwgY2hhbmdlLgoK cy9oYXMgY2hhbmdlZC8vIC4uLiBJIG1lYW50IHlvdSdsbCBwaWNrIHRoZSByaWdodCB2ZXIgdGVu c2UgOi0pCgo+ICsgKgo+ICsgKiBSZXR1cm5zOiBUaGUgb2xkIGNvbm5lY3RvciBjb25uZWN0ZWQg dG8gQGVuY29kZXIsIG9yIE5VTEwgaWYgdGhlIGVuY29kZXIgaXMKPiArICogbm90IGNvbm5lY3Rl ZC4KPiArICovCj4gK3N0cnVjdCBkcm1fY29ubmVjdG9yICoKPiArZHJtX2F0b21pY19nZXRfb2xk X2Nvbm5lY3Rvcl9mb3JfZW5jb2RlcihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g KwkJCQkJIHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiArewo+ICsJc3RydWN0IGRybV9j b25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bmVjdG9yOwo+ICsJdW5zaWduZWQgaW50IGk7Cj4gKwo+ICsJZm9yX2VhY2hfb2xkX2Nvbm5lY3Rv cl9pbl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yLCBjb25uX3N0YXRlLCBpKSB7Cj4gKwkJaWYgKGNv bm5fc3RhdGUtPmJlc3RfZW5jb2RlciA9PSBlbmNvZGVyKQo+ICsJCQlyZXR1cm4gY29ubmVjdG9y Owo+ICsJfQo+ICsKPiArCXJldHVybiBOVUxMOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2F0 b21pY19nZXRfb2xkX2Nvbm5lY3Rvcl9mb3JfZW5jb2Rlcik7Cj4gKwo+ICsvKioKPiArICogZHJt X2F0b21pY19nZXRfbmV3X2Nvbm5lY3Rvcl9mb3JfZW5jb2RlciAtIEdldCBuZXcgY29ubmVjdG9y IGZvciBhbiBlbmNvZGVyCj4gKyAqIEBzdGF0ZTogQXRvbWljIHN0YXRlCj4gKyAqIEBlbmNvZGVy OiBUaGUgZW5jb2RlciB0byBmZXRjaCB0aGUgY29ubmVjdG9yIHN0YXRlIGZvcgo+ICsgKgo+ICsg KiBUaGlzIGZ1bmN0aW9uIGZpbmRzIGFuZCByZXR1cm5zIHRoZSBjb25uZWN0b3IgdGhhdCB3aWxs IGJlIGNvbm5lY3RlZCB0bwo+ICsgKiBAZW5jb2RlciBhcyBzcGVjaWZpZWQgYnkgdGhlIEBzdGF0 ZS4KPiArICoKPiArICogSWYgdGhlcmUgaXMgbm8gY29ubmVjdG9yIGluIEBzdGF0ZSB3aGljaCB3 aWxsIGhhdmUgQGVuY29kZXIgY29ubmVjdGVkIHRvIGl0LAo+ICsgKiB0aGlzIGZ1bmN0aW9uIHdp bGwgcmV0dXJuIE5VTEwuIFdoaWxlIHRoaXMgbWF5IHNlZW0gbGlrZSBhbiBpbnZhbGlkIHVzZSBj YXNlLAo+ICsgKiBpdCBpcyBzb21ldGltZXMgYSB1c2VmdWwgdG8gZGlmZmVyZW50aWF0ZSBjb21t aXRzIHdoaWNoIGhhdmUgbm8gY29ubmVjdG9ycwo+ICsgKiBhdHRhY2hlZCB0byBAZW5jb2RlciB2 cyBvbmVzIHRoYXQgZG8gKGFuZCB0byBpbnNwZWN0IHRoZWlyIHN0YXRlKS4gVGhpcyBpcwo+ICsg KiBlc3BlY2lhbGx5IHRydWUgaW4gZGlzYWJsZSBob29rcyBiZWNhdXNlIHRoZSBwaXBlbGluZSBo YXMgY2hhbmdlZC93aWxsCj4gKyAqIGNoYW5nZS4KCnMvd2lsbCBjaGFuZ2UvLwoKPiArICoKPiAr ICogUmV0dXJuczogVGhlIG5ldyBjb25uZWN0b3IgY29ubmVjdGVkIHRvIEBlbmNvZGVyLCBvciBO VUxMIGlmIHRoZSBlbmNvZGVyIGlzCj4gKyAqIG5vdCBjb25uZWN0ZWQuCj4gKyAqLwo+ICtzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqCj4gK2RybV9hdG9taWNfZ2V0X25ld19jb25uZWN0b3JfZm9yX2Vu Y29kZXIoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICsJCQkJCSBzdHJ1Y3QgZHJt X2VuY29kZXIgKmVuY29kZXIpCj4gK3sKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpj b25uX3N0YXRlOwo+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiArCXVuc2ln bmVkIGludCBpOwo+ICsKPiArCWZvcl9lYWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUs IGNvbm5lY3RvciwgY29ubl9zdGF0ZSwgaSkgewo+ICsJCWlmIChjb25uX3N0YXRlLT5iZXN0X2Vu Y29kZXIgPT0gZW5jb2RlcikKPiArCQkJcmV0dXJuIGNvbm5lY3RvcjsKPiArCX0KPiArCj4gKwly ZXR1cm4gTlVMTDsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfZ2V0X25ld19jb25u ZWN0b3JfZm9yX2VuY29kZXIpOwoKTWF5YmUgYWxzbyBhZGQgYSAiU2VlIGFsc28gZHJtX2F0b21p Y19nZXRfb2xkX2Nvbm5lY3Rvcl9mb3JfZW5jb2RlcigpIGFuZApkcm1fYXRvbWljX2dldF9uZXdf Y29ubmVjdG9yX2Zvcl9lbmNvZGVyKCkuIiB0byB0aGUga2VybmVsZG9jIG9mCmRybV9jb25uZWN0 b3Jfc3RhdGUuYmVzdF9lbmNvZGVyLgoKV2l0aCB0aGVzZSBkb2Mgbml0czoKClJldmlld2VkLWJ5 OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiArCj4gIC8qKgo+ICAg KiBkcm1fYXRvbWljX2dldF9jb25uZWN0b3Jfc3RhdGUgLSBnZXQgY29ubmVjdG9yIHN0YXRlCj4g ICAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vZHJtX2F0b21pYy5oIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gaW5kZXgg ODI0YTVlZDRlMjE2Li5kNmIzYWNkMzRlMWMgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJt X2F0b21pYy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gQEAgLTQ1Myw2ICs0 NTMsMTMgQEAgc3RydWN0IGRybV9wcml2YXRlX3N0YXRlICogX19tdXN0X2NoZWNrCj4gIGRybV9h dG9taWNfZ2V0X3ByaXZhdGVfb2JqX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSwKPiAgCQkJCSBzdHJ1Y3QgZHJtX3ByaXZhdGVfb2JqICpvYmopOwo+ICAKPiArc3RydWN0IGRy bV9jb25uZWN0b3IgKgo+ICtkcm1fYXRvbWljX2dldF9vbGRfY29ubmVjdG9yX2Zvcl9lbmNvZGVy KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJCQkgc3RydWN0IGRybV9lbmNv ZGVyICplbmNvZGVyKTsKPiArc3RydWN0IGRybV9jb25uZWN0b3IgKgo+ICtkcm1fYXRvbWljX2dl dF9uZXdfY29ubmVjdG9yX2Zvcl9lbmNvZGVyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSwKPiArCQkJCQkgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiArCj4gIC8qKgo+ICAg KiBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlIC0gZ2V0IGNydGMgc3RhdGUsIGlm IGl0IGV4aXN0cwo+ICAgKiBAc3RhdGU6IGdsb2JhbCBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gLS0g Cj4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKPiAK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw=