From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 02/11] drm: Add drm_atomic_get_(old|new-_connector_for_encoder() helpers Date: Sun, 12 May 2019 19:48:36 +0300 Message-ID: <20190512164836.GA15762@pendragon.ideasonboard.com> References: <20190508160920.144739-1-sean@poorly.run> <20190508160920.144739-3-sean@poorly.run> <20190508163327.GZ17751@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAE1B897F9 for ; Sun, 12 May 2019 16:48:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190508163327.GZ17751@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , dri-devel@lists.freedesktop.org, Sean Paul , Maarten Lankhorst , Maxime Ripard , David Airlie , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VhbiwKCkluIHRoZSBzdWJqZWN0IGxpbmUsIHMvLS8pLwoKT24gV2VkLCBNYXkgMDgsIDIw MTkgYXQgMDY6MzM6MjdQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBXZWQsIE1h eSAwOCwgMjAxOSBhdCAxMjowOTowN1BNIC0wNDAwLCBTZWFuIFBhdWwgd3JvdGU6Cj4gPiBGcm9t OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4g PiAKPiA+IEFkZCBmdW5jdGlvbnMgdG8gdGhlIGF0b21pYyBjb3JlIHRvIHJldHJpZXZlIHRoZSBv bGQgYW5kIG5ldyBjb25uZWN0b3JzCj4gPiBhc3NvY2lhdGVkIHdpdGggYW4gZW5jb2RlciBpbiBh IGRybV9hdG9taWNfc3RhdGUuIFRoaXMgaXMgdXNlZnVsIGZvcgo+ID4gZW5jb2RlcnMgYW5kIGJy aWRnZXMgdGhhdCBuZWVkIHRvIGFjY2VzcyB0aGUgY29ubmVjdG9yLCBmb3IgaW5zdGFuY2UgZm9y Cj4gPiB0aGUgZHJtX2Rpc3BsYXlfaW5mby4KPiA+IAo+ID4gVGhlIENSVEMgYXNzb2NpYXRlZCB3 aXRoIHRoZSBlbmNvZGVyIGNhbiBhbHNvIGJlIHJldHJpZXZlZCB0aHJvdWdoIHRoZQo+ID4gY29u bmVjdG9yIHN0YXRlLCBhbmQgZnJvbSBpdCwgdGhlIG9sZCBhbmQgbmV3IENSVEMgc3RhdGVzLgo+ ID4gCj4gPiBDaGFuZ2VkIGluIHY0Ogo+ID4gLSBBZGRlZCB0byB0aGUgc2V0Cj4gPiAKPiA+IENj OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVy ZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiAKPiA+ IFtzZWFucGF1bCByZW1vdmVkIFdBUk5zIGZyb20gaGVscGVycyBhbmQgYWRkZWQgZG9jcyB0byBl eHBsYWluIHdoeQo+ID4gcmV0dXJuaW5nIE5VTEwgbWlnaHQgYmUgdmFsaWRdCj4gPiBTaWduZWQt b2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCA3MCArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKPiA+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljLmggICAgIHwgIDcgKysrKwo+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljLmMKPiA+IGluZGV4IDVlYjQwMTMwZmFmYi4uOTM2MDAyNDk1NTIzIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWMuYwo+ID4gQEAgLTc5Nyw2ICs3OTcsNzYgQEAgZHJtX2F0b21pY19nZXRfcHJp dmF0ZV9vYmpfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4gIH0KPiA+ ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfZ2V0X3ByaXZhdGVfb2JqX3N0YXRlKTsKPiA+ICAK PiA+ICsvKioKPiA+ICsgKiBkcm1fYXRvbWljX2dldF9vbGRfY29ubmVjdG9yX2Zvcl9lbmNvZGVy IC0gR2V0IG9sZCBjb25uZWN0b3IgZm9yIGFuIGVuY29kZXIKPiA+ICsgKiBAc3RhdGU6IEF0b21p YyBzdGF0ZQo+ID4gKyAqIEBlbmNvZGVyOiBUaGUgZW5jb2RlciB0byBmZXRjaCB0aGUgY29ubmVj dG9yIHN0YXRlIGZvcgo+ID4gKyAqCj4gPiArICogVGhpcyBmdW5jdGlvbiBmaW5kcyBhbmQgcmV0 dXJucyB0aGUgY29ubmVjdG9yIHRoYXQgd2FzIGNvbm5lY3RlZCB0byBAZW5jb2Rlcgo+ID4gKyAq IGFzIHNwZWNpZmllZCBieSB0aGUgQHN0YXRlLgo+ID4gKyAqCj4gPiArICogSWYgdGhlcmUgaXMg bm8gY29ubmVjdG9yIGluIEBzdGF0ZSB3aGljaCBwcmV2aW91c2x5IGhhZCBAZW5jb2RlciBjb25u ZWN0ZWQgdG8KPiA+ICsgKiBpdCwgdGhpcyBmdW5jdGlvbiB3aWxsIHJldHVybiBOVUxMLiBXaGls ZSB0aGlzIG1heSBzZWVtIGxpa2UgYW4gaW52YWxpZCB1c2UKPiA+ICsgKiBjYXNlLCBpdCBpcyBz b21ldGltZXMgYSB1c2VmdWwgdG8gZGlmZmVyZW50aWF0ZSBjb21taXRzIHdoaWNoIGhhZCBubyBw cmlvcgoKcy9hIHVzZWZ1bC91c2VmdWwvCgo+ID4gKyAqIGNvbm5lY3RvcnMgYXR0YWNoZWQgdG8g QGVuY29kZXIgdnMgb25lcyB0aGF0IGRpZCAoYW5kIHRvIGluc3BlY3QgdGhlaXIKPiA+ICsgKiBA c3RhdGUpLiBUaGlzIGlzIGVzcGVjaWFsbHkgdHJ1ZSBpbiBlbmFibGUgaG9va3MgYmVjYXVzZSB0 aGUgcGlwZWxpbmUgaGFzCgpzL0BzdGF0ZS9zdGF0ZS8sIG90aGVyd2lzZSB5b3UgcmVmZXIgdG8g dGhlIHBhcmFtZXRlciBwYXNzZWQgdG8gdGhpcwpmdW5jdGlvbiwgd2hpY2ggaXMgbm90IGEgY29u bmVjdG9yIHN0YXRlLgoKPiA+ICsgKiBjaGFuZ2VkL3dpbGwgY2hhbmdlLgo+IAo+IHMvaGFzIGNo YW5nZWQvLyAuLi4gSSBtZWFudCB5b3UnbGwgcGljayB0aGUgcmlnaHQgdmVyIHRlbnNlIDotKQo+ IAo+ID4gKyAqCj4gPiArICogUmV0dXJuczogVGhlIG9sZCBjb25uZWN0b3IgY29ubmVjdGVkIHRv IEBlbmNvZGVyLCBvciBOVUxMIGlmIHRoZSBlbmNvZGVyIGlzCj4gPiArICogbm90IGNvbm5lY3Rl ZC4KPiA+ICsgKi8KPiA+ICtzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqCj4gPiArZHJtX2F0b21pY19n ZXRfb2xkX2Nvbm5lY3Rvcl9mb3JfZW5jb2RlcihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3Rh dGUsCj4gPiArCQkJCQkgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKQo+ID4gK3sKPiA+ICsJ c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gPiArCXN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3I7Cj4gPiArCXVuc2lnbmVkIGludCBpOwo+ID4gKwo+ID4gKwlm b3JfZWFjaF9vbGRfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIGNvbm5fc3Rh dGUsIGkpIHsKPiA+ICsJCWlmIChjb25uX3N0YXRlLT5iZXN0X2VuY29kZXIgPT0gZW5jb2RlcikK PiA+ICsJCQlyZXR1cm4gY29ubmVjdG9yOwo+ID4gKwl9Cj4gPiArCj4gPiArCXJldHVybiBOVUxM Owo+ID4gK30KPiA+ICtFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfZ2V0X29sZF9jb25uZWN0b3Jf Zm9yX2VuY29kZXIpOwo+ID4gKwo+ID4gKy8qKgo+ID4gKyAqIGRybV9hdG9taWNfZ2V0X25ld19j b25uZWN0b3JfZm9yX2VuY29kZXIgLSBHZXQgbmV3IGNvbm5lY3RvciBmb3IgYW4gZW5jb2Rlcgo+ ID4gKyAqIEBzdGF0ZTogQXRvbWljIHN0YXRlCj4gPiArICogQGVuY29kZXI6IFRoZSBlbmNvZGVy IHRvIGZldGNoIHRoZSBjb25uZWN0b3Igc3RhdGUgZm9yCj4gPiArICoKPiA+ICsgKiBUaGlzIGZ1 bmN0aW9uIGZpbmRzIGFuZCByZXR1cm5zIHRoZSBjb25uZWN0b3IgdGhhdCB3aWxsIGJlIGNvbm5l Y3RlZCB0bwo+ID4gKyAqIEBlbmNvZGVyIGFzIHNwZWNpZmllZCBieSB0aGUgQHN0YXRlLgo+ID4g KyAqCj4gPiArICogSWYgdGhlcmUgaXMgbm8gY29ubmVjdG9yIGluIEBzdGF0ZSB3aGljaCB3aWxs IGhhdmUgQGVuY29kZXIgY29ubmVjdGVkIHRvIGl0LAo+ID4gKyAqIHRoaXMgZnVuY3Rpb24gd2ls bCByZXR1cm4gTlVMTC4gV2hpbGUgdGhpcyBtYXkgc2VlbSBsaWtlIGFuIGludmFsaWQgdXNlIGNh c2UsCj4gPiArICogaXQgaXMgc29tZXRpbWVzIGEgdXNlZnVsIHRvIGRpZmZlcmVudGlhdGUgY29t bWl0cyB3aGljaCBoYXZlIG5vIGNvbm5lY3RvcnMKCnMvYSB1c2VmdWwvdXNlZnVsLwoKPiA+ICsg KiBhdHRhY2hlZCB0byBAZW5jb2RlciB2cyBvbmVzIHRoYXQgZG8gKGFuZCB0byBpbnNwZWN0IHRo ZWlyIHN0YXRlKS4gVGhpcyBpcwo+ID4gKyAqIGVzcGVjaWFsbHkgdHJ1ZSBpbiBkaXNhYmxlIGhv b2tzIGJlY2F1c2UgdGhlIHBpcGVsaW5lIGhhcyBjaGFuZ2VkL3dpbGwKPiA+ICsgKiBjaGFuZ2Uu Cj4gCj4gcy93aWxsIGNoYW5nZS8vCj4gCj4gPiArICoKPiA+ICsgKiBSZXR1cm5zOiBUaGUgbmV3 IGNvbm5lY3RvciBjb25uZWN0ZWQgdG8gQGVuY29kZXIsIG9yIE5VTEwgaWYgdGhlIGVuY29kZXIg aXMKPiA+ICsgKiBub3QgY29ubmVjdGVkLgo+ID4gKyAqLwo+ID4gK3N0cnVjdCBkcm1fY29ubmVj dG9yICoKPiA+ICtkcm1fYXRvbWljX2dldF9uZXdfY29ubmVjdG9yX2Zvcl9lbmNvZGVyKHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiA+ICsJCQkJCSBzdHJ1Y3QgZHJtX2VuY29kZXIg KmVuY29kZXIpCj4gPiArewo+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9z dGF0ZTsKPiA+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiA+ICsJdW5zaWdu ZWQgaW50IGk7Cj4gPiArCj4gPiArCWZvcl9lYWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUoc3Rh dGUsIGNvbm5lY3RvciwgY29ubl9zdGF0ZSwgaSkgewo+ID4gKwkJaWYgKGNvbm5fc3RhdGUtPmJl c3RfZW5jb2RlciA9PSBlbmNvZGVyKQo+ID4gKwkJCXJldHVybiBjb25uZWN0b3I7Cj4gPiArCX0K PiA+ICsKPiA+ICsJcmV0dXJuIE5VTEw7Cj4gPiArfQo+ID4gK0VYUE9SVF9TWU1CT0woZHJtX2F0 b21pY19nZXRfbmV3X2Nvbm5lY3Rvcl9mb3JfZW5jb2Rlcik7Cj4gCj4gTWF5YmUgYWxzbyBhZGQg YSAiU2VlIGFsc28gZHJtX2F0b21pY19nZXRfb2xkX2Nvbm5lY3Rvcl9mb3JfZW5jb2RlcigpIGFu ZAo+IGRybV9hdG9taWNfZ2V0X25ld19jb25uZWN0b3JfZm9yX2VuY29kZXIoKS4iIHRvIHRoZSBr ZXJuZWxkb2Mgb2YKPiBkcm1fY29ubmVjdG9yX3N0YXRlLmJlc3RfZW5jb2Rlci4KPiAKPiBXaXRo IHRoZXNlIGRvYyBuaXRzOgo+IAo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgo+IAo+ID4gKwo+ID4gIC8qKgo+ID4gICAqIGRybV9hdG9taWNfZ2V0 X2Nvbm5lY3Rvcl9zdGF0ZSAtIGdldCBjb25uZWN0b3Igc3RhdGUKPiA+ICAgKiBAc3RhdGU6IGds b2JhbCBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJt X2F0b21pYy5oIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gPiBpbmRleCA4MjRhNWVkNGUy MTYuLmQ2YjNhY2QzNGUxYyAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMu aAo+ID4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gPiBAQCAtNDUzLDYgKzQ1Mywx MyBAQCBzdHJ1Y3QgZHJtX3ByaXZhdGVfc3RhdGUgKiBfX211c3RfY2hlY2sKPiA+ICBkcm1fYXRv bWljX2dldF9wcml2YXRlX29ial9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUs Cj4gPiAgCQkJCSBzdHJ1Y3QgZHJtX3ByaXZhdGVfb2JqICpvYmopOwo+ID4gIAo+ID4gK3N0cnVj dCBkcm1fY29ubmVjdG9yICoKPiA+ICtkcm1fYXRvbWljX2dldF9vbGRfY29ubmVjdG9yX2Zvcl9l bmNvZGVyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiA+ICsJCQkJCSBzdHJ1Y3Qg ZHJtX2VuY29kZXIgKmVuY29kZXIpOwo+ID4gK3N0cnVjdCBkcm1fY29ubmVjdG9yICoKPiA+ICtk cm1fYXRvbWljX2dldF9uZXdfY29ubmVjdG9yX2Zvcl9lbmNvZGVyKHN0cnVjdCBkcm1fYXRvbWlj X3N0YXRlICpzdGF0ZSwKPiA+ICsJCQkJCSBzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpOwo+ ID4gKwo+ID4gIC8qKgo+ID4gICAqIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUg LSBnZXQgY3J0YyBzdGF0ZSwgaWYgaXQgZXhpc3RzCj4gPiAgICogQHN0YXRlOiBnbG9iYWwgYXRv bWljIHN0YXRlIG9iamVjdAoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==