From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Martyn Welch <martyn.welch@collabora.co.uk>,
David Airlie <airlied@linux.ie>,
Peter Senna Tschudin <peter.senna@gmail.com>,
dri-devel@lists.freedesktop.org,
Martin Donnelly <martin.donnelly@ge.com>
Subject: Re: [PATCH v2 1/2] drm/bridge: make dw_mipi_dsi.h self-contained
Date: Mon, 20 May 2019 00:15:38 +0300 [thread overview]
Message-ID: <20190519211538.GE5213@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190519183636.19588-2-sam@ravnborg.org>
Hi Sam,
Thank you for the patch.
On Sun, May 19, 2019 at 08:36:35PM +0200, Sam Ravnborg wrote:
> To allow users to include dw_mipi_dsi.h without pulling in dependencies
> make dw_mipi_dsi.h self-contained.
> Use forward declarations when possible.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Peter Senna Tschudin <peter.senna@gmail.com>
> Cc: Martin Donnelly <martin.donnelly@ge.com>
> Cc: Martyn Welch <martyn.welch@collabora.co.uk>
> ---
> include/drm/bridge/dw_mipi_dsi.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/drm/bridge/dw_mipi_dsi.h b/include/drm/bridge/dw_mipi_dsi.h
> index 7d3dd69a5caa..825c222afbfc 100644
> --- a/include/drm/bridge/dw_mipi_dsi.h
> +++ b/include/drm/bridge/dw_mipi_dsi.h
> @@ -9,8 +9,16 @@
>
> #ifndef __DW_MIPI_DSI__
> #define __DW_MIPI_DSI__
> +#include <linux/types.h>
>
> +struct drm_display_mode;
> +struct drm_encoder;
> struct dw_mipi_dsi;
> +struct dw_mipi_dsi_host_ops;
> +struct dw_mipi_dsi_phy_ops;
> +struct dw_mipi_dsi_plat_data;
No need to forward-declare these three structures, they're defined in
this very .h file.
> +struct mipi_dsi_device;
> +struct platform_device;
You need to pull in drm/modes.h for drm_mode_status.
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> struct dw_mipi_dsi_phy_ops {
> int (*init)(void *priv_data);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-19 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 18:36 [PATCH v2 0/2] drm/bridge: drop drmP.h usage Sam Ravnborg
2019-05-19 18:36 ` [PATCH v2 1/2] drm/bridge: make dw_mipi_dsi.h self-contained Sam Ravnborg
2019-05-19 21:15 ` Laurent Pinchart [this message]
2019-05-19 18:36 ` [PATCH v2 2/2] drm/bridge: drop drmP.h usage Sam Ravnborg
2019-05-19 21:22 ` Laurent Pinchart
2019-05-20 18:06 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519211538.GE5213@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=martin.donnelly@ge.com \
--cc=martyn.welch@collabora.co.uk \
--cc=peter.senna@gmail.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox