Re: [PATCH] drm: etnaviv: avoid DMA API warning when importing buffers

[Russell King - ARM Linux admin <linux@armlinux.org.uk>]

On Wed, May 22, 2019 at 12:04:27PM +0200, Lucas Stach wrote:
> Hi Russell,
> 
> Am Samstag, den 18.05.2019, 22:37 +0100 schrieb Russell King - ARM
> Linux admin:
> > On Sat, May 18, 2019 at 06:04:42PM -0300, Fabio Estevam wrote:
> > > Hi Russell,
> > > 
> > > On Sat, May 18, 2019 at 2:51 PM Russell King - ARM Linux admin
> > > <linux@armlinux.org.uk> wrote:
> > > > 
> > > > Ping.
> > > 
> > > This patch is present in Lucas' pull request:
> > > https://lists.freedesktop.org/archives/etnaviv/2019-May/002490.html
> > 
> > I'm wondering why it didn't make 5.1 since it's a regression.
> 
> I didn't see the importance to put this into fixes, as it's getting rid
> of a warning which will only be present when a debug option is enabled.
> So it should be invisible to most users and it doesn't regress
> functionality.

That depends on your point of view, how you use the kernel, and what
you're using the kernel for.  If you're trying to use dma debugging
(which should always be enabled when doing driver development) and
you have a subsystem that keeps triggering it, then it is a serious
problem.

Given that we want developers to have such options on, having false
complaints is counter-productive.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel