[PATCH v2 1/2] drm: panel-orientation-quirks: Add quirk for GPD pocket2

[PATCH v2 1/2] drm: panel-orientation-quirks: Add quirk for GPD pocket2

[Hans de Goede]

GPD has done it again, make a nice device (good), use way too generic
DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date
matching, so the gpd_pocket2 data struct may very well need to be updated
with some extra bios-dates in the future.

Changes in v2:
-Add one more known BIOS date to the list of BIOS dates

Cc: Jurgen Kramer <gtmkramer@xs4all.nl>
Reported-by: Jurgen Kramer <gtmkramer@xs4all.nl>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 521aff99b08a..98679c831f66 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -50,6 +50,14 @@ static const struct drm_dmi_panel_orientation_data gpd_pocket = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data gpd_pocket2 = {
+	.width = 1200,
+	.height = 1920,
+	.bios_dates = (const char * const []){ "06/28/2018", "08/28/2018",
+		"12/07/2018", NULL },
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data gpd_win = {
 	.width = 720,
 	.height = 1280,
@@ -112,6 +120,14 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
 		.driver_data = (void *)&gpd_pocket,
+	}, {	/* GPD Pocket 2 (generic strings, also match on bios date) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
+		},
+		.driver_data = (void *)&gpd_pocket2,
 	}, {	/* GPD Win (same note on DMI match as GPD Pocket) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
-- 
2.21.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Hans de Goede]

GPD has done it again, make a nice device (good), use way too generic
DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date
matching, so the gpd_micropc data struct may very well need to be updated
with some extra bios-dates in the future.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 98679c831f66..d8a0bcd02f34 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -42,6 +42,14 @@ static const struct drm_dmi_panel_orientation_data asus_t100ha = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data gpd_micropc = {
+	.width = 720,
+	.height = 1280,
+	.bios_dates = (const char * const []){ "04/26/2019",
+		NULL },
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data gpd_pocket = {
 	.width = 1200,
 	.height = 1920,
@@ -107,6 +115,14 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
 		},
 		.driver_data = (void *)&asus_t100ha,
+	}, {	/* GPD MicroPC (generic strings, also match on bios date) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
+		},
+		.driver_data = (void *)&gpd_micropc,
 	}, {	/*
 		 * GPD Pocket, note that the the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
-- 
2.21.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]

On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote:
> GPD has done it again, make a nice device (good), use way too generic
> DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).
>
> Because of the too generic DMI strings this entry is also doing bios-date
> matching, so the gpd_micropc data struct may very well need to be updated
> with some extra bios-dates in the future.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

For both patches,
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Hans de Goede]

Hi,

On 06-06-19 11:14, Maxime Ripard wrote:
> On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote:
>> GPD has done it again, make a nice device (good), use way too generic
>> DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).
>>
>> Because of the too generic DMI strings this entry is also doing bios-date
>> matching, so the gpd_micropc data struct may very well need to be updated
>> with some extra bios-dates in the future.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> For both patches,
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thank you, I've pushed both to drm-misc-next now.

Can you add them to drm-misc-fixes please ?

(AFAIK I'm not supposed to do that myself)

Regards,

Hans

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1157 bytes --]

On Thu, Jun 06, 2019 at 01:13:40PM +0200, Hans de Goede wrote:
> On 06-06-19 11:14, Maxime Ripard wrote:
> > On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote:
> > > GPD has done it again, make a nice device (good), use way too generic
> > > DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).
> > >
> > > Because of the too generic DMI strings this entry is also doing bios-date
> > > matching, so the gpd_micropc data struct may very well need to be updated
> > > with some extra bios-dates in the future.
> > >
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > For both patches,
> > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Thank you, I've pushed both to drm-misc-next now.
>
> Can you add them to drm-misc-fixes please ?
>
> (AFAIK I'm not supposed to do that myself)

You definitely can :)

Now that it's in next though, it's pretty hard to come back in time. I
guess we could just apply it in fixes and let git figure it out, or
revert the one in next. I'm not sure which one is preferred
though.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Hans de Goede]

Hi,

On 06-06-19 15:38, Maxime Ripard wrote:
> On Thu, Jun 06, 2019 at 01:13:40PM +0200, Hans de Goede wrote:
>> On 06-06-19 11:14, Maxime Ripard wrote:
>>> On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote:
>>>> GPD has done it again, make a nice device (good), use way too generic
>>>> DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).
>>>>
>>>> Because of the too generic DMI strings this entry is also doing bios-date
>>>> matching, so the gpd_micropc data struct may very well need to be updated
>>>> with some extra bios-dates in the future.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> For both patches,
>>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>>
>> Thank you, I've pushed both to drm-misc-next now.
>>
>> Can you add them to drm-misc-fixes please ?
>>
>> (AFAIK I'm not supposed to do that myself)
> 
> You definitely can :)
> 
> Now that it's in next though, it's pretty hard to come back in time. I
> guess we could just apply it in fixes and let git figure it out, or
> revert the one in next. I'm not sure which one is preferred
> though.

I thought that the procedure was to get it in -next and then cherry-pick
into -fixes? Git should sort this out without issues when Linus merges
-next; or when we back-merge Linus' tree.

Regards,

Hans

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1778 bytes --]

On Thu, Jun 06, 2019 at 04:03:57PM +0200, Hans de Goede wrote:
> Hi,
>
> On 06-06-19 15:38, Maxime Ripard wrote:
> > On Thu, Jun 06, 2019 at 01:13:40PM +0200, Hans de Goede wrote:
> > > On 06-06-19 11:14, Maxime Ripard wrote:
> > > > On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote:
> > > > > GPD has done it again, make a nice device (good), use way too generic
> > > > > DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).
> > > > >
> > > > > Because of the too generic DMI strings this entry is also doing bios-date
> > > > > matching, so the gpd_micropc data struct may very well need to be updated
> > > > > with some extra bios-dates in the future.
> > > > >
> > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > >
> > > > For both patches,
> > > > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > >
> > > Thank you, I've pushed both to drm-misc-next now.
> > >
> > > Can you add them to drm-misc-fixes please ?
> > >
> > > (AFAIK I'm not supposed to do that myself)
> >
> > You definitely can :)
> >
> > Now that it's in next though, it's pretty hard to come back in time. I
> > guess we could just apply it in fixes and let git figure it out, or
> > revert the one in next. I'm not sure which one is preferred
> > though.
>
> I thought that the procedure was to get it in -next and then cherry-pick
> into -fixes?

If you feel like something should be in fixes, you can definitely
apply it there only.

> Git should sort this out without issues when Linus merges -next; or
> when we back-merge Linus' tree.

Yeah, looking at the doc, cherry-picking is the one encouraged, so
feel free to cherry-pick them in drm-misc-fixes.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

[Hans de Goede]

Hi,

On 07-06-19 16:54, Maxime Ripard wrote:
> On Thu, Jun 06, 2019 at 04:03:57PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06-06-19 15:38, Maxime Ripard wrote:
>>> On Thu, Jun 06, 2019 at 01:13:40PM +0200, Hans de Goede wrote:
>>>> On 06-06-19 11:14, Maxime Ripard wrote:
>>>>> On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote:
>>>>>> GPD has done it again, make a nice device (good), use way too generic
>>>>>> DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).
>>>>>>
>>>>>> Because of the too generic DMI strings this entry is also doing bios-date
>>>>>> matching, so the gpd_micropc data struct may very well need to be updated
>>>>>> with some extra bios-dates in the future.
>>>>>>
>>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>>>
>>>>> For both patches,
>>>>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>>>>
>>>> Thank you, I've pushed both to drm-misc-next now.
>>>>
>>>> Can you add them to drm-misc-fixes please ?
>>>>
>>>> (AFAIK I'm not supposed to do that myself)
>>>
>>> You definitely can :)
>>>
>>> Now that it's in next though, it's pretty hard to come back in time. I
>>> guess we could just apply it in fixes and let git figure it out, or
>>> revert the one in next. I'm not sure which one is preferred
>>> though.
>>
>> I thought that the procedure was to get it in -next and then cherry-pick
>> into -fixes?
> 
> If you feel like something should be in fixes, you can definitely
> apply it there only.
> 
>> Git should sort this out without issues when Linus merges -next; or
>> when we back-merge Linus' tree.
> 
> Yeah, looking at the doc, cherry-picking is the one encouraged, so
> feel free to cherry-pick them in drm-misc-fixes.

Ok, cherry-picked and pushed, thanks.

Regards,

Hans

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel