From mboxrd@z Thu Jan 1 00:00:00 1970 From: "james qian wang (Arm Technology China)" Subject: Re: [PATCH] drm/komeda: Added AFBC support for komeda driver Date: Mon, 27 May 2019 06:51:18 +0000 Message-ID: <20190527065110.GA29041@james-ThinkStation-P300> References: <20190404110552.15778-1-james.qian.wang@arm.com> <20190516135748.GC1372@arm.com> <20190521084552.GA20625@james-ThinkStation-P300> <20190524111009.beddu67vvx66wvmk@DESKTOP-E1NTVVP.localdomain> <20190524121226.GD5942@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50060.outbound.protection.outlook.com [40.107.5.60]) by gabe.freedesktop.org (Postfix) with ESMTPS id 481CD8966C for ; Mon, 27 May 2019 06:51:21 +0000 (UTC) In-Reply-To: <20190524121226.GD5942@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?iso-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: nd , "Tiannan Zhu (Arm Technology China)" , "airlied@linux.ie" , "Jonathan Chai (Arm Technology China)" , Liviu Dudau , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Julien Yin (Arm Technology China)" , Ayan Halder , "Yiqi Kang (Arm Technology China)" , "thomas Sun (Arm Technology China)" , "Lowry Li (Arm Technology China)" , "sean@poorly.run" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMjQsIDIwMTkgYXQgMDM6MTI6MjZQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgTWF5IDI0LCAyMDE5IGF0IDExOjEwOjA5QU0gKzAwMDAsIEJyaWFu IFN0YXJrZXkgd3JvdGU6Cj4gPiBIaSwKPiA+IAo+ID4gT24gVHVlLCBNYXkgMjEsIDIwMTkgYXQg MDk6NDU6NThBTSArMDEwMCwgamFtZXMgcWlhbiB3YW5nIChBcm0gVGVjaG5vbG9neSBDaGluYSkg d3JvdGU6Cj4gPiA+IE9uIFRodSwgTWF5IDE2LCAyMDE5IGF0IDA5OjU3OjQ5UE0gKzA4MDAsIEF5 YW4gSGFsZGVyIHdyb3RlOgo+ID4gPiA+IE9uIFRodSwgQXByIDA0LCAyMDE5IGF0IDEyOjA2OjE0 UE0gKzAxMDAsIGphbWVzIHFpYW4gd2FuZyAoQXJtIFRlY2hub2xvZ3kgQ2hpbmEpIHdyb3RlOgo+ ID4gPiA+ID4gIAo+ID4gPiA+ID4gK3N0YXRpYyBpbnQKPiA+ID4gPiA+ICtrb21lZGFfZmJfYWZi Y19zaXplX2NoZWNrKHN0cnVjdCBrb21lZGFfZmIgKmtmYiwgc3RydWN0IGRybV9maWxlICpmaWxl LAo+ID4gPiA+ID4gKwkJCSAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21k KQo+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSAm a2ZiLT5iYXNlOwo+ID4gPiA+ID4gKwljb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9pbmZvICppbmZv ID0gZmItPmZvcm1hdDsKPiA+ID4gPiA+ICsJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmo7Cj4g PiA+ID4gPiArCXUzMiBhbGlnbm1lbnRfdyA9IDAsIGFsaWdubWVudF9oID0gMCwgYWxpZ25tZW50 X2hlYWRlcjsKPiA+ID4gPiA+ICsJdTMyIG5fYmxvY2tzID0gMCwgbWluX3NpemUgPSAwOwo+ID4g PiA+ID4gKwo+ID4gPiA+ID4gKwlvYmogPSBkcm1fZ2VtX29iamVjdF9sb29rdXAoZmlsZSwgbW9k ZV9jbWQtPmhhbmRsZXNbMF0pOwo+ID4gPiA+ID4gKwlpZiAoIW9iaikgewo+ID4gPiA+ID4gKwkJ RFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGxvb2t1cCBHRU0gb2JqZWN0XG4iKTsKPiA+ID4gPiA+ ICsJCXJldHVybiAtRU5PRU5UOwo+ID4gPiA+ID4gKwl9Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiAr CXN3aXRjaCAoZmItPm1vZGlmaWVyICYgQUZCQ19GT1JNQVRfTU9EX0JMT0NLX1NJWkVfTUFTSykg ewo+ID4gPiA+ID4gKwljYXNlIEFGQkNfRk9STUFUX01PRF9CTE9DS19TSVpFXzMyeDg6Cj4gPiA+ ID4gPiArCQlhbGlnbm1lbnRfdyA9IDMyOwo+ID4gPiA+ID4gKwkJYWxpZ25tZW50X2ggPSA4Owo+ ID4gPiA+ID4gKwkJYnJlYWs7Cj4gPiA+ID4gPiArCWNhc2UgQUZCQ19GT1JNQVRfTU9EX0JMT0NL X1NJWkVfMTZ4MTY6Cj4gPiA+ID4gPiArCQlhbGlnbm1lbnRfdyA9IDE2Owo+ID4gPiA+ID4gKwkJ YWxpZ25tZW50X2ggPSAxNjsKPiA+ID4gPiA+ICsJCWJyZWFrOwo+ID4gPiA+ID4gKwlkZWZhdWx0 Ogo+ID4gPiA+IENhbiB3ZSBoYXZlIHNvbWV0aGluZyBsaWtlIGEgd2FybiBoZXJlID8KPiA+ID4g Cj4gPiA+IHdpbGwgYWRkIGEgV0FSTiBoZXJlLgo+ID4gPiAKPiA+IAo+ID4gSSB0aGluayBpdCdz IGJldHRlciBub3QgdG8uIGZiLT5tb2RpZmllciBjb21lcyBmcm9tCj4gPiB1c2Vyc3BhY2UsIHNv IGEgbWFsaWNpb3VzIGFwcCBjb3VsZCBzcGFtIHVzIHdpdGggV0FSTnMsIGVmZmVjdGl2ZWx5Cj4g PiBkb3MtaW5nIHRoZSBzeXN0ZW0uIC1FSU5WQUwgc2hvdWxkIGJlIHN1ZmZpY2llbnQuCj4gCj4g U2hvdWxkIHByb2JhYmx5IGNoZWNrIHRoYXQgdGhlIGVudGlyZSBtb2RpZmllcitmb3JtYXQgaXMK PiBhY3R1YWxseSB2YWxpZC4gT3RoZXJ3aXNlIHlvdSByaXNrIHBhc3Npbmcgb24gYSBib2d1cwo+ IG1vZGlmaWVyIGRlZXBlciBpbnRvIHRoZSBkcml2ZXIgd2hpY2ggbWF5IHRyaWdnZXIKPiBpbnRl cmVzdGluZyBidWdzLgo+IAo+IEFsc28gdGhlb3JldGljYWxseSAoaG93ZXZlciB1bmxpa2VseSkg c29tZSBicm9rZW4gdXNlcnNwYWNlCj4gbWlnaHQgc3RhcnQgdG8gZGVwZW5kIG9uIHRoZSBhYmls aXR5IHRvIGNyZWF0ZSBmcmFtZWJ1ZmZlcnMKPiB3aXRoIGNyYXAgbW9kaWZpZXJzLCB3aGljaCBj b3VsZCBsYXRlciBicmVhayBpZiB5b3UgY2hhbmdlCj4gdGhlIHdheSB5b3UgaGFuZGxlIHRoZSBt b2RpZmllcnMuIFRoZW4geW91J3JlIHN0dWNrIGJldHdlZW4KPiB0aGUgcm9jayBhbmQgaGFyZCBw bGFjZSBiZWNhdXNlIHlvdSBjYW4ndCBicmVhayBleGlzdGluZwo+IHVzZXJzcGFjZSBidXQgeW91 IHN0aWxsIHdhbnQgdG8gY2hhbmdlIHRoZSB3YXkgbW9kaWZpZXJzCj4gYXJlIGhhbmRsZWQgaW4g dGhlIGtlcm5lbC4KPiAKPiBCZXN0IG5vdCBnaXZlIHVzZXJzcGFjZSB0b28gbXVjaCByb3BlIElN Ty4gVHdvIHdheXMgdG8gZ28gYWJvdXQKPiB0aGF0Ogo+IDEpIGRybV9hbnlfcGxhbmVfaGFzX2Zv cm1hdCgpIChhc3N1bWVzIHlvdXIgLmZvcm1hdF9tb2Rfc3VwcG9ydGVkKCkKPiAgICBkb2VzIGl0 cyBqb2IgcHJvcGVybHkpCj4gMikgcm9sbCB5b3VyIG93biAKPiAKPiAtLSAKPiBWaWxsZSBTeXJq w6Rsw6QKPiBJbnRlbAoKSGkgQnJpYW4gJiBWaWxsZToKCmtvbWVkIGhhcyBhIGZvcm1hdCttb2Rp ZmllciBjaGVjayBiZWZvcmUgdGhlIGZiIHNpemUgY2hlY2suCmFuZCBmb3Iga29tZWRhX2ZiX2Ny ZWF0ZSwgdGhlIGZpcnN0IHN0ZXAgaXMgZG8gdGhlIGZvcm1hdCttb2RpZmllcgpjaGVjaywgdGhl IHNpemUgY2hlY2sgaXMgdGhlIGZ1cnRodXIgY2hlY2sgYWZ0ZXIgdGhlIHN1Y2ggZm9ybWF0CnZh bGlkIGNoZWNrLiBhbmQgdGhlIGRldGFpbGVkIGZiX2NyZWF0ZSBpcyBsaWtlOgoKc3RydWN0IGRy bV9mcmFtZWJ1ZmZlciAqCmtvbWVkYV9mYl9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg c3RydWN0IGRybV9maWxlICpmaWxlLAoJCSBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAq bW9kZV9jbWQpCnsKICAgICAgICAuLi4KICAgICAgICAvKiBTdGVwIDE6IGZvcm1hdCttb2RpZmll ciB2YWxpZCBjaGVjaywgaWYgaXQgY2FuIG5vdCBiZSBzdXBwb3J0LAogICAgICAgICAqIGdldF9m b3JtYXRfY2FwcyB3aWxsIHJldHVybiBhIE5VTEwgcHRyLgogICAgICAgICAqLwoJa2ZiLT5mb3Jt YXRfY2FwcyA9IGtvbWVkYV9nZXRfZm9ybWF0X2NhcHMoJm1kZXYtPmZtdF90YmwsCgkJCQkJCSAg bW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwKCQkJCQkJICBtb2RlX2NtZC0+bW9kaWZpZXJbMF0pOwoJ aWYgKCFrZmItPmZvcm1hdF9jYXBzKSB7CgkJRFJNX0RFQlVHX0tNUygiRk1UICV4IGlzIG5vdCBz dXBwb3J0ZWQuXG4iLAoJCQkgICAgICBtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0KTsKCQlrZnJlZShr ZmIpOwoJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwoJfQoKCWRybV9oZWxwZXJfbW9kZV9maWxs X2ZiX3N0cnVjdChkZXYsICZrZmItPmJhc2UsIG1vZGVfY21kKTsKCiAgICAgICAgLyogc3RlcCAy LCBkbyB0aGUgc2l6ZSBjaGVjayAqLwoJaWYgKGtmYi0+YmFzZS5tb2RpZmllcikKCQlyZXQgPSBr b21lZGFfZmJfYWZiY19zaXplX2NoZWNrKGtmYiwgZmlsZSwgbW9kZV9jbWQpOwoJZWxzZQoJCXJl dCA9IGtvbWVkYV9mYl9ub25lX2FmYmNfc2l6ZV9jaGVjayhtZGV2LCBrZmIsIGZpbGUsIG1vZGVf Y21kKTsKCWlmIChyZXQgPCAwKQoJCWdvdG8gZXJyX2NsZWFudXA7CgogICAgICAgIC4uLgp9CgpT byB0aGVvcmV0aWNhbGx5LCB0aGUgV0FSTiBpbiBzdGVwMiBpcyByZWR1bmRhbnQgaWYgZ2V0X2Zv cm1hdF9jYXBzCmZ1bmN0aW9uIGhhcyBubyBwcm9ibGVtLiA6KS4gdGhlIFdBUk4gaGVyZSBpcyBv bmx5IGZvciByZXBvcnRpbmcKdGhlIGtlcm5lbCBCVUcgb3IgY29kZSBpbmNvbnNpdGVudCB3aXRo IGZvcm1hdCBjYXBzIGNoZWNrIGFuZCB0aGUKZmIgc2l6ZSBjaGVjay4gQW5kIEkgYWdyZWUsIGJh c2ljYWxseSBpdCB3aWxsIG5vdCBoYXBwZW5lLgpAQnJpYW4sIEknbSBPayB0byByZW1vdmUgaXQu IDopCgpAVmlsbGU6CkJhc2ljYWxseSBrb21lZGEgZm9sbG93IHRoZSB3YXktMSwgYnV0IGEgbGl0 dGxlIGltcHJvdmVtZW50IGZvcgptYXRjaGluZyBrb21lZGEncyByZXF1aXJlbWVudC4gZm9yIGtv bWVkYSB3aGljaCB3aWxsIGRvIHR3byBsZXZlbCdzCmZvcm1hdCttb2RpZmllciBjaGVjay4KMSku IEluIGZiX2NyZWF0ZSwgQSByb3VnaGx5IGNoZWNrIHRvIHNlZSBpZiB0aGUgZm9ybWF0K21vZGlm aWVyIGNhbiBiZQogICAgc3VwcG9ydGVkIGJ5IGN1cnJlbnQgSFcuCjIpLiBJbiBwbGFuZV9hdG9t aWNfY2hlY2s6IHRvIHNlZSBpZiB0aGUgZm9ybWF0K21vZGlmaWVyIGNhbiBiZQogICAgc3VwcG9y dGVkIGZvciBhIHNwZWNpZmljIGxheWVyIGFuZCB3aXRoIGEgc3BlY2lmaWMgY29uZmlndXJhdGlv biAoUk9UKQoKVGhpcyBpcyBhIGZvcm1hdCB2YWxpZCBjaGVjayBleGFtcGxlIGZvciBwbGFuZV9j aGVjay4KaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoLzMwMTE0MC8/c2Vy aWVzPTU5NzQ3JnJldj0yCgpKYW1lcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw=