Re: [PATCH] drm/syncobj: Include the <drm/drm_utils.h> header

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, May 27, 2019 at 03:39:31PM -0300, Fabio Estevam wrote:
> The prototype for 'drm_timeout_abs_to_jiffies' is provided by
> the <drm/drm_utils.h> header.
> 
> Include this header to fix the following sparse warning:
> 
> drivers/gpu/drm/drm_syncobj.c:937:13: warning: symbol 'drm_timeout_abs_to_jiffies' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Uh I think this isn't quite what we want. There's both a drm_utils.h and a
drm_util.h and no drm_util.c and generally we try to match them all up.

I think drm_utils.h should disappear entirely, with
drm_get_panel_orientation_quirk moved to drm_panel.h (that's at least how
it's also grouped in the docs). And the drm_timeout_abs_to_jiffies helper
moved to drm_util.h, with it's implementation moved to a new drm_util.c

Plus I guess including all that into the a new kerneldoc section.

Assuming your up for a notch more cleanup than just shutting up sparse?

Thanks, Daniel

> ---
>  drivers/gpu/drm/drm_syncobj.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 3d400905100b..b06fa424bd44 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -46,6 +46,7 @@
>   * The file takes a reference on the kref.
>   */
>  
> +#include <drm/drm_utils.h>
>  #include <drm/drmP.h>
>  #include <linux/file.h>
>  #include <linux/fs.h>
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel