Re: [PATCH v3 4/4] drm/panfrost: Expose performance counters through unstable ioctls

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2321 bytes --]

Hi Boris,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc2 next-20190530]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-panfrost-Expose-perf-counters-to-userspace/20190531-020136
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu//drm/panfrost/panfrost_perfcnt.c: In function 'panfrost_ioctl_perfcnt_dump':
>> drivers/gpu//drm/panfrost/panfrost_perfcnt.c:224:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     void __user *user_ptr = (void __user *)req->buf_ptr;
                             ^

vim +224 drivers/gpu//drm/panfrost/panfrost_perfcnt.c

   217	
   218	int panfrost_ioctl_perfcnt_dump(struct drm_device *dev, void *data,
   219					struct drm_file *file_priv)
   220	{
   221		struct panfrost_device *pfdev = dev->dev_private;
   222		struct panfrost_perfcnt *perfcnt = pfdev->perfcnt;
   223		struct drm_panfrost_perfcnt_dump *req = data;
 > 224		void __user *user_ptr = (void __user *)req->buf_ptr;
   225		int ret;
   226	
   227		ret = panfrost_unstable_ioctl_check();
   228		if (ret)
   229			return ret;
   230	
   231		mutex_lock(&perfcnt->lock);
   232		if (perfcnt->user != file_priv->driver_priv) {
   233			ret = -EINVAL;
   234			goto out;
   235		}
   236	
   237		ret = panfrost_perfcnt_dump_locked(pfdev);
   238		if (ret)
   239			goto out;
   240	
   241		if (copy_to_user(user_ptr, perfcnt->buf, perfcnt->bosize))
   242			ret = -EFAULT;
   243	
   244	out:
   245		mutex_unlock(&perfcnt->lock);
   246	
   247		return ret;
   248	}
   249	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71023 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel