From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 05/11] mm/hmm: Remove duplicate condition test before wait_event_timeout Date: Fri, 7 Jun 2019 09:47:36 -0300 Message-ID: <20190607124736.GD14802@ziepe.ca> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-6-jgg@ziepe.ca> <86962e22-88b1-c1bf-d704-d5a5053fa100@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <86962e22-88b1-c1bf-d704-d5a5053fa100-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: John Hubbard Cc: Andrea Arcangeli , Ralph Campbell , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felix.Kuehling-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Jerome Glisse , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMDYsIDIwMTkgYXQgMDg6MDY6NTJQTSAtMDcwMCwgSm9obiBIdWJiYXJkIHdy b3RlOgo+IE9uIDYvNi8xOSAxMTo0NCBBTSwgSmFzb24gR3VudGhvcnBlIHdyb3RlOgo+ID4gRnJv bTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+ID4gCj4gPiBUaGUgd2FpdF9l dmVudF90aW1lb3V0IG1hY3JvIGFscmVhZHkgdGVzdHMgdGhlIGNvbmRpdGlvbiBhcyBpdHMgZmly c3QKPiA+IGFjdGlvbiwgc28gdGhlcmUgaXMgbm8gcmVhc29uIHRvIG9wZW4gY29kZSBhbm90aGVy IHZlcnNpb24gb2YgdGhpcywgYWxsCj4gPiB0aGF0IGRvZXMgaXMgc2tpcCB0aGUgbWlnaHRfc2xl ZXAoKSBkZWJ1Z2dpbmcgaW4gY29tbW9uIGNhc2VzLCB3aGljaCBpcwo+ID4gbm90IGhlbHBmdWwu Cj4gPiAKPiA+IEZ1cnRoZXIsIGJhc2VkIG9uIHByaW9yIHBhdGNoZXMsIHdlIGNhbiBubyBzaW1w bGlmeSB0aGUgcmVxdWlyZWQgY29uZGl0aW9uCj4gCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIm5vdyBzaW1wbGlmeSIKPiAKPiA+IHRlc3Q6Cj4gPiAgLSBJZiBy YW5nZSBpcyB2YWxpZCBtZW1vcnkgdGhlbiBzbyBpcyByYW5nZS0+aG1tCj4gPiAgLSBJZiBobW1f cmVsZWFzZSgpIGhhcyBydW4gdGhlbiByYW5nZS0+dmFsaWQgaXMgc2V0IHRvIGZhbHNlCj4gPiAg ICBhdCB0aGUgc2FtZSB0aW1lIGFzIGRlYWQsIHNvIG5vIHJlYXNvbiB0byBjaGVjayBib3RoLgo+ ID4gIC0gQSB2YWxpZCBobW0gaGFzIGEgdmFsaWQgaG1tLT5tbS4KPiA+IAo+ID4gQWxzbywgYWRk IHRoZSBSRUFEX09OQ0UgZm9yIHJhbmdlLT52YWxpZCBhcyB0aGVyZSBpcyBubyBsb2NrIGhlbGQg aGVyZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbWVsbGFu b3guY29tPgo+ID4gUmV2aWV3ZWQtYnk6IErDqXLDtG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQu Y29tPgo+ID4gIGluY2x1ZGUvbGludXgvaG1tLmggfCAxMiArKy0tLS0tLS0tLS0KPiA+ICAxIGZp bGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaG1tLmggYi9pbmNsdWRlL2xpbnV4L2htbS5oCj4gPiBp bmRleCA0ZWUzYWNhYmU1ZWQyMi4uMmFiMzViNDA5OTJiMjQgMTAwNjQ0Cj4gPiArKysgYi9pbmNs dWRlL2xpbnV4L2htbS5oCj4gPiBAQCAtMjE4LDE3ICsyMTgsOSBAQCBzdGF0aWMgaW5saW5lIHVu c2lnbmVkIGxvbmcgaG1tX3JhbmdlX3BhZ2Vfc2l6ZShjb25zdCBzdHJ1Y3QgaG1tX3JhbmdlICpy YW5nZSkKPiA+ICBzdGF0aWMgaW5saW5lIGJvb2wgaG1tX3JhbmdlX3dhaXRfdW50aWxfdmFsaWQo c3RydWN0IGhtbV9yYW5nZSAqcmFuZ2UsCj4gPiAgCQkJCQkgICAgICB1bnNpZ25lZCBsb25nIHRp bWVvdXQpCj4gPiAgewo+ID4gLQkvKiBDaGVjayBpZiBtbSBpcyBkZWFkID8gKi8KPiA+IC0JaWYg KHJhbmdlLT5obW0gPT0gTlVMTCB8fCByYW5nZS0+aG1tLT5kZWFkIHx8IHJhbmdlLT5obW0tPm1t ID09IE5VTEwpIHsKPiA+IC0JCXJhbmdlLT52YWxpZCA9IGZhbHNlOwo+ID4gLQkJcmV0dXJuIGZh bHNlOwo+ID4gLQl9Cj4gPiAtCWlmIChyYW5nZS0+dmFsaWQpCj4gPiAtCQlyZXR1cm4gdHJ1ZTsK PiA+IC0Jd2FpdF9ldmVudF90aW1lb3V0KHJhbmdlLT5obW0tPndxLCByYW5nZS0+dmFsaWQgfHwg cmFuZ2UtPmhtbS0+ZGVhZCwKPiA+ICsJd2FpdF9ldmVudF90aW1lb3V0KHJhbmdlLT5obW0tPndx LCByYW5nZS0+dmFsaWQsCj4gPiAgCQkJICAgbXNlY3NfdG9famlmZmllcyh0aW1lb3V0KSk7Cj4g PiAtCS8qIFJldHVybiBjdXJyZW50IHZhbGlkIHN0YXR1cyBqdXN0IGluIGNhc2Ugd2UgZ2V0IGx1 Y2t5ICovCj4gPiAtCXJldHVybiByYW5nZS0+dmFsaWQ7Cj4gPiArCXJldHVybiBSRUFEX09OQ0Uo cmFuZ2UtPnZhbGlkKTsKPiAKPiBKdXN0IHRvIGVuc3VyZSB0aGF0IEkgYWN0dWFsbHkgdW5kZXJz dGFuZCB0aGUgbW9kZWw6IEknbSBhc3N1bWluZyB0aGF0IHRoZSAKPiBSRUFEX09OQ0UgaXMgdGhl cmUgc29sZWx5IHRvIGVuc3VyZSB0aGF0IHJhbmdlLT52YWxpZCBpcyByZWFkICphZnRlciogdGhl Cj4gd2FpdF9ldmVudF90aW1lb3V0KCkgcmV0dXJucy4gSXMgdGhhdCBjb3JyZWN0PwoKTm8sIHdh aXRfZXZlbnRfdGltb3V0IGFscmVhZHkgaGFzIGludGVybmFsIGJhcnJpZXJzIHRoYXQgbWFrZSBz dXJlCnRoaW5ncyBkb24ndCBsZWFrIGFjcm9zcyBpdC4KClRoZSBSRUFEX09OQ0UgaXMgcmVxdWly ZWQgYW55IHRpbWUgYSB0aHJlYWQgaXMgcmVhZGluZyBhIHZhbHVlIHRoYXQKYW5vdGhlciB0aHJl YWQgY2FuIGJlIGNvbmN1cnJlbnRseSBjaGFuZ2luZyAtIGllIGluIHRoaXMgY2FzZSB0aGVyZSBp cwpubyBsb2NrIHByb3RlY3RpbmcgcmFuZ2UtPnZhbGlkIHNvIHRoZSB3cml0ZSBzaWRlIGNvdWxk IGJlIHJ1bm5pbmcuCgpXaXRob3V0IHRoZSBSRUFEX09OQ0UgdGhlIGNvbXBpbGVyIGlzIGFsbG93 ZWQgdG8gcmVhZCB0aGUgdmFsdWUgdHdpY2UKYW5kIGFzc3VtZSBpdCBnZXRzIHRoZSBzYW1lIHJl c3VsdCwgd2hpY2ggbWF5IG5vdCBiZSB0cnVlIHdpdGggYQpwYXJhbGxlbCB3cml0ZXIsIGFuZCB0 aHVzIG1heSBjb21wcm9taXNlIHRoZSBjb250cm9sIGZsb3cgaW4gc29tZQp1bmtub3duIHdheS4g CgpJdCBpcyBhbHNvIGdvb2QgZG9jdW1lbnRhdGlvbiBmb3IgdGhlIGxvY2tpbmcgc2NoZW1lIGlu IHVzZSBhcyBpdAptYXJrcyBzaGFyZWQgZGF0YSB0aGF0IGlzIG5vdCBiZWluZyBsb2NrZWQuCgpI b3dldmVyLCBub3cgdGhhdCBkZWFkIGlzIGdvbmUgd2UgY2FuIGp1c3Qgd3JpdGUgdGhlIGFib3Zl IG1vcmUgc2ltcGx5CmFzOgoKc3RhdGljIGlubGluZSBib29sIGhtbV9yYW5nZV93YWl0X3VudGls X3ZhbGlkKHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlLAoJCQkJCSAgICAgIHVuc2lnbmVkIGxvbmcg dGltZW91dCkKewoJcmV0dXJuIHdhaXRfZXZlbnRfdGltZW91dChyYW5nZS0+aG1tLT53cSwgcmFu Z2UtPnZhbGlkLAoJCQkJICBtc2Vjc190b19qaWZmaWVzKHRpbWVvdXQpKSAhPSAwOwp9CgpXaGlj aCByZWxpZXMgb24gdGhlIGludGVybmFsIGJhcnJpZXJzIG9mIHdhaXRfZXZlbnRfdGltZW91dCwg SSdsbCBmaXgKaXQgdXAuLgoKVGhhbmtzLApKYXNvbgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZng=