From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 11/11] mm/hmm: Remove confusing comment and logic from hmm_release Date: Fri, 7 Jun 2019 09:58:42 -0300 Message-ID: <20190607125842.GE14802@ziepe.ca> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-12-jgg@ziepe.ca> <3edc47bd-e8f6-0e65-5844-d16901890637@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <3edc47bd-e8f6-0e65-5844-d16901890637-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: John Hubbard Cc: Andrea Arcangeli , Ralph Campbell , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felix.Kuehling-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Jerome Glisse , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMDYsIDIwMTkgYXQgMDg6NDc6MjhQTSAtMDcwMCwgSm9obiBIdWJiYXJkIHdy b3RlOgo+IE9uIDYvNi8xOSAxMTo0NCBBTSwgSmFzb24gR3VudGhvcnBlIHdyb3RlOgo+ID4gRnJv bTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+ID4gCj4gPiBobW1fcmVsZWFz ZSgpIGlzIGNhbGxlZCBleGFjdGx5IG9uY2UgcGVyIGhtbS4gb3BzLT5yZWxlYXNlKCkgY2Fubm90 Cj4gPiBhY2NpZGVudGFsbHkgdHJpZ2dlciBhbnkgYWN0aW9uIHRoYXQgd291bGQgcmVjdXJzZSBi YWNrIG9udG8KPiA+IGhtbS0+bWlycm9yc19zZW0uCj4gPiAKPiA+IFRoaXMgZml4ZXMgYSB1c2Ug YWZ0ZXItZnJlZSByYWNlIG9mIHRoZSBmb3JtOgo+ID4gCj4gPiAgICAgICAgQ1BVMCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgQ1BVMQo+ID4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGhtbV9yZWxlYXNlKCkKPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVwX3dyaXRlKCZobW0tPm1pcnJvcnNfc2VtKTsK PiA+ICBobW1fbWlycm9yX3VucmVnaXN0ZXIobWlycm9yKQo+ID4gICBkb3duX3dyaXRlKCZobW0t Pm1pcnJvcnNfc2VtKTsKPiA+ICAgdXBfd3JpdGUoJmhtbS0+bWlycm9yc19zZW0pOwo+ID4gICBr ZnJlZShtaXJyb3IpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtaXJyb3ItPm9wcy0+cmVsZWFzZShtaXJyb3IpCj4gPiAKPiA+IFRoZSBvbmx5IHVzZXIg d2UgaGF2ZSB0b2RheSBmb3Igb3BzLT5yZWxlYXNlIGlzIGFuIGVtcHR5IGZ1bmN0aW9uLCBzbyB0 aGlzCj4gPiBpcyB1bmFtYmlndW91c2x5IHNhZmUuCj4gPiAKPiA+IEFzIGEgY29uc2VxdWVuY2Ug b2YgcGx1Z2dpbmcgdGhpcyByYWNlIGRyaXZlcnMgYXJlIG5vdCBhbGxvd2VkIHRvCj4gPiByZWdp c3Rlci91bnJlZ2lzdGVyIG1pcnJvcnMgZnJvbSB3aXRoaW4gYSByZWxlYXNlIG9wLgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gPiAg bW0vaG1tLmMgfCAyOCArKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNo YW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9tbS9obW0uYyBiL21tL2htbS5jCj4gPiBpbmRleCA3MDlkMTM4ZGQ0OTAyNy4uM2E0NWRk M2Q3NzgyNDggMTAwNjQ0Cj4gPiArKysgYi9tbS9obW0uYwo+ID4gQEAgLTEzNiwyNiArMTM2LDE2 IEBAIHN0YXRpYyB2b2lkIGhtbV9yZWxlYXNlKHN0cnVjdCBtbXVfbm90aWZpZXIgKm1uLCBzdHJ1 Y3QgbW1fc3RydWN0ICptbSkKPiA+ICAJV0FSTl9PTighbGlzdF9lbXB0eSgmaG1tLT5yYW5nZXMp KTsKPiA+ICAJbXV0ZXhfdW5sb2NrKCZobW0tPmxvY2spOwo+ID4gIAo+ID4gLQlkb3duX3dyaXRl KCZobW0tPm1pcnJvcnNfc2VtKTsKPiA+IC0JbWlycm9yID0gbGlzdF9maXJzdF9lbnRyeV9vcl9u dWxsKCZobW0tPm1pcnJvcnMsIHN0cnVjdCBobW1fbWlycm9yLAo+ID4gLQkJCQkJICBsaXN0KTsK PiA+IC0Jd2hpbGUgKG1pcnJvcikgewo+ID4gLQkJbGlzdF9kZWxfaW5pdCgmbWlycm9yLT5saXN0 KTsKPiA+IC0JCWlmIChtaXJyb3ItPm9wcy0+cmVsZWFzZSkgewo+ID4gLQkJCS8qCj4gPiAtCQkJ ICogRHJvcCBtaXJyb3JzX3NlbSBzbyB0aGUgcmVsZWFzZSBjYWxsYmFjayBjYW4gd2FpdAo+ID4g LQkJCSAqIG9uIGFueSBwZW5kaW5nIHdvcmsgdGhhdCBtaWdodCBpdHNlbGYgdHJpZ2dlciBhCj4g PiAtCQkJICogbW11X25vdGlmaWVyIGNhbGxiYWNrIGFuZCB0aHVzIHdvdWxkIGRlYWRsb2NrIHdp dGgKPiA+IC0JCQkgKiB1cy4KPiA+IC0JCQkgKi8KPiA+IC0JCQl1cF93cml0ZSgmaG1tLT5taXJy b3JzX3NlbSk7Cj4gPiArCWRvd25fcmVhZCgmaG1tLT5taXJyb3JzX3NlbSk7Cj4gCj4gVGhpcyBp cyBjbGVhbmVyIGFuZCBzaW1wbGVyLCBidXQgSSBzdXNwZWN0IGl0IGlzIGxlYWRpbmcgdG8gdGhl IGRlYWRsb2NrCj4gdGhhdCBSYWxwaCBDYW1wYmVsbCBpcyBzZWVpbmcgaW4gaGlzIGRyaXZlciB0 ZXN0aW5nLiAoQW5kIGluIGdlbmVyYWwsIGhvbGRpbmcKPiBhIGxvY2sgZHVyaW5nIGEgZHJpdmVy IGNhbGxiYWNrIHVzdWFsbHkgbGVhZHMgdG8gZGVhZGxvY2tzLikKCkkgdGhpbmsgUmFscGggaGFz IG5ldmVyIHNlZW4gdGhpcyBwYXRjaCAoaXQgaXMgbmV3KSwgc28gaXQgbXVzdCBiZSBvbmUKb2Yg dGhlIGVhcmxpZXIgcGF0Y2hlcy4uCgo+IFJhbHBoLCBpcyB0aGlzIHRoZSBvbmU/IEl0J3MgdGhl IG9ubHkgcGxhY2UgaW4gdGhpcyBwYXRjaHNldCB3aGVyZSBJIGNhbgo+IHNlZSBhIGxvY2sgYXJv dW5kIGEgY2FsbGJhY2sgdG8gZHJpdmVyIGNvZGUsIHRoYXQgd2Fzbid0IHRoZXJlIGJlZm9yZS4g U28KPiBJJ20gcHJldHR5IHN1cmUgaXQgaXMgdGhlIG9uZS4uLgoKQ2FuIHlvdSBzaGFyZSB0aGUg bG9ja2RlcCByZXBvcnQgcGxlYXNlPwoKVGhhbmtzLApKYXNvbgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2FtZC1nZng=