From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
Subject: Re: [PATCH v2 hmm 05/11] mm/hmm: Remove duplicate condition test
 before wait_event_timeout
Date: Fri, 7 Jun 2019 16:13:02 -0300
Message-ID: <20190607191302.GR14802@ziepe.ca>
References: <20190606184438.31646-1-jgg@ziepe.ca>
 <20190606184438.31646-6-jgg@ziepe.ca>
 <6833be96-12a3-1a1c-1514-c148ba2dd87b@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <6833be96-12a3-1a1c-1514-c148ba2dd87b-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Ralph Campbell <rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Andrea Arcangeli <aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, John Hubbard <jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Felix.Kuehling-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Jerome Glisse <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
List-Id: dri-devel@lists.freedesktop.org

T24gRnJpLCBKdW4gMDcsIDIwMTkgYXQgMTI6MDE6NDVQTSAtMDcwMCwgUmFscGggQ2FtcGJlbGwg
d3JvdGU6Cj4gCj4gT24gNi82LzE5IDExOjQ0IEFNLCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4g
PiBGcm9tOiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gPiAKPiA+IFRoZSB3
YWl0X2V2ZW50X3RpbWVvdXQgbWFjcm8gYWxyZWFkeSB0ZXN0cyB0aGUgY29uZGl0aW9uIGFzIGl0
cyBmaXJzdAo+ID4gYWN0aW9uLCBzbyB0aGVyZSBpcyBubyByZWFzb24gdG8gb3BlbiBjb2RlIGFu
b3RoZXIgdmVyc2lvbiBvZiB0aGlzLCBhbGwKPiA+IHRoYXQgZG9lcyBpcyBza2lwIHRoZSBtaWdo
dF9zbGVlcCgpIGRlYnVnZ2luZyBpbiBjb21tb24gY2FzZXMsIHdoaWNoIGlzCj4gPiBub3QgaGVs
cGZ1bC4KPiA+IAo+ID4gRnVydGhlciwgYmFzZWQgb24gcHJpb3IgcGF0Y2hlcywgd2UgY2FuIG5v
IHNpbXBsaWZ5IHRoZSByZXF1aXJlZCBjb25kaXRpb24KPiA+IHRlc3Q6Cj4gPiAgIC0gSWYgcmFu
Z2UgaXMgdmFsaWQgbWVtb3J5IHRoZW4gc28gaXMgcmFuZ2UtPmhtbQo+ID4gICAtIElmIGhtbV9y
ZWxlYXNlKCkgaGFzIHJ1biB0aGVuIHJhbmdlLT52YWxpZCBpcyBzZXQgdG8gZmFsc2UKPiA+ICAg
ICBhdCB0aGUgc2FtZSB0aW1lIGFzIGRlYWQsIHNvIG5vIHJlYXNvbiB0byBjaGVjayBib3RoLgo+
ID4gICAtIEEgdmFsaWQgaG1tIGhhcyBhIHZhbGlkIGhtbS0+bW0uCj4gPiAKPiA+IEFsc28sIGFk
ZCB0aGUgUkVBRF9PTkNFIGZvciByYW5nZS0+dmFsaWQgYXMgdGhlcmUgaXMgbm8gbG9jayBoZWxk
IGhlcmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEphc29uIEd1bnRob3JwZSA8amdnQG1lbGxh
bm94LmNvbT4KPiA+IFJldmlld2VkLWJ5OiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0
LmNvbT4KPiA+ICAgaW5jbHVkZS9saW51eC9obW0uaCB8IDEyICsrLS0tLS0tLS0tLQo+ID4gICAx
IGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+IAo+ID4g
ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaG1tLmggYi9pbmNsdWRlL2xpbnV4L2htbS5oCj4g
PiBpbmRleCA0ZWUzYWNhYmU1ZWQyMi4uMmFiMzViNDA5OTJiMjQgMTAwNjQ0Cj4gPiArKysgYi9p
bmNsdWRlL2xpbnV4L2htbS5oCj4gPiBAQCAtMjE4LDE3ICsyMTgsOSBAQCBzdGF0aWMgaW5saW5l
IHVuc2lnbmVkIGxvbmcgaG1tX3JhbmdlX3BhZ2Vfc2l6ZShjb25zdCBzdHJ1Y3QgaG1tX3Jhbmdl
ICpyYW5nZSkKPiA+ICAgc3RhdGljIGlubGluZSBib29sIGhtbV9yYW5nZV93YWl0X3VudGlsX3Zh
bGlkKHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlLAo+ID4gICAJCQkJCSAgICAgIHVuc2lnbmVkIGxv
bmcgdGltZW91dCkKPiA+ICAgewo+ID4gLQkvKiBDaGVjayBpZiBtbSBpcyBkZWFkID8gKi8KPiA+
IC0JaWYgKHJhbmdlLT5obW0gPT0gTlVMTCB8fCByYW5nZS0+aG1tLT5kZWFkIHx8IHJhbmdlLT5o
bW0tPm1tID09IE5VTEwpIHsKPiA+IC0JCXJhbmdlLT52YWxpZCA9IGZhbHNlOwo+ID4gLQkJcmV0
dXJuIGZhbHNlOwo+ID4gLQl9Cj4gPiAtCWlmIChyYW5nZS0+dmFsaWQpCj4gPiAtCQlyZXR1cm4g
dHJ1ZTsKPiA+IC0Jd2FpdF9ldmVudF90aW1lb3V0KHJhbmdlLT5obW0tPndxLCByYW5nZS0+dmFs
aWQgfHwgcmFuZ2UtPmhtbS0+ZGVhZCwKPiA+ICsJd2FpdF9ldmVudF90aW1lb3V0KHJhbmdlLT5o
bW0tPndxLCByYW5nZS0+dmFsaWQsCj4gPiAgIAkJCSAgIG1zZWNzX3RvX2ppZmZpZXModGltZW91
dCkpOwo+ID4gLQkvKiBSZXR1cm4gY3VycmVudCB2YWxpZCBzdGF0dXMganVzdCBpbiBjYXNlIHdl
IGdldCBsdWNreSAqLwo+ID4gLQlyZXR1cm4gcmFuZ2UtPnZhbGlkOwo+ID4gKwlyZXR1cm4gUkVB
RF9PTkNFKHJhbmdlLT52YWxpZCk7Cj4gPiAgIH0KPiA+ICAgLyoKPiA+IAo+IAo+IFNpbmNlIHdl
IGFyZSBzaW1wbGlmeWluZyB0aGluZ3MsIHBlcmhhcHMgd2Ugc2hvdWxkIGNvbnNpZGVyIG1lcmdp
bmcKPiBobW1fcmFuZ2Vfd2FpdF91bnRpbF92YWxpZCgpIGluZm8gaG1tX3JhbmdlX3JlZ2lzdGVy
KCkgYW5kCj4gcmVtb3ZpbmcgaG1tX3JhbmdlX3dhaXRfdW50aWxfdmFsaWQoKSBzaW5jZSB0aGUg
cGF0dGVybgo+IGlzIHRvIGFsd2F5cyBjYWxsIHRoZSB0d28gdG9nZXRoZXIuCgo/IHRoZSBobW0u
cnN0IHNob3dzIHRoZSBobW1fcmFuZ2Vfd2FpdF91bnRpbF92YWxpZCBiZWluZyBjYWxsZWQgaW4g
dGhlCihyZXQgPT0gLUVBR0FJTikgcGF0aC4gSXQgaXMgY29uZnVzaW5nIGJlY2F1c2UgaXQgc2hv
dWxkIHJlYWxseSBqdXN0CmhhdmUgdGhlIGFnYWluIGxhYmVsIG1vdmVkIHVwIGFib3ZlIGhtbV9y
YW5nZV93YWl0X3VudGlsX3ZhbGlkKCkgYXMKZXZlbiBpZiB3ZSBnZXQgdGhlIGRyaXZlciBsb2Nr
IGl0IGNvdWxkIHN0aWxsIGJlIGEgbG9uZyB3YWl0IGZvciB0aGUKY29sbGlkaW5nIGludmFsaWRh
dGlvbiB0byBjbGVhci4KCldoYXQgSSB3YW50IHRvIGdldCB0byBpcyBhIHBhdHRlcm4gbGlrZSB0
aGlzOgoKcGFnZWZhdWx0KCk6CgogICBobW1fcmFuZ2VfcmVnaXN0ZXIoJnJhbmdlKTsKYWdhaW46
CiAgIC8qIE9uIHRoZSBzbG93IHBhdGgsIGlmIHdlIGFwcGVhciB0byBiZSBsaXZlIGxvY2tlZCB0
aGVuIHdlIGdldAogICAgICB0aGUgd3JpdGUgc2lkZSBvZiBtbWFwX3NlbSB3aGljaCB3aWxsIGJy
ZWFrIHRoZSBsaXZlIGxvY2ssCiAgICAgIG90aGVyd2lzZSB0aGlzIGdldHMgdGhlIHJlYWQgbG9j
ayAqLwogICBpZiAoaG1tX3JhbmdlX3N0YXJ0X2FuZF9sb2NrKCZyYW5nZSkpCiAgICAgICAgIGdv
dG8gZXJyOwoKICAgbG9ja2RlcF9hc3NlcnRfaGVsZChyYW5nZS0+bW0tPm1tYXBfc2VtKTsKCiAg
IC8vIE9wdGlvbmFsOiBBdm9pZCB1c2VsZXNzIGV4cGVuc2l2ZSB3b3JrCiAgIGlmIChobW1fcmFu
Z2VfbmVlZHNfcmV0cnkoJnJhbmdlKSkKICAgICAgZ290byBhZ2FpbjsKICAgaG1tX3JhbmdlXyh0
b3VjaCB2bWFzKQoKICAgdGFrZV9sb2NrKGRyaXZlci0+dXBkYXRlKTsKICAgaWYgKGhtbV9yYW5n
ZV9lbmQoJnJhbmdlKSB7CiAgICAgICByZWxlYXNlX2xvY2soZHJpdmVyLT51cGRhdGUpOwogICAg
ICAgZ290byBhZ2FpbjsKICAgfQogICAvLyBGaW5pc2ggZHJpdmVyIHVwZGF0ZXMKICAgcmVsZWFz
ZV9sb2NrKGRyaXZlci0+dXBkYXRlKTsKCiAgIC8vIFJlbGVhc2VzIG1tYXBfc2VtCiAgIGhtbV9y
YW5nZV91bnJlZ2lzdGVyX2FuZF91bmxvY2soJnJhbmdlKTsKCldoYXQgZG8geW91IHRoaW5rPyAK
CklzIGl0IGNsZWFyPwoKSmFzb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt
Z2Z4