From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 05/11] mm/hmm: Remove duplicate condition test before wait_event_timeout Date: Fri, 7 Jun 2019 17:44:27 -0300 Message-ID: <20190607204427.GU14802@ziepe.ca> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-6-jgg@ziepe.ca> <6833be96-12a3-1a1c-1514-c148ba2dd87b@nvidia.com> <20190607191302.GR14802@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by gabe.freedesktop.org (Postfix) with ESMTPS id C72BB89157 for ; Fri, 7 Jun 2019 20:44:29 +0000 (UTC) Received: by mail-qk1-x741.google.com with SMTP id i125so2109529qkd.6 for ; Fri, 07 Jun 2019 13:44:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ralph Campbell Cc: Andrea Arcangeli , linux-rdma@vger.kernel.org, John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , amd-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMDcsIDIwMTkgYXQgMDE6MjE6MTJQTSAtMDcwMCwgUmFscGggQ2FtcGJlbGwg d3JvdGU6Cgo+ID4gV2hhdCBJIHdhbnQgdG8gZ2V0IHRvIGlzIGEgcGF0dGVybiBsaWtlIHRoaXM6 Cj4gPiAKPiA+IHBhZ2VmYXVsdCgpOgo+ID4gCj4gPiAgICAgaG1tX3JhbmdlX3JlZ2lzdGVyKCZy YW5nZSk7Cj4gPiBhZ2FpbjoKPiA+ICAgICAvKiBPbiB0aGUgc2xvdyBwYXRoLCBpZiB3ZSBhcHBl YXIgdG8gYmUgbGl2ZSBsb2NrZWQgdGhlbiB3ZSBnZXQKPiA+ICAgICAgICB0aGUgd3JpdGUgc2lk ZSBvZiBtbWFwX3NlbSB3aGljaCB3aWxsIGJyZWFrIHRoZSBsaXZlIGxvY2ssCj4gPiAgICAgICAg b3RoZXJ3aXNlIHRoaXMgZ2V0cyB0aGUgcmVhZCBsb2NrICovCj4gPiAgICAgaWYgKGhtbV9yYW5n ZV9zdGFydF9hbmRfbG9jaygmcmFuZ2UpKQo+ID4gICAgICAgICAgIGdvdG8gZXJyOwo+ID4gCj4g PiAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZChyYW5nZS0+bW0tPm1tYXBfc2VtKTsKPiA+IAo+ID4g ICAgIC8vIE9wdGlvbmFsOiBBdm9pZCB1c2VsZXNzIGV4cGVuc2l2ZSB3b3JrCj4gPiAgICAgaWYg KGhtbV9yYW5nZV9uZWVkc19yZXRyeSgmcmFuZ2UpKQo+ID4gICAgICAgIGdvdG8gYWdhaW47Cj4g PiAgICAgaG1tX3JhbmdlXyh0b3VjaCB2bWFzKQo+ID4gCj4gPiAgICAgdGFrZV9sb2NrKGRyaXZl ci0+dXBkYXRlKTsKPiA+ICAgICBpZiAoaG1tX3JhbmdlX2VuZCgmcmFuZ2UpIHsKPiA+ICAgICAg ICAgcmVsZWFzZV9sb2NrKGRyaXZlci0+dXBkYXRlKTsKPiA+ICAgICAgICAgZ290byBhZ2FpbjsK PiA+ICAgICB9Cj4gPiAgICAgLy8gRmluaXNoIGRyaXZlciB1cGRhdGVzCj4gPiAgICAgcmVsZWFz ZV9sb2NrKGRyaXZlci0+dXBkYXRlKTsKPiA+IAo+ID4gICAgIC8vIFJlbGVhc2VzIG1tYXBfc2Vt Cj4gPiAgICAgaG1tX3JhbmdlX3VucmVnaXN0ZXJfYW5kX3VubG9jaygmcmFuZ2UpOwo+ID4gCj4g PiBXaGF0IGRvIHlvdSB0aGluaz8KPiA+IAo+ID4gSXMgaXQgY2xlYXI/Cj4gPiAKPiA+IEphc29u Cj4gPiAKPiAKPiBBcmUgeW91IHRhbGtpbmcgYWJvdXQgYWNxdWlyaW5nIG1tYXBfc2VtIGluIGht bV9yYW5nZV9zdGFydF9hbmRfbG9jaygpPwo+IFVzdWFsbHksIHRoZSBmYXVsdCBjb2RlIGhhcyB0 byBsb2NrIG1tYXBfc2VtIGZvciByZWFkIGluIG9yZGVyIHRvCj4gY2FsbCBmaW5kX3ZtYSgpIHNv IGl0IGNhbiBzZXQgcmFuZ2Uudm1hLgoKPiBJZiBITU0gZHJvcHMgbW1hcF9zZW0gLSB3aGljaCBJ IGRvbid0IHRoaW5rIGl0IHNob3VsZCwganVzdCByZXR1cm4gYW4KPiBlcnJvciB0byB0ZWxsIHRo ZSBjYWxsZXIgdG8gZHJvcCBtbWFwX3NlbSBhbmQgcmV0cnkgLSB0aGUgZmluZF92bWEoKQo+IHdp bGwgbmVlZCB0byBiZSByZXBlYXRlZCBhcyB3ZWxsLgoKT3ZlcmFsbCBJIGRvbid0IHRoaW5rIGl0 IG1ha2VzIGEgbG90IG9mIHNlbnNlIHRvIHNsZWVwIGZvciByZXRyeSBpbgpobW1fcmFuZ2Vfc3Rh cnRfYW5kX2xvY2soKSB3aGlsZSBob2xkaW5nIG1tYXBfc2VtLiBJdCB3b3VsZCBiZSBiZXR0ZXIK dG8gZHJvcCB0aGF0IGxvY2ssIHNsZWVwLCB0aGVuIHJlLWFjcXVpcmUgaXQgYXMgcGFydCBvZiB0 aGUgaG1tIGxvZ2ljLgoKVGhlIGZpbmRfdm1hIHNob3VsZCBiZSBkb25lIGluc2lkZSB0aGUgY3Jp dGljYWwgc2VjdGlvbiBjcmVhdGVkIGJ5CmhtbV9yYW5nZV9zdGFydF9hbmRfbG9jaygpLCBub3Qg YmVmb3JlIGl0LiBJZiB3ZSBhcmUgcmV0cnlpbmcgdGhlbiB3ZQphbHJlYWR5IHNsZXB0IGFuZCB0 aGUgYWRkaXRpb25hbCBDUFUgY29zdCB0byByZXBlYXQgdGhlIGZpbmRfdm1hIGlzCmltbWF0ZXJp YWwsIElNSE8/CgpEbyB5b3Ugc2VlIGEgcmVhc29uIHdoeSB0aGUgZmluZF92bWEoKSBldmVyIG5l ZWRzIHRvIGJlIGJlZm9yZSB0aGUKJ2FnYWluJyBpbiBteSBhYm92ZSBleGFtcGxlPyByYW5nZS52 bWEgZG9lcyBub3QgbmVlZCB0byBiZSBzZXQgZm9yCnJhbmdlX3JlZ2lzdGVyLgoKPiBJJ20gYWxz byBub3Qgc3VyZSBhYm91dCBhY3F1aXJpbmcgdGhlIG1tYXBfc2VtIGZvciB3cml0ZSBhcyB3YXkg dG8KPiBtaXRpZ2F0ZSB0aHJhc2hpbmcuIEl0IHNlZW1zIHRvIG1lIHRoYXQgaWYgYSBkZXZpY2Ug YW5kIGEgQ1BVIGFyZQo+IGJvdGggZmF1bHRpbmcgb24gdGhlIHNhbWUgcGFnZSwKCk9uZSBvZiB0 aGUgcmVhc29ucyB0byBwcmVmZXIgdGhpcyBhcHByb2FjaCBpcyB0aGF0IGl0IG1lYW5zIHdlIGRv bid0Cm5lZWQgdG8ga2VlcCB0cmFjayBvZiB3aGljaCByYW5nZXMgd2UgYXJlIGZhdWx0aW5nLCBh bmQgaWYgdGhlcmUgaXMgYQpsb3Qgb2YgKnVucmVsYXRlZCogZmF1bHQgYWN0aXZpdHkgKHVubGlr ZWx5Pykgd2UgY2FuIHJlc29sdmUgaXQgdXNpbmcKbW1hcCBzZW0gaW5zdGVhZCBvZiB0aGlzIGVs YWJvcmF0ZSByYW5nZXMgc2NoZW1lIGFuZCByZWxhdGVkCmxvY2tpbmcuIAoKVGhpcyB3b3VsZCBy ZWR1Y2UgdGhlIG92ZXJhbGwgd29yayBpbiB0aGUgcGFnZSBmYXVsdCBhbmQKaW52YWxpZGF0ZV9z dGFydC9lbmQgcGF0aHMgZm9yIHRoZSBjb21tb24gdW5jb250ZW5kZWQgY2FzZXMuCgo+IHNvbWUg c29ydCBvZiBiYWNrb2ZmIGRlbGF5IGlzIG5lZWRlZCB0byBsZXQgb25lIHNpZGUgb3IgdGhlIG90 aGVyCj4gbWFrZSBzb21lIHByb2dyZXNzLgoKV2hhdCB0aGUgd3JpdGUgc2lkZSBvZiB0aGUgbW1h cF9zZW0gd291bGQgZG8gaXMgZm9yY2UgdGhlIENQVSBhbmQKZGV2aWNlIHRvIGNsZWFubHkgdGFr ZSB0dXJucy4gT25jZSB0aGUgZGV2aWNlIHBhZ2VzIGFyZSByZWdpc3RlcmVkCnVuZGVyIHRoZSB3 cml0ZSBzaWRlIHRoZSBDUFUgd2lsbCBoYXZlIHRvIHdhaXQgaW4gaW52YWxpZGF0ZV9zdGFydCBm b3IKdGhlIGRyaXZlciB0byBjb21wbGV0ZSBhIHNob290ZG93biwgdGhlbiB0aGUgd2hvbGUgdGhp bmcgc3RhcnRzIGFsbApvdmVyIGFnYWluLiAKCkl0IGlzIGNlcnRhaW5seSBpbWFnaW5hYmxlIHNv bWV0aGluZyBjb3VsZCBoYXZlIGEgJ21pbiBsaWZlJyB0aW1lciBmb3IKYSBkZXZpY2UgbWFwcGlu ZyBhbmQgaG9sZCBtbSBpbnZhbGlkYXRlX3N0YXJ0LCBhbmQgZGV2aWNlIHBhZ2VmYXVsdApmb3Ig dGhhdCBtaW4gdGltZSB0byBwcm9tb3RlIGJldHRlciBzaGFyaW5nLgoKQnV0LCBpZiB3ZSBkb24n dCB1c2UgdGhlIG1tYXBfc2VtIHRoZW4gd2UgY2FuIGxpdmVsb2NrIGFuZCB0aGUgZGV2aWNlCndp bGwgc2VlIGFuIHVucmVjb3ZlcmFibGUgZXJyb3IgZnJvbSB0aGUgdGltZW91dCB3aGljaCBtZWFu cyB3ZSBoYXZlCnJpc2sgdGhhdCB1bmRlciBsb2FkIHRoZSBzeXN0ZW0gd2lsbCBzaW1wbHkgb2Jz Y3VyZWx5IGZhaWwuIFRoaXMgc2VlbXMKdW5hY2NlcHRhYmxlIHRvIG1lLi4KClBhcnRpY3VsYXJs eSBzaW5jZSBmb3IgdGhlIE9EUCB1c2UgY2FzZSB0aGUgaXNzdWUgaXMgbm90IHRyYXNoaW5nCm1p Z3JhdGlvbiBhcyBhIEdQVSBtaWdodCBoYXZlLCBidXQgc2ltcGxlIHN5c3RlbSBzdGFiaWxpdHkg dW5kZXIgc3dhcApsb2FkLiBXZSBkbyBub3Qgd2FudCB0aGUgT0RQIHBhZ2VmYXVsdCB0byBwZXJt YW5lbnRseSBmYWlsIGR1ZSB0bwp0aW1lb3V0IGlmIHRoZSBWTUEgaXMgc3RpbGwgdmFsaWQuLgoK SmFzb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs