* [PATCH] drm: remove the newline for CRC source name.
@ 2019-06-07 21:38 Dingchen Zhang
2019-06-08 11:56 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Dingchen Zhang @ 2019-06-07 21:38 UTC (permalink / raw)
To: dri-devel; +Cc: Leo Li, Sam Ravnborg, Dingchen Zhang
userspace may transfer a newline, and this terminating newline
is replaced by a '\0' to avoid followup issues.
'n-1' is the index to replace the newline of CRC source name.
v2: update patch subject, body and format. (Sam)
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <Harry.Wentland@amd.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
---
drivers/gpu/drm/drm_debugfs_crc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
index 585169f0dcc5..dac267e840af 100644
--- a/drivers/gpu/drm/drm_debugfs_crc.c
+++ b/drivers/gpu/drm/drm_debugfs_crc.c
@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
if (IS_ERR(source))
return PTR_ERR(source);
- if (source[len] == '\n')
- source[len] = '\0';
+ if (source[len - 1] == '\n')
+ source[len - 1] = '\0';
ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
if (ret)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: remove the newline for CRC source name.
2019-06-07 21:38 [PATCH] drm: remove the newline for CRC source name Dingchen Zhang
@ 2019-06-08 11:56 ` Sam Ravnborg
2019-06-10 13:28 ` Zhang, Dingchen (David)
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2019-06-08 11:56 UTC (permalink / raw)
To: Dingchen Zhang; +Cc: Leo Li, dri-devel
Hi Dingchen.
Patch is much better now.
On Fri, Jun 07, 2019 at 05:38:17PM -0400, Dingchen Zhang wrote:
> userspace may transfer a newline, and this terminating newline
> is replaced by a '\0' to avoid followup issues.
>
> 'n-1' is the index to replace the newline of CRC source name.
I am a little confused where 'n' comes from here?
I you had written ' len - 1' then there was a clear connection to the
patch.
With this fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> v2: update patch subject, body and format. (Sam)
>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
> index 585169f0dcc5..dac267e840af 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
> if (IS_ERR(source))
> return PTR_ERR(source);
>
> - if (source[len] == '\n')
> - source[len] = '\0';
> + if (source[len - 1] == '\n')
> + source[len - 1] = '\0';
>
> ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
> if (ret)
> --
> 2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm: remove the newline for CRC source name.
2019-06-08 11:56 ` Sam Ravnborg
@ 2019-06-10 13:28 ` Zhang, Dingchen (David)
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Dingchen (David) @ 2019-06-10 13:28 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Li, Sun peng (Leo), dri-devel@lists.freedesktop.org
Hi Sam,
Thanks for the good catch. Actually it's a typo in email reply. It should be 'len - 1'.
Regards,
-----Original Message-----
From: Sam Ravnborg <sam@ravnborg.org>
Sent: Saturday, June 8, 2019 7:56 AM
To: Zhang, Dingchen (David) <Dingchen.Zhang@amd.com>
Cc: dri-devel@lists.freedesktop.org; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>
Subject: Re: [PATCH] drm: remove the newline for CRC source name.
Hi Dingchen.
Patch is much better now.
On Fri, Jun 07, 2019 at 05:38:17PM -0400, Dingchen Zhang wrote:
> userspace may transfer a newline, and this terminating newline is
> replaced by a '\0' to avoid followup issues.
>
> 'n-1' is the index to replace the newline of CRC source name.
I am a little confused where 'n' comes from here?
I you had written ' len - 1' then there was a clear connection to the patch.
With this fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> v2: update patch subject, body and format. (Sam)
>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c
> b/drivers/gpu/drm/drm_debugfs_crc.c
> index 585169f0dcc5..dac267e840af 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
> if (IS_ERR(source))
> return PTR_ERR(source);
>
> - if (source[len] == '\n')
> - source[len] = '\0';
> + if (source[len - 1] == '\n')
> + source[len - 1] = '\0';
>
> ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
> if (ret)
> --
> 2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm: remove the newline for CRC source name.
@ 2019-06-10 13:47 Dingchen Zhang
2019-06-10 15:48 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Dingchen Zhang @ 2019-06-10 13:47 UTC (permalink / raw)
To: dri-devel; +Cc: Leo Li, Sam Ravnborg, Dingchen Zhang
userspace may transfer a newline, and this terminating newline
is replaced by a '\0' to avoid followup issues.
'len-1' is the index to replace the newline of CRC source name.
v3: typo fix (Sam)
v2: update patch subject, body and format. (Sam)
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <Harry.Wentland@amd.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
---
drivers/gpu/drm/drm_debugfs_crc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
index 585169f0dcc5..dac267e840af 100644
--- a/drivers/gpu/drm/drm_debugfs_crc.c
+++ b/drivers/gpu/drm/drm_debugfs_crc.c
@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
if (IS_ERR(source))
return PTR_ERR(source);
- if (source[len] == '\n')
- source[len] = '\0';
+ if (source[len - 1] == '\n')
+ source[len - 1] = '\0';
ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
if (ret)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: remove the newline for CRC source name.
2019-06-10 13:47 Dingchen Zhang
@ 2019-06-10 15:48 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2019-06-10 15:48 UTC (permalink / raw)
To: Dingchen Zhang; +Cc: Leo Li, dri-devel
Hi Dingchen.
On Mon, Jun 10, 2019 at 09:47:51AM -0400, Dingchen Zhang wrote:
> userspace may transfer a newline, and this terminating newline
> is replaced by a '\0' to avoid followup issues.
>
> 'len-1' is the index to replace the newline of CRC source name.
>
> v3: typo fix (Sam)
>
> v2: update patch subject, body and format. (Sam)
>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Dingchen Zhang <dingchen.zhang@amd.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
> index 585169f0dcc5..dac267e840af 100644
> --- a/drivers/gpu/drm/drm_debugfs_crc.c
> +++ b/drivers/gpu/drm/drm_debugfs_crc.c
> @@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
> if (IS_ERR(source))
> return PTR_ERR(source);
>
> - if (source[len] == '\n')
> - source[len] = '\0';
> + if (source[len - 1] == '\n')
> + source[len - 1] = '\0';
>
> ret = crtc->funcs->verify_crc_source(crtc, source, &values_cnt);
> if (ret)
> --
> 2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-10 15:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-07 21:38 [PATCH] drm: remove the newline for CRC source name Dingchen Zhang
2019-06-08 11:56 ` Sam Ravnborg
2019-06-10 13:28 ` Zhang, Dingchen (David)
-- strict thread matches above, loose matches on Subject: below --
2019-06-10 13:47 Dingchen Zhang
2019-06-10 15:48 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).