From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 05/11] mm/hmm: Remove duplicate condition test before wait_event_timeout Date: Fri, 7 Jun 2019 22:47:20 -0300 Message-ID: <20190608014720.GC7844@ziepe.ca> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-6-jgg@ziepe.ca> <6833be96-12a3-1a1c-1514-c148ba2dd87b@nvidia.com> <20190607191302.GR14802@ziepe.ca> <20190607204427.GU14802@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52609891DA for ; Sat, 8 Jun 2019 01:47:22 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id g18so2460162qkl.3 for ; Fri, 07 Jun 2019 18:47:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ralph Campbell Cc: Andrea Arcangeli , linux-rdma@vger.kernel.org, John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , amd-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMDcsIDIwMTkgYXQgMDM6MTM6MDBQTSAtMDcwMCwgUmFscGggQ2FtcGJlbGwg d3JvdGU6Cj4gPiBEbyB5b3Ugc2VlIGEgcmVhc29uIHdoeSB0aGUgZmluZF92bWEoKSBldmVyIG5l ZWRzIHRvIGJlIGJlZm9yZSB0aGUKPiA+ICdhZ2FpbicgaW4gbXkgYWJvdmUgZXhhbXBsZT8gcmFu Z2Uudm1hIGRvZXMgbm90IG5lZWQgdG8gYmUgc2V0IGZvcgo+ID4gcmFuZ2VfcmVnaXN0ZXIuCj4g Cj4gWWVzLCBmb3IgdGhlIEdQVSBjYXNlLCB0aGVyZSBjYW4gYmUgbWFueSBmYXVsdHMgaW4gYW4g ZXZlbnQgcXVldWUKPiBhbmQgdGhlIGdvYWwgaXMgdG8gdHJ5IHRvIGhhbmRsZSBtb3JlIHRoYW4g b25lIHBhZ2UgYXQgYSB0aW1lLgo+IFRoZSB2bWEgaXMgbmVlZGVkIHRvIGxpbWl0IHRoZSBhbW91 bnQgb2YgY29hbGVzY2luZyBhbmQgY2hlY2tpbmcKPiBmb3IgcGFnZXMgdGhhdCBjb3VsZCBiZSBz cGVjdWxhdGl2ZWx5IG1pZ3JhdGVkIG9yIG1hcHBlZC4KCkknZCBuZWVkIHRvIHNlZSBhbiBhbGdv cml0aG0gc2tldGNoIHRvIHNlZSB3aGF0IHlvdSBhcmUgdGhpbmtpbmcuLgoKQnV0LCBJIGd1ZXNz IGEgZHJpdmVyIHdvdWxkIGhhdmUgZmlndXJlIG91dCBhIGxpc3Qgb2Ygd2hhdCB2aXJ0dWFsCnBh Z2VzIGl0IHdhbnRzIHRvIGZhdWx0IHVuZGVyIHRoZSBtbWFwIHNlbSAobWF5YmUgdXNlIGZpbmRf dmFtLCBldGMpLAp0aGVuIGRyb3AgbW1hcF9zZW0sIGFuZCBzdGFydCBwcm9jZXNzaW5nIHRob3Nl IHBhZ2VzIGZvciBtaXJyb3JpbmcKdW5kZXIgdGhlIGhtbSBzaWRlLgoKaWUgdGhleSBhcmUgdHdv IHNlcGVyYXRlIHVucmVsYXRlZCB0YXNrcy4KCkkgbG9va2VkIGF0IHRoZSBobW0ucnN0IGFnYWlu LCBhbmQgdGhhdCByZWZlcmVuY2UgYWxnb3JpdGhtIGlzIGFscmVhZHkKc2hvd2luZyB0aGF0IHRo YXQgdXBvbiByZXRyeSB0aGUgbW1hcF9zZW0gaXMgcmVsZWFzZWQ6CgogICAgICB0YWtlX2xvY2so ZHJpdmVyLT51cGRhdGUpOwogICAgICBpZiAoIXJhbmdlLnZhbGlkKSB7CiAgICAgICAgICByZWxl YXNlX2xvY2soZHJpdmVyLT51cGRhdGUpOwogICAgICAgICAgdXBfcmVhZCgmbW0tPm1tYXBfc2Vt KTsKICAgICAgICAgIGdvdG8gYWdhaW47CgpTbyBhIGRyaXZlciBjYW5ub3QgYXNzdW1lIHRoYXQg YW55IFZNQSByZWxhdGVkIHdvcmsgZG9uZSB1bmRlciB0aGUKbW1hcCBiZWZvcmUgdGhlIGhtbSAn Y3JpdGljYWwgc2VjdGlvbicgY2FuIGNhcnJ5IGludG8gdGhlIGhtbSBjcml0aWNhbApzZWN0aW9u IGFzIHRoZSBsb2NrIGNhbiBiZSByZWxlYXNlZCB1cG9uIHJldHJ5IGFuZCBpbnZhbGlkYXRlIGFs bCB0aGF0CmRhdGEuLgoKRm9yY2luZyB0aGUgaG1tX3JhbmdlX3N0YXJ0X2FuZF9sb2NrKCkgdG8g YWNxdWlyZSB0aGUgbW1hcF9zZW0gaXMgYQpyb3VnaCB3YXkgdG8gZm9yY2UgdGhlIGRyaXZlciBh dXRob3IgdG8gcmVhbGl6ZSB0aGVyZSBhcmUgdHdvIGxvY2tpbmcKZG9tYWlucyBhbmQgbG9jayBw cm90ZWN0ZWQgaW5mb3JtYXRpb24gY2Fubm90IGNyb3NzIGJldHdlZW4uCgo+IE9LLCBJIHVuZGVy c3RhbmQuCj4gSWYgeW91IGNvbWUgdXAgd2l0aCBhIHNldCBvZiBjaGFuZ2VzLCBJIGNhbiB0cnkg dGVzdGluZyB0aGVtLgoKVGhhbmtzLCBJIG1ha2UgYSBza2V0Y2ggb2YgdGhlIHBhdGNoLCBJIGhh dmUgdG8gZ2V0IGJhY2sgdG8gaXQgYWZ0ZXIKdGhpcyBzZXJpZXMgaXMgZG9uZS4KCkphc29uCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==