From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 01/11] mm/hmm: fix use after free with struct hmm in the mmu notifiers Date: Sat, 8 Jun 2019 08:33:05 -0300 Message-ID: <20190608113305.GA12419@ziepe.ca> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-2-jgg@ziepe.ca> <20190608084948.GA32185@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17E018920A for ; Sat, 8 Jun 2019 11:33:08 +0000 (UTC) Received: by mail-qt1-x843.google.com with SMTP id u12so5406201qth.3 for ; Sat, 08 Jun 2019 04:33:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190608084948.GA32185@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christoph Hellwig Cc: Andrea Arcangeli , Ralph Campbell , linux-rdma@vger.kernel.org, John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , amd-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBKdW4gMDgsIDIwMTkgYXQgMDE6NDk6NDhBTSAtMDcwMCwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4gSSBzdGlsbCB0aGluayBzcnVjdCBobW0gc2hvdWxkIGRpZS4gIFdlIGFscmVh ZHkgaGF2ZSBhIHN0cnVjdHVyZSB1c2VkCj4gZm9yIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24gZm9y IGRyaXZlcnMgaGF2aW5nIGNyYXpseSB0aWdodCBpbnRlZ3JhdGlvbgo+IGludG8gdGhlIFZNLCBh bmQgaXQgaXMgY2FsbGVkIHN0cnVjdCBtbXVfbm90aWZpZXJfbW0uICBXZSByZWFsbHkgbmVlZAo+ IHRvIHJldXNlIHRoYXQgaW50ZWFkIG9mIGR1cGxpY2F0aW5nIGl0IGJhZGx5LgoKUHJvYmFibHku IEJ1dCBhdCBsZWFzdCBpbiBPRFAgd2UgbmVlZGVkIHNvbWV0aGluZyB2ZXJ5IHNpbWlsYXIgdG8K J3N0cnVjdCBobW0nIHRvIG1ha2Ugb3VyIG1tdSBub3RpZmllciBpbXBsZW1lbnRhdGlvbiB3b3Jr LgoKVGhlIG1tdSBub3RpZmllciBhcGkgcmVhbGx5IGxlbmRzIGl0c2VsZiB0byBoYXZpbmcgYSBw ZXItbW0gc3RydWN0dXJlCmluIHRoZSBkcml2ZXIgdG8gaG9sZCB0aGUgJ3N0cnVjdCBtbXVfbm90 aWZpZXInLi4KCkkgdGhpbmsgSSBzZWUgb3RoZXIgZHJpdmVycyBhcmUgZG9pbmcgdGhpbmdzIGxp a2UgYXNzdW1pbmcgdGhhdCB0aGVyZQppcyBvbmx5IG9uZSBtbSBpbiB0aGVpciB3b3JsZCAoZGVz cGl0ZSBiZWluZyBGRCBiYXNlZCwgc28gdGhpcyBpcyBub3QKcmVhbGx5IGd1YXJlbnRlZWQpCgpT bywgbXkgZmlyc3QgYXR0ZW1wdCB3b3VsZCBiZSBhbiBhcGkgc29tZXRoaW5nIGxpa2U6CgogICBw cml2ID0gbW11X25vdGlmaWZlcl9hdHRhY2hfbW0ob3BzLCBjdXJyZW50LT5tbSwgc2l6ZW9mKG15 X3ByaXYpKQogICBtbXVfbm90aWZpZXJfZGV0YWNoX21tKHByaXYpOwoKIG9wcy0+aW52YWxpZGF0 ZV9zdGFydChzdHJ1Y3QgbW11X25vdGlmaWZlciAqbW4pOgogICBzdHJ1Y3QgcCAqcHJpdiA9IG1t dV9ub3RpZmllcl9wcml2KG1uKTsKClN1Y2ggdGhhdAogLSBUaGVyZSBpcyBvbmx5IG9uZSBwcml2 IHBlciBtbQogLSBBbGwgdGhlIHNyY3Ugc3R1ZmYgaXMgaGFuZGxlZCBpbnNpZGUgbW11IG5vdGlm aWVyCiAtIEl0IGlzIHJlZmVyZW5jZSBjb3VudGVkLCBzbyBvcHMgY2FuIGJlIGF0dGFjaGVkIG11 bHRpcGxlIHRpbWVzIHRvCiAgIHRoZSBzYW1lIG1tCgpUaGVuIG9kcCdzIHBlcl9tbSwgYW5kIHN0 cnVjdCBobW0gKGlmIHdlIGtlZXAgaXQgYXQgYWxsKSBpcyBzaW1wbHkgYQoncHJpdicgaW4gdGhl IGFib3ZlLgoKSSB3YXMgdGhpbmtpbmcgb2YgbG9va2luZyBhdCB0aGlzIHN0dWZmIG5leHQsIG9u Y2UgdGhpcyBzZXJpZXMgaXMKZG9uZS4KCkphc29uCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA==