From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: maxime.ripard@bootlin.com, dri-devel@lists.freedesktop.org,
kraxel@redhat.com, airlied@redhat.com, sean@poorly.run
Subject: Re: [PATCH v2 5/9] drm/ast: Pin framebuffer BO during dirty update
Date: Wed, 12 Jun 2019 09:48:26 +0200 [thread overview]
Message-ID: <20190612074826.GA31000@ravnborg.org> (raw)
In-Reply-To: <038d4a58-1980-3b76-ea53-9b354980723a@suse.de>
Hi Thomas.
> >
> > While touching this code, anyway we could get rid of drm_can_sleep()?
> > I only ask because Daniel V. said that we should not use it.
> > This was some months ago during some ehader file clean-up, so nothing
> > in particular related to the ast driver.
>
> I'm aware of what is commented in the header and the todo file. Do you
> have a link to this discussion?
I managed to dig up this link:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1887389.html
But that does not provide any additional technical details.
> In any case, I'd prefer to fix this in a separate patch set. I have
> patches that replace the ast and mgag200 fbdev consoles with generic
> code. That might be the right place.
Using generic code, and thus deleting the old code seems like a good
plan.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-12 7:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 13:03 [PATCH v2 0/9] Remove explicit locking and kmap arguments from GEM VRAM interface Thomas Zimmermann
2019-06-11 13:03 ` [PATCH v2 1/9] drm/gem-vram: Support pinning buffers to current location Thomas Zimmermann
2019-06-12 8:13 ` Gerd Hoffmann
2019-06-12 8:29 ` Thomas Zimmermann
2019-06-12 12:30 ` Gerd Hoffmann
2019-06-11 13:03 ` [PATCH v2 2/9] drm/ast: Unpin cursor BO during cleanup Thomas Zimmermann
2019-06-11 13:03 ` [PATCH v2 3/9] drm/ast: Remove obsolete or unused cursor state Thomas Zimmermann
2019-06-11 13:03 ` [PATCH v2 4/9] drm/ast: Pin and map cursor source BO during update Thomas Zimmermann
2019-06-12 8:15 ` Gerd Hoffmann
2019-06-11 13:03 ` [PATCH v2 5/9] drm/ast: Pin framebuffer BO during dirty update Thomas Zimmermann
2019-06-11 20:29 ` Sam Ravnborg
2019-06-12 7:35 ` Thomas Zimmermann
2019-06-12 7:48 ` Sam Ravnborg [this message]
2019-06-11 13:03 ` [PATCH v2 6/9] drm/mgag200: " Thomas Zimmermann
2019-06-11 13:03 ` [PATCH v2 7/9] drm/mgag200: Rewrite cursor handling Thomas Zimmermann
2019-06-12 8:17 ` Gerd Hoffmann
2019-06-11 13:03 ` [PATCH v2 8/9] drm: Remove lock interfaces from GEM VRAM helpers Thomas Zimmermann
2019-06-11 13:03 ` [PATCH v2 9/9] drm: Remove functions with kmap-object argument " Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612074826.GA31000@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox