From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCH] armada: no need to check return value of debugfs_create functions Date: Thu, 13 Jun 2019 15:36:00 +0100 Message-ID: <20190613143600.ldcqfw4s3t2pxh2y@shell.armlinux.org.uk> References: <20190613132850.GC4863@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A74889AB2 for ; Thu, 13 Jun 2019 14:36:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190613132850.GC4863@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgMDM6Mjg6NTBQTSArMDIwMCwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+IFdoZW4gY2FsbGluZyBkZWJ1Z2ZzIGZ1bmN0aW9ucywgdGhlcmUgaXMgbm8g bmVlZCB0byBldmVyIGNoZWNrIHRoZQo+IHJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4g d29yayBvciBub3QsIGJ1dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKPiBuZXZlciBkbyBzb21ldGhp bmcgZGlmZmVyZW50IGJhc2VkIG9uIHRoaXMuCgpQbGVhc2UgZG9uJ3QgbWVyZ2UgdGhpcyBwYXRj aCAtIEkgaGF2ZSBhIGNoYW5nZSB0aGF0IGNvbmZsaWN0cyB3aXRoIHRoaXMKd2hpY2ggc3dpdGNo ZXMgdXMgb3ZlciB0byB1c2luZyBkcm1fZGVidWdmc19jcmVhdGVfZmlsZXMoKSwgdGhlcmVieQpl bGltaW5hdGluZyB0aGlzIGNvZGUuCgo+IAo+IENjOiBSdXNzZWxsIEtpbmcgPGxpbnV4QGFybWxp bnV4Lm9yZy51az4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBs aW51eGZvdW5kYXRpb24ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFk YV9kZWJ1Z2ZzLmMgfCAxNCArKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNl cnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2FybWFkYS9hcm1hZGFfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1h ZGFfZGVidWdmcy5jCj4gaW5kZXggNjc1OGMzYTgzZGUyLi5hZWMxZTczNzIzNzEgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfZGVidWdmcy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfZGVidWdmcy5jCj4gQEAgLTEwOSw3ICsxMDksNiBA QCBzdGF0aWMgc3RydWN0IGRybV9pbmZvX2xpc3QgYXJtYWRhX2RlYnVnZnNfbGlzdFtdID0gewo+ ICAKPiAgaW50IGFybWFkYV9kcm1fZGVidWdmc19pbml0KHN0cnVjdCBkcm1fbWlub3IgKm1pbm9y KQo+ICB7Cj4gLQlzdHJ1Y3QgZGVudHJ5ICpkZTsKPiAgCWludCByZXQ7Cj4gIAo+ICAJcmV0ID0g ZHJtX2RlYnVnZnNfY3JlYXRlX2ZpbGVzKGFybWFkYV9kZWJ1Z2ZzX2xpc3QsCj4gQEAgLTExOCwx NSArMTE3LDEwIEBAIGludCBhcm1hZGFfZHJtX2RlYnVnZnNfaW5pdChzdHJ1Y3QgZHJtX21pbm9y ICptaW5vcikKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gLQlkZSA9IGRlYnVn ZnNfY3JlYXRlX2ZpbGUoInJlZyIsIFNfSUZSRUcgfCBTX0lSVVNSLAo+IC0JCQkJIG1pbm9yLT5k ZWJ1Z2ZzX3Jvb3QsIG1pbm9yLT5kZXYsICZmb3BzX3JlZ19yKTsKPiAtCWlmICghZGUpCj4gLQkJ cmV0dXJuIC1FTk9NRU07Cj4gLQo+IC0JZGUgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJyZWdfd3Ii LCBTX0lGUkVHIHwgU19JV1VTUiwKPiAtCQkJCSBtaW5vci0+ZGVidWdmc19yb290LCBtaW5vci0+ ZGV2LCAmZm9wc19yZWdfdyk7Cj4gLQlpZiAoIWRlKQo+IC0JCXJldHVybiAtRU5PTUVNOwo+ICsJ ZGVidWdmc19jcmVhdGVfZmlsZSgicmVnIiwgU19JRlJFRyB8IFNfSVJVU1IsIG1pbm9yLT5kZWJ1 Z2ZzX3Jvb3QsCj4gKwkJCSAgICBtaW5vci0+ZGV2LCAmZm9wc19yZWdfcik7Cj4gKwlkZWJ1Z2Zz X2NyZWF0ZV9maWxlKCJyZWdfd3IiLCBTX0lGUkVHIHwgU19JV1VTUiwgbWlub3ItPmRlYnVnZnNf cm9vdCwKPiArCQkJICAgIG1pbm9yLT5kZXYsICZmb3BzX3JlZ193KTsKPiAgCj4gIAlyZXR1cm4g MDsKPiAgfQo+IC0tIAo+IDIuMjIuMAo+IAo+IAoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0 cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRDIGJyb2FkYmFu ZCBmb3IgMC44bWlsZSBsaW5lIGluIHN1YnVyYmlhOiBzeW5jIGF0IDEyLjFNYnBzIGRvd24gNjIy a2JwcyB1cApBY2NvcmRpbmcgdG8gc3BlZWR0ZXN0Lm5ldDogMTEuOU1icHMgZG93biA1MDBrYnBz IHVwCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==