From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 8/9] drm: Remove lock interfaces from GEM VRAM helpers Date: Thu, 13 Jun 2019 18:34:42 +0200 Message-ID: <20190613163442.GQ23020@phenom.ffwll.local> References: <20190613073041.29350-1-tzimmermann@suse.de> <20190613073041.29350-9-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FE598925A for ; Thu, 13 Jun 2019 16:34:46 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id i11so4116466edq.0 for ; Thu, 13 Jun 2019 09:34:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190613073041.29350-9-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: maxime.ripard@bootlin.com, sam@ravnborg.org, dri-devel@lists.freedesktop.org, kraxel@redhat.com, airlied@redhat.com, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgMDk6MzA6NDBBTSArMDIwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gVGhlIGxvY2sgZnVuY3Rpb25zIGFuZCB0aGUgbG9ja2VkLXBpbi91bnBpbiBm dW5jdGlvbnMgb2YgR0VNIFZSQU0gYXJlIG5vdAo+IHJlcXVyaWVkIGFueSBsb25nZXIuIFJlbW92 ZSB0aGVtLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFu bkBzdXNlLmRlPgoKYnR3IGEgbmVhdCB0aGluZyB3ZSBjb3VsZCBkbyBmb3IgdGhlc2UgaGVscGVy cyB3b3VsZCBiZSB0byBpbnRlZ3JhdGUgdGhlbQptb3JlIHRpZ2hseSB3aXRoIHRoZSByZXNlcnZh dGlvbi9mZW5jZSBoZWxwZXJzIGluIGRybV9nZW0uaC4gQWxsIHRob3NlCnJlcXVpcmUgaXMgdGhh dCBnZW1fb2JqLT5yZXN2IGlzIHNldCBjb3JyZWN0bHksIHdoaWNoIGR1cGxpY2F0ZXMgdHRtJ3Mg b3duCnR0bV9idWZmZXJfb2JqZWN0LT5yZXN2LgoKSXQgaGluayB3ZSBjb3VsZCBhbHNvIHJlbW92 ZSB0dG1fYnVmZmVyX29iamVjdC0+dHRtX3Jlc3YgYW5kIHJlcXVpcmUgdGhhdAp5b3UgYWx3YXlz IHBhc3Mgb25lIGluIHdoZW4gY2FsbGluZyB0dG1fYm9faW5pdCwgYW5kIGdlbSBkcml2ZXJzIHdv dWxkCmp1c3QgdXNlIHRoZSBnZW1fb2JqZWN0LT5yZXN2IG9uZS4KCk9uZSBjb21wbGljYXRpb24g aXMgdGhhdCBmb3IgZG1hLWJ1ZiBleHBlY3Qgd2UgbmVlZCB0byBtYWtlIHN1cmUgd2UgcGljawp0 aGUgcmlnaHQgb25lLiBUaGVyZSdzIGtpbmRhIG5vIG5lYXQgd2F5IHRvIHNvbHZlIHRoYXQsIGV4 Y2VwdCBieSBqdXN0Cm1ha2luZyB0dG1fYnVmZmVyX29iamVjdCBhIGZ1bGwgc3ViY2xhc3Mgb2Yg ZHJtX2dlbV9vYmplY3QsIHdoaWNoIHByb2JhYmx5CndvdWxkbid0IGdvIGRvd24gdG9vIHdlbGwg SSB0aGluay4KCkp1c3QgYW4gYXNpZGUsIEknbSBkaWdnaW5nIGFyb3VuZCBpbiB0aGlzIGFyZWEg aW4gcmFkZW9uL2FtZGdwdS9ub3V2ZWF1CmNvZGUgcmlnaHQgbm93LgotRGFuaWVsCgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jIHwgMTA5IC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gIGluY2x1ZGUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuaCAgICAg fCAgIDUgLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3ZyYW1faGVscGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jCj4gaW5kZXggZjNlNTgwM2FmZmIwLi40Y2FlNTIw NTRlNjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3ZyYW1faGVscGVyLmMKPiBAQCAtMTUx LDM2ICsxNTEsNiBAQCB2b2lkIGRybV9nZW1fdnJhbV9wdXQoc3RydWN0IGRybV9nZW1fdnJhbV9v YmplY3QgKmdibykKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV9wdXQpOwo+ICAK PiAtLyoqCj4gLSAqIGRybV9nZW1fdnJhbV9sb2NrKCkgLSBMb2NrcyBhIFZSQU0tYmFja2VkIEdF TSBvYmplY3QKPiAtICogQGdibzoJdGhlIEdFTSBWUkFNIG9iamVjdAo+IC0gKiBAbm9fd2FpdDoJ ZG9uJ3Qgd2FpdCBmb3IgYnVmZmVyIG9iamVjdCB0byBiZWNvbWUgYXZhaWxhYmxlCj4gLSAqCj4g LSAqIFNlZSB0dG1fYm9fcmVzZXJ2ZSgpIGZvciBtb3JlIGluZm9ybWF0aW9uLgo+IC0gKgo+IC0g KiBSZXR1cm5zOgo+IC0gKiAwIG9uIHN1Y2Nlc3MsIG9yCj4gLSAqIGEgbmVnYXRpdmUgZXJyb3Ig Y29kZSBvdGhlcndpc2UKPiAtICovCj4gLWludCBkcm1fZ2VtX3ZyYW1fbG9jayhzdHJ1Y3QgZHJt X2dlbV92cmFtX29iamVjdCAqZ2JvLCBib29sIG5vX3dhaXQpCj4gLXsKPiAtCXJldHVybiB0dG1f Ym9fcmVzZXJ2ZSgmZ2JvLT5ibywgdHJ1ZSwgbm9fd2FpdCwgTlVMTCk7Cj4gLX0KPiAtRVhQT1JU X1NZTUJPTChkcm1fZ2VtX3ZyYW1fbG9jayk7Cj4gLQo+IC0vKioKPiAtICogZHJtX2dlbV92cmFt X3VubG9jaygpIC0gXAo+IC0JUmVsZWFzZSBhIHJlc2VydmF0aW9uIGFjcXVpcmVkIGJ5IGRybV9n ZW1fdnJhbV9sb2NrKCkKPiAtICogQGdibzoJdGhlIEdFTSBWUkFNIG9iamVjdAo+IC0gKgo+IC0g KiBTZWUgdHRtX2JvX3VucmVzZXJ2ZSgpIGZvciBtb3JlIGluZm9ybWF0aW9uLgo+IC0gKi8KPiAt dm9pZCBkcm1fZ2VtX3ZyYW1fdW5sb2NrKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8p Cj4gLXsKPiAtCXR0bV9ib191bnJlc2VydmUoJmdiby0+Ym8pOwo+IC19Cj4gLUVYUE9SVF9TWU1C T0woZHJtX2dlbV92cmFtX3VubG9jayk7Cj4gLQo+ICAvKioKPiAgICogZHJtX2dlbV92cmFtX21t YXBfb2Zmc2V0KCkgLSBSZXR1cm5zIGEgR0VNIFZSQU0gb2JqZWN0J3MgbW1hcCBvZmZzZXQKPiAg ICogQGdibzoJdGhlIEdFTSBWUkFNIG9iamVjdAo+IEBAIC0yNjYsNDkgKzIzNiw2IEBAIGludCBk cm1fZ2VtX3ZyYW1fcGluKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8sIHVuc2lnbmVk IGxvbmcgcGxfZmxhZykKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV9waW4pOwo+ ICAKPiAtLyoqCj4gLSAqIGRybV9nZW1fdnJhbV9waW5fbG9ja2VkKCkgLSBQaW5zIGEgR0VNIFZS QU0gb2JqZWN0IGluIGEgcmVnaW9uLgo+IC0gKiBAZ2JvOgl0aGUgR0VNIFZSQU0gb2JqZWN0Cj4g LSAqIEBwbF9mbGFnOglhIGJpdG1hc2sgb2YgcG9zc2libGUgbWVtb3J5IHJlZ2lvbnMKPiAtICoK PiAtICogUGlubmluZyBhIGJ1ZmZlciBvYmplY3QgZW5zdXJlcyB0aGF0IGl0IGlzIG5vdCBldmlj dGVkIGZyb20KPiAtICogYSBtZW1vcnkgcmVnaW9uLiBBIHBpbm5lZCBidWZmZXIgb2JqZWN0IGhh cyB0byBiZSB1bnBpbm5lZCBiZWZvcmUKPiAtICogaXQgY2FuIGJlIHBpbm5lZCB0byBhbm90aGVy IHJlZ2lvbi4KPiAtICoKPiAtICogVGhpcyBmdW5jdGlvbiBwaW5zIGEgR0VNIFZSQU0gb2JqZWN0 IHRoYXQgaGFzIGFscmVhZHkgYmVlbgo+IC0gKiBsb2NrZWQuIFVzZSBkcm1fZ2VtX3ZyYW1fcGlu KCkgaWYgcG9zc2libGUuCj4gLSAqCj4gLSAqIFJldHVybnM6Cj4gLSAqIDAgb24gc3VjY2Vzcywg b3IKPiAtICogYSBuZWdhdGl2ZSBlcnJvciBjb2RlIG90aGVyd2lzZS4KPiAtICovCj4gLWludCBk cm1fZ2VtX3ZyYW1fcGluX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2JvLAo+ IC0JCQkgICAgdW5zaWduZWQgbG9uZyBwbF9mbGFnKQo+IC17Cj4gLQlpbnQgaSwgcmV0Owo+IC0J c3RydWN0IHR0bV9vcGVyYXRpb25fY3R4IGN0eCA9IHsgZmFsc2UsIGZhbHNlIH07Cj4gLQo+IC0J bG9ja2RlcF9hc3NlcnRfaGVsZCgmZ2JvLT5iby5yZXN2LT5sb2NrLmJhc2UpOwo+IC0KPiAtCWlm IChnYm8tPnBpbl9jb3VudCkgewo+IC0JCSsrZ2JvLT5waW5fY291bnQ7Cj4gLQkJcmV0dXJuIDA7 Cj4gLQl9Cj4gLQo+IC0JZHJtX2dlbV92cmFtX3BsYWNlbWVudChnYm8sIHBsX2ZsYWcpOwo+IC0J Zm9yIChpID0gMDsgaSA8IGdiby0+cGxhY2VtZW50Lm51bV9wbGFjZW1lbnQ7ICsraSkKPiAtCQln Ym8tPnBsYWNlbWVudHNbaV0uZmxhZ3MgfD0gVFRNX1BMX0ZMQUdfTk9fRVZJQ1Q7Cj4gLQo+IC0J cmV0ID0gdHRtX2JvX3ZhbGlkYXRlKCZnYm8tPmJvLCAmZ2JvLT5wbGFjZW1lbnQsICZjdHgpOwo+ IC0JaWYgKHJldCA8IDApCj4gLQkJcmV0dXJuIHJldDsKPiAtCj4gLQlnYm8tPnBpbl9jb3VudCA9 IDE7Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gLX0KPiAtRVhQT1JUX1NZTUJPTChkcm1fZ2VtX3ZyYW1f cGluX2xvY2tlZCk7Cj4gLQo+ICAvKioKPiAgICogZHJtX2dlbV92cmFtX3VucGluKCkgLSBVbnBp bnMgYSBHRU0gVlJBTSBvYmplY3QKPiAgICogQGdibzoJdGhlIEdFTSBWUkFNIG9iamVjdAo+IEBA IC0zNTEsNDIgKzI3OCw2IEBAIGludCBkcm1fZ2VtX3ZyYW1fdW5waW4oc3RydWN0IGRybV9nZW1f dnJhbV9vYmplY3QgKmdibykKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV91bnBp bik7Cj4gIAo+IC0vKioKPiAtICogZHJtX2dlbV92cmFtX3VucGluX2xvY2tlZCgpIC0gVW5waW5z IGEgR0VNIFZSQU0gb2JqZWN0Cj4gLSAqIEBnYm86CXRoZSBHRU0gVlJBTSBvYmplY3QKPiAtICoK PiAtICogVGhpcyBmdW5jdGlvbiB1bnBpbnMgYSBHRU0gVlJBTSBvYmplY3QgdGhhdCBoYXMgYWxy ZWFkeSBiZWVuCj4gLSAqIGxvY2tlZC4gVXNlIGRybV9nZW1fdnJhbV91bnBpbigpIGlmIHBvc3Np YmxlLgo+IC0gKgo+IC0gKiBSZXR1cm5zOgo+IC0gKiAwIG9uIHN1Y2Nlc3MsIG9yCj4gLSAqIGEg bmVnYXRpdmUgZXJyb3IgY29kZSBvdGhlcndpc2UuCj4gLSAqLwo+IC1pbnQgZHJtX2dlbV92cmFt X3VucGluX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2JvKQo+IC17Cj4gLQlp bnQgaSwgcmV0Owo+IC0Jc3RydWN0IHR0bV9vcGVyYXRpb25fY3R4IGN0eCA9IHsgZmFsc2UsIGZh bHNlIH07Cj4gLQo+IC0JbG9ja2RlcF9hc3NlcnRfaGVsZCgmZ2JvLT5iby5yZXN2LT5sb2NrLmJh c2UpOwo+IC0KPiAtCWlmIChXQVJOX09OX09OQ0UoIWdiby0+cGluX2NvdW50KSkKPiAtCQlyZXR1 cm4gMDsKPiAtCj4gLQktLWdiby0+cGluX2NvdW50Owo+IC0JaWYgKGdiby0+cGluX2NvdW50KQo+ IC0JCXJldHVybiAwOwo+IC0KPiAtCWZvciAoaSA9IDA7IGkgPCBnYm8tPnBsYWNlbWVudC5udW1f cGxhY2VtZW50IDsgKytpKQo+IC0JCWdiby0+cGxhY2VtZW50c1tpXS5mbGFncyAmPSB+VFRNX1BM X0ZMQUdfTk9fRVZJQ1Q7Cj4gLQo+IC0JcmV0ID0gdHRtX2JvX3ZhbGlkYXRlKCZnYm8tPmJvLCAm Z2JvLT5wbGFjZW1lbnQsICZjdHgpOwo+IC0JaWYgKHJldCA8IDApCj4gLQkJcmV0dXJuIHJldDsK PiAtCj4gLQlyZXR1cm4gMDsKPiAtfQo+IC1FWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV91bnBp bl9sb2NrZWQpOwo+IC0KPiAgLyoqCj4gICAqIGRybV9nZW1fdnJhbV9rbWFwX2F0KCkgLSBNYXBz IGEgR0VNIFZSQU0gb2JqZWN0IGludG8ga2VybmVsIGFkZHJlc3Mgc3BhY2UKPiAgICogQGdibzoJ dGhlIEdFTSBWUkFNIG9iamVjdAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZ2VtX3Zy YW1faGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1fZ2VtX3ZyYW1faGVscGVyLmgKPiBpbmRleCA0 ZDFkMmMxYmYzMmIuLjFkNGFhODdmOGRmYSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1f Z2VtX3ZyYW1faGVscGVyLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fZ2VtX3ZyYW1faGVscGVy LmgKPiBAQCAtNzcsMTUgKzc3LDEwIEBAIHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpkcm1f Z2VtX3ZyYW1fY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkJCXVuc2lnbmVk IGxvbmcgcGdfYWxpZ24sCj4gIAkJCQkJCWJvb2wgaW50ZXJydXB0aWJsZSk7Cj4gIHZvaWQgZHJt X2dlbV92cmFtX3B1dChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2JvKTsKPiAtaW50IGRy bV9nZW1fdnJhbV9sb2NrKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8sIGJvb2wgbm9f d2FpdCk7Cj4gLXZvaWQgZHJtX2dlbV92cmFtX3VubG9jayhzdHJ1Y3QgZHJtX2dlbV92cmFtX29i amVjdCAqZ2JvKTsKPiAgdTY0IGRybV9nZW1fdnJhbV9tbWFwX29mZnNldChzdHJ1Y3QgZHJtX2dl bV92cmFtX29iamVjdCAqZ2JvKTsKPiAgczY0IGRybV9nZW1fdnJhbV9vZmZzZXQoc3RydWN0IGRy bV9nZW1fdnJhbV9vYmplY3QgKmdibyk7Cj4gIGludCBkcm1fZ2VtX3ZyYW1fcGluKHN0cnVjdCBk cm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8sIHVuc2lnbmVkIGxvbmcgcGxfZmxhZyk7Cj4gLWludCBk cm1fZ2VtX3ZyYW1fcGluX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2JvLAo+ IC0JCQkgICAgICB1bnNpZ25lZCBsb25nIHBsX2ZsYWcpOwo+ICBpbnQgZHJtX2dlbV92cmFtX3Vu cGluKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8pOwo+IC1pbnQgZHJtX2dlbV92cmFt X3VucGluX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2JvKTsKPiAgdm9pZCAq ZHJtX2dlbV92cmFtX2ttYXBfYXQoc3RydWN0IGRybV9nZW1fdnJhbV9vYmplY3QgKmdibywgYm9v bCBtYXAsCj4gIAkJCSAgIGJvb2wgKmlzX2lvbWVtLCBzdHJ1Y3QgdHRtX2JvX2ttYXBfb2JqICpr bWFwKTsKPiAgdm9pZCAqZHJtX2dlbV92cmFtX2ttYXAoc3RydWN0IGRybV9nZW1fdnJhbV9vYmpl Y3QgKmdibywgYm9vbCBtYXAsCj4gLS0gCj4gMi4yMS4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs