From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH v2] drm: return -EFAULT if copy_to_user() fails Date: Tue, 18 Jun 2019 16:18:43 +0300 Message-ID: <20190618131843.GA29463@mwanda> References: <20190618125623.GA24896@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06FBD6E17F for ; Tue, 18 Jun 2019 13:20:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190618125623.GA24896@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Al Viro Cc: Maxime Ripard , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org VGhlIGNvcHlfZnJvbV91c2VyKCkgZnVuY3Rpb24gcmV0dXJucyB0aGUgbnVtYmVyIG9mIGJ5dGVz IHJlbWFpbmluZwp0byBiZSBjb3BpZWQgYnV0IHdlIHdhbnQgdG8gcmV0dXJuIGEgbmVnYXRpdmUg ZXJyb3IgY29kZS4gIE90aGVyd2lzZQp0aGUgY2FsbGVycyB0cmVhdCBpdCBhcyBhIHN1Y2Nlc3Nm dWwgY29weS4KClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3Jh Y2xlLmNvbT4KLS0tCnYyOiBUaGUgZmlyc3QgdmVyc2lvbiB3YXMgbWlzc2luZyBhIGNodW5rCgog ZHJpdmVycy9ncHUvZHJtL2RybV9idWZzLmMgIHwgNSArKysrLQogZHJpdmVycy9ncHUvZHJtL2Ry bV9pb2MzMi5jIHwgNSArKysrLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9idWZzLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2J1ZnMuYwppbmRleCA2OGRhY2Y4NDIyYzYuLjhjZTlkNzNmYWI0 ZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9idWZzLmMKKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9idWZzLmMKQEAgLTEzNTEsNyArMTM1MSwxMCBAQCBzdGF0aWMgaW50IGNvcHlf b25lX2J1Zih2b2lkICpkYXRhLCBpbnQgY291bnQsIHN0cnVjdCBkcm1fYnVmX2VudHJ5ICpmcm9t KQogCQkJCSAuc2l6ZSA9IGZyb20tPmJ1Zl9zaXplLAogCQkJCSAubG93X21hcmsgPSBmcm9tLT5s b3dfbWFyaywKIAkJCQkgLmhpZ2hfbWFyayA9IGZyb20tPmhpZ2hfbWFya307Ci0JcmV0dXJuIGNv cHlfdG9fdXNlcih0bywgJnYsIG9mZnNldG9mKHN0cnVjdCBkcm1fYnVmX2Rlc2MsIGZsYWdzKSk7 CisKKwlpZiAoY29weV90b191c2VyKHRvLCAmdiwgb2Zmc2V0b2Yoc3RydWN0IGRybV9idWZfZGVz YywgZmxhZ3MpKSkKKwkJcmV0dXJuIC1FRkFVTFQ7CisJcmV0dXJuIDA7CiB9CiAKIGludCBkcm1f bGVnYWN5X2luZm9idWZzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCmRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2lvYzMyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2lvYzMyLmMKaW5kZXggNTg2YWEyODAyNGM1Li5hMTZiNmRjMmZhNDcgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1faW9jMzIuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lvYzMy LmMKQEAgLTM3OCw3ICszNzgsMTAgQEAgc3RhdGljIGludCBjb3B5X29uZV9idWYzMih2b2lkICpk YXRhLCBpbnQgY291bnQsIHN0cnVjdCBkcm1fYnVmX2VudHJ5ICpmcm9tKQogCQkJICAgICAgLnNp emUgPSBmcm9tLT5idWZfc2l6ZSwKIAkJCSAgICAgIC5sb3dfbWFyayA9IGZyb20tPmxvd19tYXJr LAogCQkJICAgICAgLmhpZ2hfbWFyayA9IGZyb20tPmhpZ2hfbWFya307Ci0JcmV0dXJuIGNvcHlf dG9fdXNlcih0byArIGNvdW50LCAmdiwgb2Zmc2V0b2YoZHJtX2J1Zl9kZXNjMzJfdCwgZmxhZ3Mp KTsKKworCWlmIChjb3B5X3RvX3VzZXIodG8gKyBjb3VudCwgJnYsIG9mZnNldG9mKGRybV9idWZf ZGVzYzMyX3QsIGZsYWdzKSkpCisJCXJldHVybiAtRUZBVUxUOworCXJldHVybiAwOwogfQogCiBz dGF0aWMgaW50IGRybV9sZWdhY3lfaW5mb2J1ZnMzMihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2 b2lkICpkYXRhLAotLSAKMi4yMC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw=