From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS Date: Tue, 18 Jun 2019 16:42:02 -0400 Message-ID: <20190618204202.GE25413@art_vandelay> References: <20190618202425.15259-1-robdclark@gmail.com> <20190618202425.15259-3-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3B396E245 for ; Tue, 18 Jun 2019 20:42:04 +0000 (UTC) Received: by mail-qt1-x843.google.com with SMTP id x2so17190138qtr.0 for ; Tue, 18 Jun 2019 13:42:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190618202425.15259-3-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: Rob Clark , freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Jayant Shekhar , Sean Paul , Abhinav Kumar , Sean Paul , Georgi Djakov , Sravanthi Kollukuduru List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDE6MjQ6MTBQTSAtMDcwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IEZyb206IEpheWFudCBTaGVraGFyIDxqc2hla2hhckBjb2RlYXVyb3JhLm9yZz4KPiAKPiBU aGUgaW50ZXJjb25uZWN0IGZyYW1ld29yayBpcyBkZXNpZ25lZCB0byBwcm92aWRlIGEKPiBzdGFu ZGFyZCBrZXJuZWwgaW50ZXJmYWNlIHRvIGNvbnRyb2wgdGhlIHNldHRpbmdzIG9mCj4gdGhlIGlu dGVyY29ubmVjdHMgb24gYSBTb0MuCj4gCj4gVGhlIGludGVyY29ubmVjdCBBUEkgdXNlcyBhIGNv bnN1bWVyL3Byb3ZpZGVyLWJhc2VkIG1vZGVsLAo+IHdoZXJlIHRoZSBwcm92aWRlcnMgYXJlIHRo ZSBpbnRlcmNvbm5lY3QgYnVzZXMgYW5kIHRoZQo+IGNvbnN1bWVycyBjb3VsZCBiZSB2YXJpb3Vz IGRyaXZlcnMuCj4gCj4gTURTUyBpcyBvbmUgb2YgdGhlIGludGVyY29ubmVjdCBjb25zdW1lcnMg d2hpY2ggdXNlcyB0aGUKPiBpbnRlcmNvbm5lY3QgQVBJcyB0byBnZXQgdGhlIHBhdGggYmV0d2Vl biBlbmRwb2ludHMgYW5kCj4gc2V0IGl0cyBiYW5kd2lkdGggcmVxdWlyZW1lbnQgZm9yIHRoZSBn aXZlbiBpbnRlcmNvbm5lY3RlZAo+IHBhdGguCj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAJLSBSZW1v dmUgZXJyb3IgbG9nIGFuZCB1bm5lY2Vzc2FyeSBjaGVjayAoSm9yZGFuIENyb3VzZSkKPiAKPiBD aGFuZ2VzIGluIHYzOgo+IAktIENvZGUgY2xlYW4gaW52b2x2aW5nIHZhcmlhYmxlIG5hbWUgY2hh bmdlLCByZW1vdmFsCj4gCSAgb2YgZXh0cmEgcGFyYW50aGVzaXMgYW5kIHZhcmlhYmxlcyAoTWF0 dGhpYXMgS2FlaGxja2UpCj4gCj4gQ2hhbmdlcyBpbiB2NDoKPiAJLSBBZGQgY29tbWVudHMsIHNw YWNpbmdzLCB0YWJzLCBwcm9wZXIgcG9ydCBuYW1lCj4gCSAgYW5kIGljYyBtYWNybyAoR2Vvcmdp IERqYWtvdikKPiAKPiBDaGFuZ2VzIGluIHY1Ogo+IAktIENvbW1pdCB0ZXh0IGFuZCBwYXJlbnRo ZXNpcyBhbGlnbm1lbnQgKEdlb3JnaSBEamFrb3YpCj4gCj4gQ2hhbmdlcyBpbiB2NjoKPiAJLSBD aGFuZ2UgdG8gbmV3IGljY19zZXQgQVBJJ3MgKERvdWcgQW5kZXJzb24pCj4gCj4gQ2hhbmdlcyBp biB2NzoKPiAJLSBGaXhlZCBhIHR5cG8KPiAKPiBDaGFuZ2VzIGluIHY4Ogo+IAktIEhhbmRsZSB0 aGUgb2ZfaWNjX2dldCgpIHJldHVybmluZyBOVUxMIGNhc2UuICBJbiBwcmFjdGljZQo+IAkgIGlj Y19zZXRfYncoKSB3aWxsIGdyYWNlZnVsbHkgaGFuZGxlIHRoZSBjYXNlIG9mIGEgTlVMTCBwYXRo LAo+IAkgIGJ1dCBpdCdzIHByb2JhYmx5IGJlc3QgZm9yIGNsYXJpdHkgdG8ga2VlcCBudW1fcGF0 aHM9MCBpbgo+IAkgIHRoaXMgY2FzZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTcmF2YW50aGkgS29s bHVrdWR1cnUgPHNrb2xsdWt1QGNvZGVhdXJvcmEub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEpheWFu dCBTaGVraGFyIDxqc2hla2hhckBjb2RlYXVyb3JhLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBSb2Ig Q2xhcmsgPHJvYmRjbGFya0BjaHJvbWl1bS5vcmc+Cj4gQWNrZWQtYnk6IEdlb3JnaSBEamFrb3Yg PGdlb3JnaS5kamFrb3ZAbGluYXJvLm9yZz4KClJldmlld2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5A cG9vcmx5LnJ1bj4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9t ZHNzLmMgfCA0OSArKysrKysrKysrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ1 IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9tZHNzLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp c3AvZHB1MS9kcHVfbWRzcy5jCj4gaW5kZXggNzMxNmI0YWIxYjg1Li5iMWQwNDM3YWM3YjYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X21kc3MuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9tZHNzLmMKPiBAQCAtNCwxMSAr NCwxNSBAQAo+ICAgKi8KPiAgCj4gICNpbmNsdWRlICJkcHVfa21zLmgiCj4gKyNpbmNsdWRlIDxs aW51eC9pbnRlcmNvbm5lY3QuaD4KPiAgCj4gICNkZWZpbmUgdG9fZHB1X21kc3MoeCkgY29udGFp bmVyX29mKHgsIHN0cnVjdCBkcHVfbWRzcywgYmFzZSkKPiAgCj4gICNkZWZpbmUgSFdfSU5UUl9T VEFUVVMJCQkweDAwMTAKPiAgCj4gKy8qIE1heCBCVyBkZWZpbmVkIGluIEtCcHMgKi8KPiArI2Rl ZmluZSBNQVhfQlcJCQkJNjgwMDAwMAo+ICsKPiAgc3RydWN0IGRwdV9pcnFfY29udHJvbGxlciB7 Cj4gIAl1bnNpZ25lZCBsb25nIGVuYWJsZWRfbWFzazsKPiAgCXN0cnVjdCBpcnFfZG9tYWluICpk b21haW47Cj4gQEAgLTIxLDggKzI1LDMwIEBAIHN0cnVjdCBkcHVfbWRzcyB7Cj4gIAl1MzIgaHd2 ZXJzaW9uOwo+ICAJc3RydWN0IGRzc19tb2R1bGVfcG93ZXIgbXA7Cj4gIAlzdHJ1Y3QgZHB1X2ly cV9jb250cm9sbGVyIGlycV9jb250cm9sbGVyOwo+ICsJc3RydWN0IGljY19wYXRoICpwYXRoWzJd Owo+ICsJdTMyIG51bV9wYXRoczsKPiAgfTsKPiAgCj4gK3N0YXRpYyBpbnQgZHB1X21kc3NfcGFy c2VfZGF0YV9idXNfaWNjX3BhdGgoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiArCQkJCQkJc3Ry dWN0IGRwdV9tZHNzICpkcHVfbWRzcykKPiArewo+ICsJc3RydWN0IGljY19wYXRoICpwYXRoMCA9 IG9mX2ljY19nZXQoZGV2LT5kZXYsICJtZHAwLW1lbSIpOwo+ICsJc3RydWN0IGljY19wYXRoICpw YXRoMSA9IG9mX2ljY19nZXQoZGV2LT5kZXYsICJtZHAxLW1lbSIpOwo+ICsKPiArCWlmIChJU19F UlJfT1JfTlVMTChwYXRoMCkpCj4gKwkJcmV0dXJuIFBUUl9FUlJfT1JfWkVSTyhwYXRoMCk7Cj4g Kwo+ICsJZHB1X21kc3MtPnBhdGhbMF0gPSBwYXRoMDsKPiArCWRwdV9tZHNzLT5udW1fcGF0aHMg PSAxOwo+ICsKPiArCWlmICghSVNfRVJSX09SX05VTEwocGF0aDEpKSB7Cj4gKwkJZHB1X21kc3Mt PnBhdGhbMV0gPSBwYXRoMTsKPiArCQlkcHVfbWRzcy0+bnVtX3BhdGhzKys7Cj4gKwl9Cj4gKwo+ ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIGRwdV9tZHNzX2lycShzdHJ1Y3Qg aXJxX2Rlc2MgKmRlc2MpCj4gIHsKPiAgCXN0cnVjdCBkcHVfbWRzcyAqZHB1X21kc3MgPSBpcnFf ZGVzY19nZXRfaGFuZGxlcl9kYXRhKGRlc2MpOwo+IEBAIC0xMzQsNyArMTYwLDExIEBAIHN0YXRp YyBpbnQgZHB1X21kc3NfZW5hYmxlKHN0cnVjdCBtc21fbWRzcyAqbWRzcykKPiAgewo+ICAJc3Ry dWN0IGRwdV9tZHNzICpkcHVfbWRzcyA9IHRvX2RwdV9tZHNzKG1kc3MpOwo+ICAJc3RydWN0IGRz c19tb2R1bGVfcG93ZXIgKm1wID0gJmRwdV9tZHNzLT5tcDsKPiAtCWludCByZXQ7Cj4gKwlpbnQg cmV0LCBpOwo+ICsJdTY0IGF2Z19idyA9IGRwdV9tZHNzLT5udW1fcGF0aHMgPyBNQVhfQlcgLyBk cHVfbWRzcy0+bnVtX3BhdGhzIDogMDsKPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgZHB1X21kc3Mt Pm51bV9wYXRoczsgaSsrKQo+ICsJCWljY19zZXRfYncoZHB1X21kc3MtPnBhdGhbaV0sIGF2Z19i dywga0Jwc190b19pY2MoTUFYX0JXKSk7Cj4gIAo+ICAJcmV0ID0gbXNtX2Rzc19lbmFibGVfY2xr KG1wLT5jbGtfY29uZmlnLCBtcC0+bnVtX2NsaywgdHJ1ZSk7Cj4gIAlpZiAocmV0KQo+IEBAIC0x NDcsMTIgKzE3NywxNSBAQCBzdGF0aWMgaW50IGRwdV9tZHNzX2Rpc2FibGUoc3RydWN0IG1zbV9t ZHNzICptZHNzKQo+ICB7Cj4gIAlzdHJ1Y3QgZHB1X21kc3MgKmRwdV9tZHNzID0gdG9fZHB1X21k c3MobWRzcyk7Cj4gIAlzdHJ1Y3QgZHNzX21vZHVsZV9wb3dlciAqbXAgPSAmZHB1X21kc3MtPm1w Owo+IC0JaW50IHJldDsKPiArCWludCByZXQsIGk7Cj4gIAo+ICAJcmV0ID0gbXNtX2Rzc19lbmFi bGVfY2xrKG1wLT5jbGtfY29uZmlnLCBtcC0+bnVtX2NsaywgZmFsc2UpOwo+ICAJaWYgKHJldCkK PiAgCQlEUFVfRVJST1IoImNsb2NrIGRpc2FibGUgZmFpbGVkLCByZXQ6JWRcbiIsIHJldCk7Cj4g IAo+ICsJZm9yIChpID0gMDsgaSA8IGRwdV9tZHNzLT5udW1fcGF0aHM7IGkrKykKPiArCQlpY2Nf c2V0X2J3KGRwdV9tZHNzLT5wYXRoW2ldLCAwLCAwKTsKPiArCj4gIAlyZXR1cm4gcmV0Owo+ICB9 Cj4gIAo+IEBAIC0xNjMsNiArMTk2LDcgQEAgc3RhdGljIHZvaWQgZHB1X21kc3NfZGVzdHJveShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJc3RydWN0IGRwdV9tZHNzICpkcHVfbWRzcyA9IHRv X2RwdV9tZHNzKHByaXYtPm1kc3MpOwo+ICAJc3RydWN0IGRzc19tb2R1bGVfcG93ZXIgKm1wID0g JmRwdV9tZHNzLT5tcDsKPiAgCWludCBpcnE7Cj4gKwlpbnQgaTsKPiAgCj4gIAlwbV9ydW50aW1l X3N1c3BlbmQoZGV2LT5kZXYpOwo+ICAJcG1fcnVudGltZV9kaXNhYmxlKGRldi0+ZGV2KTsKPiBA QCAtMTcyLDYgKzIwNiw5IEBAIHN0YXRpYyB2b2lkIGRwdV9tZHNzX2Rlc3Ryb3koc3RydWN0IGRy bV9kZXZpY2UgKmRldikKPiAgCW1zbV9kc3NfcHV0X2NsayhtcC0+Y2xrX2NvbmZpZywgbXAtPm51 bV9jbGspOwo+ICAJZGV2bV9rZnJlZSgmcGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gIAo+ ICsJZm9yIChpID0gMDsgaSA8IGRwdV9tZHNzLT5udW1fcGF0aHM7IGkrKykKPiArCQlpY2NfcHV0 KGRwdV9tZHNzLT5wYXRoW2ldKTsKPiArCj4gIAlpZiAoZHB1X21kc3MtPm1taW8pCj4gIAkJZGV2 bV9pb3VubWFwKCZwZGV2LT5kZXYsIGRwdV9tZHNzLT5tbWlvKTsKPiAgCWRwdV9tZHNzLT5tbWlv ID0gTlVMTDsKPiBAQCAtMjExLDYgKzI0OCwxMCBAQCBpbnQgZHB1X21kc3NfaW5pdChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KQo+ICAJfQo+ICAJZHB1X21kc3MtPm1taW9fbGVuID0gcmVzb3VyY2Vf c2l6ZShyZXMpOwo+ICAKPiArCXJldCA9IGRwdV9tZHNzX3BhcnNlX2RhdGFfYnVzX2ljY19wYXRo KGRldiwgZHB1X21kc3MpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiAgCW1w ID0gJmRwdV9tZHNzLT5tcDsKPiAgCXJldCA9IG1zbV9kc3NfcGFyc2VfY2xvY2socGRldiwgbXAp Owo+ICAJaWYgKHJldCkgewo+IEBAIC0yMzIsMTQgKzI3MywxNCBAQCBpbnQgZHB1X21kc3NfaW5p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJaXJxX3NldF9jaGFpbmVkX2hhbmRsZXJfYW5k X2RhdGEoaXJxLCBkcHVfbWRzc19pcnEsCj4gIAkJCQkJIGRwdV9tZHNzKTsKPiAgCj4gKwlwcml2 LT5tZHNzID0gJmRwdV9tZHNzLT5iYXNlOwo+ICsKPiAgCXBtX3J1bnRpbWVfZW5hYmxlKGRldi0+ ZGV2KTsKPiAgCj4gIAlwbV9ydW50aW1lX2dldF9zeW5jKGRldi0+ZGV2KTsKPiAgCWRwdV9tZHNz LT5od3ZlcnNpb24gPSByZWFkbF9yZWxheGVkKGRwdV9tZHNzLT5tbWlvKTsKPiAgCXBtX3J1bnRp bWVfcHV0X3N5bmMoZGV2LT5kZXYpOwo+ICAKPiAtCXByaXYtPm1kc3MgPSAmZHB1X21kc3MtPmJh c2U7Cj4gLQo+ICAJcmV0dXJuIHJldDsKPiAgCj4gIGlycV9lcnJvcjoKPiAtLSAKPiAyLjIwLjEK PiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBP UwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=