From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm: self_refresh: Fix a reversed condition in drm_self_refresh_helper_cleanup() Date: Wed, 19 Jun 2019 11:03:39 -0400 Message-ID: <20190619150339.GF25413@art_vandelay> References: <20190619100141.GA28596@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by gabe.freedesktop.org (Postfix) with ESMTPS id E109B6E42A for ; Wed, 19 Jun 2019 15:03:40 +0000 (UTC) Received: by mail-qt1-x842.google.com with SMTP id d17so15301127qtj.8 for ; Wed, 19 Jun 2019 08:03:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190619100141.GA28596@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: Maxime Ripard , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMTksIDIwMTkgYXQgMDE6MDE6NDFQTSArMDMwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBUaGlzIHRlc3QgaXMgZmxpcHBlZCBhcm91bmQgc28gaXQgZWl0aGVyIGxlYWRzIHRv IGEgbWVtb3J5IGxlYWsgb3IgYQo+IE5VTEwgZGVyZWZlcmVuY2UuCj4gCj4gRml4ZXM6IDE0NTJj MjViMGU2MCAoImRybTogQWRkIGhlbHBlcnMgdG8ga2ljayBvZmYgc2VsZiByZWZyZXNoIG1vZGUg aW4gZHJpdmVycyIpCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRl ckBvcmFjbGUuY29tPgoKVGhhbmtzIGZvciB0aGUgcGF0Y2ggYW5kIHlvdXIgYnVnIHJlcG9ydCEg SSd2ZSBhcHBsaWVkIHRoaXMgdG8gLW1pc2MtbmV4dCBhbmQKd2lsbCBkaWcgaW50byB0aGUgYnVn IHJlcG9ydCBzaG9ydGx5LgoKPiAtLS0KPiBJJ20gbm90IHRvdGFsbHkgc3VyZSB3aGF0IHRoZSBw cmVmZXJlZCBwYXRjaCBwcmVmaXggZm9yIHRoaXMgY29kZS4gIE9uZQo+IHRoaW5nIHRoYXQgd291 bGQgaGVscCBpcyB3aGVuIHdlJ3JlIGFkZGluZyBuZXcgZmlsZXMgd2Ugc2hvdWxkIHNwZWNpZnkK PiB0aGUgcHJlZml4IHRoYXQgdGhleSdyZSBnb2luZyB0byB1c2U6Cj4gCj4gLSBkcm06IEFkZCBo ZWxwZXJzIHRvIGtpY2sgb2ZmIHNlbGYgcmVmcmVzaCBtb2RlIGluIGRyaXZlcnMKPiArIGRybTog cmVmcmVzaCBtb2RlOiBBZGQgaGVscGVycyB0byBraWNrIG9mZiBzZWxmIHJlZnJlc2ggbW9kZSBp biBkcml2ZXJzCj4gCj4gSXQncyBhIHNtYWxsIHRoaW5nIGFuZCBlbWFpbCBhbHdheXMgc291bmRz IHdoaW55IGJ1dCBJJ20gc2VuZGluZyB0aGlzCj4gc3VnZ2VzdGlvbiB0byBldmVyeW9uZSB0b2Rh eSBzby4uLgoKVGhlcmUncyBubyBoYXJkIHJ1bGUuIEZvciBkcml2ZXJzIHdlIHVzZSBkcm0vPGRy aXZlcj4sIGFuZCBmb3IgY29yZSBwZW9wbGUKdXNlIGRybSBvciBkcm0vPGZpbGU+LgoKPiAKPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9zZWxmX3JlZnJlc2hfaGVscGVyLmMgfCAyICstCj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX3NlbGZfcmVmcmVzaF9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fc2VsZl9yZWZyZXNoX2hlbHBlci5jCj4gaW5kZXggMmIzZGFhZjc3ODQxLi5lMGQy YWQxZjA3MGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9zZWxmX3JlZnJlc2hf aGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3NlbGZfcmVmcmVzaF9oZWxwZXIu Ywo+IEBAIC0yMDUsNyArMjA1LDcgQEAgdm9pZCBkcm1fc2VsZl9yZWZyZXNoX2hlbHBlcl9jbGVh bnVwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCXN0cnVjdCBkcm1fc2VsZl9yZWZyZXNoX2Rh dGEgKnNyX2RhdGEgPSBjcnRjLT5zZWxmX3JlZnJlc2hfZGF0YTsKPiAgCj4gIAkvKiBIZWxwZXIg aXMgYWxyZWFkeSB1bmluaXRpYWxpemVkICovCj4gLQlpZiAoc3JfZGF0YSkKPiArCWlmICghc3Jf ZGF0YSkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJY3J0Yy0+c2VsZl9yZWZyZXNoX2RhdGEgPSBOVUxM Owo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2ds ZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbA==