From: Sam Ravnborg <sam@ravnborg.org>
To: Inki Dae <daeinki@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
Jingoo Han <jingoohan1@gmail.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/1] drm/exynos: drop drmP.h usage
Date: Fri, 21 Jun 2019 13:05:18 +0200 [thread overview]
Message-ID: <20190621110518.GA6772@ravnborg.org> (raw)
In-Reply-To: <CAAQKjZMt4FOss298fLrjxfRBm8tGypQHi9efQk21g74Xu0L9CQ@mail.gmail.com>
Hi Inki.
> --- snip ---
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > index c20b3a759370..ff9342737a51 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> > @@ -7,21 +7,21 @@
> > * published by the Free Software Foundationr
> > */
> >
> > -#include <linux/kernel.h>
> > #include <linux/clk.h>
> > #include <linux/component.h>
> > +#include <linux/dma-mapping.h>
> > #include <linux/err.h>
> > #include <linux/interrupt.h>
> > #include <linux/io.h>
> > +#include <linux/kernel.h>
> > +#include <linux/of.h>
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> > #include <linux/slab.h>
> > #include <linux/workqueue.h>
> > -#include <linux/dma-mapping.h>
> > -#include <linux/of.h>
> >
> > -#include <drm/drmP.h>
> > #include <drm/exynos_drm.h>
> > +
>
> With this patch, many build errors happen.
>
> Seems you missed to include below header files,
> <linux/uaccess.h>
> <linux/delay.h>
> <drm/drm_file.h>
Thanks for testing, glad this was catched before it hit drm-misc.
I will try to reproduce and get back if I fails to do so.
Smells like I failed to apply some local changes or something.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-06-21 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 8:35 [PATCH v2 0/1] drm/exynos: drop use of drmP.h Sam Ravnborg
2019-06-08 8:35 ` [PATCH v2 1/1] drm/exynos: drop drmP.h usage Sam Ravnborg
2019-06-21 10:46 ` Inki Dae
2019-06-21 11:05 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621110518.GA6772@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daeinki@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox