From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 4/4] drm/imx: only send event on crtc disable if kept disabled Date: Tue, 25 Jun 2019 22:22:44 +0200 Message-ID: <20190625202244.GG12905@phenom.ffwll.local> References: <6599f538740632c5524bab86514b8ba026798537.1561483965.git.bob.beckett@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6599f538740632c5524bab86514b8ba026798537.1561483965.git.bob.beckett@collabora.com> Sender: linux-kernel-owner@vger.kernel.org To: Robert Beckett Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 25, 2019 at 06:59:15PM +0100, Robert Beckett wrote: > The event will be sent as part of the vblank enable during the modeset > if the crtc is not being kept disabled. > > Fixes: 5f2f911578fb ("drm/imx: atomic phase 3 step 1: Use atomic configuration") > > Signed-off-by: Robert Beckett Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c > index e04d6efff1b5..c436a28d50e4 100644 > --- a/drivers/gpu/drm/imx/ipuv3-crtc.c > +++ b/drivers/gpu/drm/imx/ipuv3-crtc.c > @@ -94,7 +94,7 @@ static void ipu_crtc_atomic_disable(struct drm_crtc *crtc, > drm_crtc_vblank_off(crtc); > > spin_lock_irq(&crtc->dev->event_lock); > - if (crtc->state->event) { > + if (crtc->state->event && !crtc->state->active) { > drm_crtc_send_vblank_event(crtc, crtc->state->event); > crtc->state->event = NULL; > } > -- > 2.18.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch