From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: maxime.ripard@bootlin.com, sam@ravnborg.org,
dri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com,
kong.kongxinwei@hisilicon.com, kraxel@redhat.com,
puck.chen@hisilicon.com, zourongrong@gmail.com,
airlied@redhat.com, sean@poorly.run
Subject: Re: [PATCH 3/4] drm/hibmc: Leave struct drm_driver.gem_free_object_unlocked to NULL
Date: Fri, 28 Jun 2019 18:55:29 +0200 [thread overview]
Message-ID: <20190628165529.GU12905@phenom.ffwll.local> (raw)
In-Reply-To: <20190628122659.31887-4-tzimmermann@suse.de>
On Fri, Jun 28, 2019 at 02:26:58PM +0200, Thomas Zimmermann wrote:
> The GEM object's free function is now called through
> struct drm_gem_object_funcs.free.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index ce89e56937b0..0efccf365101 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -51,8 +51,6 @@ static struct drm_driver hibmc_driver = {
> .desc = "hibmc drm driver",
> .major = 1,
> .minor = 0,
> - .gem_free_object_unlocked =
> - drm_gem_vram_driver_gem_free_object_unlocked,
> .dumb_create = hibmc_dumb_create,
> .dumb_map_offset = drm_gem_vram_driver_dumb_mmap_offset,
This one looks like it could removed too? And then you can ditch the
EXPORT_SYMBOL and kerneldoc for that one too I think. Anyway good
follow-up. On the series:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
But it's too hot here, so maybe only count that as an ack :-)
Cheers, Daniel
> .irq_handler = hibmc_drm_interrupt,
> --
> 2.21.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-28 16:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:26 [PATCH 0/4] Convert VRAM helpers to GEM object functions Thomas Zimmermann
2019-06-28 12:26 ` [PATCH 1/4] drm/vram: Set GEM object functions for PRIME Thomas Zimmermann
2019-07-01 6:32 ` Gerd Hoffmann
2019-07-01 7:28 ` Thomas Zimmermann
2019-07-01 8:48 ` Gerd Hoffmann
2019-07-01 14:45 ` Thomas Zimmermann
2019-07-02 5:44 ` Gerd Hoffmann
2019-06-28 12:26 ` [PATCH 2/4] drm/bochs: Remove PRIME helpers from driver structure Thomas Zimmermann
2019-06-28 12:26 ` [PATCH 3/4] drm/hibmc: Leave struct drm_driver.gem_free_object_unlocked to NULL Thomas Zimmermann
2019-06-28 16:55 ` Daniel Vetter [this message]
2019-07-02 8:03 ` Thomas Zimmermann
2019-06-28 12:26 ` [PATCH 4/4] drm/vram: Remove driver callback functions for PRIME Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628165529.GU12905@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=maxime.ripard@bootlin.com \
--cc=puck.chen@hisilicon.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox