From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <abhinavk@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Jayant Shekhar <jshekhar@codeaurora.org>,
Sean Paul <sean@poorly.run>,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] drm/msm/dpu: remove dpu_mdss:hwversion
Date: Sun, 30 Jun 2019 06:14:42 -0700 [thread overview]
Message-ID: <20190630131445.25712-3-robdclark@gmail.com> (raw)
In-Reply-To: <20190630131445.25712-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Unused and the extra rpm get/put interferes with handover from
bootloader (ie. happens before we have a chance to check if
things are already enabled).
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
index 986915bbbc02..e83dd4c6ec58 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
@@ -22,7 +22,6 @@ struct dpu_mdss {
struct msm_mdss base;
void __iomem *mmio;
unsigned long mmio_len;
- u32 hwversion;
struct dss_module_power mp;
struct dpu_irq_controller irq_controller;
struct icc_path *path[2];
@@ -287,10 +286,6 @@ int dpu_mdss_init(struct drm_device *dev)
dpu_mdss_icc_request_bw(priv->mdss);
- pm_runtime_get_sync(dev->dev);
- dpu_mdss->hwversion = readl_relaxed(dpu_mdss->mmio);
- pm_runtime_put_sync(dev->dev);
-
return ret;
irq_error:
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-30 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 13:14 [PATCH 0/3] drm/msm: few small cleanups Rob Clark
2019-06-30 13:14 ` Rob Clark [this message]
2019-07-11 18:47 ` [Freedreno] [PATCH 2/3] drm/msm/dpu: remove dpu_mdss:hwversion Jordan Crouse
[not found] ` <20190630131445.25712-1-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-30 13:14 ` [PATCH 1/3] drm/msm: don't open-code governor name Rob Clark
[not found] ` <20190630131445.25712-2-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-07-11 18:46 ` Jordan Crouse
2019-06-30 13:14 ` [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier Rob Clark
[not found] ` <20190630131445.25712-4-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-07-02 20:30 ` Jeffrey Hugo
[not found] ` <CAOCk7NpyYSiDHP84E4bQiTA1Wk9Sd4w-F8-Zqu9tKtDoUTsFDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-02 21:29 ` Jeffrey Hugo
2019-07-04 6:39 ` Andrzej Hajda
[not found] ` <8a88e865-68a1-37e2-93a1-efd50a778c47-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2019-07-04 14:00 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190630131445.25712-3-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jshekhar@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox