From: Sam Ravnborg <sam@ravnborg.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] drm/panel: simple: fix AUO g185han01 horizontal blanking
Date: Fri, 12 Jul 2019 18:18:34 +0200 [thread overview]
Message-ID: <20190712161834.GA18990@ravnborg.org> (raw)
In-Reply-To: <1562764060.23869.12.camel@pengutronix.de>
Hi Lucas.
> Hi Sam,
>
> since you've been picking up some panel patches lately, might I ask you
> to take a look at this patch?
>
> Regards,
> Lucas
>
> Am Freitag, den 14.12.2018, 14:20 +0100 schrieb Lucas Stach:
> > Hi Thierry,
> >
> > can you please have a look at this one?
> >
> > Regards,
> > Lucas
> >
> > Am Montag, den 12.11.2018, 18:41 +0100 schrieb Lucas Stach:
> > > The horizontal blanking periods are too short, as the values are
> > > specified for a single LVDS channel. Since this panel is dual LVDS
> > > they need to be doubled. With this change the panel reaches its
> > > nominal vrefresh rate of 60Fps, instead of the 64Fps with the
> > > current wrong blanking.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > > b/drivers/gpu/drm/panel/panel-simple.c
> > > index 97964f7f2ace..2c89792e91e2 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -663,9 +663,9 @@ static const struct panel_desc auo_g133han01 =
> > > {
> > > static const struct display_timing auo_g185han01_timings = {
> > > .pixelclock = { 120000000, 144000000, 175000000 },
> > > .hactive = { 1920, 1920, 1920 },
> > > - .hfront_porch = { 18, 60, 74 },
> > > - .hback_porch = { 12, 44, 54 },
> > > - .hsync_len = { 10, 24, 32 },
> > > + .hfront_porch = { 36, 120, 148 },
> > > + .hback_porch = { 24, 88, 108 },
> > > + .hsync_len = { 20, 48, 64 },
> > > .vactive = { 1080, 1080, 1080 },
> > > .vfront_porch = { 6, 10, 40 },
> > > .vback_porch = { 2, 5, 20 },
Updated commit log to include comment form Philipp and applied to
drm-misc-next.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-12 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 17:41 [PATCH] drm/panel: simple: fix AUO g185han01 horizontal blanking Lucas Stach
2018-12-14 13:20 ` Lucas Stach
2019-07-10 13:07 ` Lucas Stach
2019-07-10 13:32 ` Sam Ravnborg
2019-07-12 16:18 ` Sam Ravnborg [this message]
2019-01-25 11:20 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712161834.GA18990@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox