Re: [PATCH v1 33/33] drm/hisilicon: drop use of drmP.h

From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Rongrong Zou" <zourongrong@gmail.com>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"David Airlie" <airlied@linux.ie>,
	"Chen Feng" <puck.chen@hisilicon.com>,
	"John Garry" <john.garry@huawei.com>,
	"ML dri-devel" <dri-devel@lists.freedesktop.org>,
	"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"Souptick Joarder" <jrdr.linux@gmail.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Junwei Zhang" <Jerry.Zhang@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Christian König" <christian.koenig@amd.com>,
	"Allison Randal" <allison@lohutok.net>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v1 33/33] drm/hisilicon: drop use of drmP.h
Date: Mon, 15 Jul 2019 11:34:51 +0100	[thread overview]
Message-ID: <20190715103451.GA20839@arch-x1c3> (raw)
In-Reply-To: <20190715081941.GA29177@ravnborg.org>

On 2019/07/15, Sam Ravnborg wrote:
> Hi Emil.
> 
> > > ---
> > > The list of cc: was too large to add all recipients to the cover letter.
> > > Please find cover letter here:
> > > https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html
> > > Search for "drm: drop use of drmp.h in drm-misc"
> > >
> > Speaking of long CC list, most patches are ok yet this has gone a bit crazy.
> > How did you manage to pull such a long list? The get_maintainer.pl
> > script shows a total of 17 for all of hibmc and kirin.
> 
> Sometimes scripts/get_maintainer.pl outputs a lot of people.
> Sometimes only a few.
> I have not looked into details why, and for this patch series
> I used "dim add-missing-cc" to most patches.
> 
This patch seems like a good candidate to fixup dim. Can we volunteer
you for the task ;-)


> > Either way, since you've built-tested these (and conflicts are a
> > matter of #include) for the lot:
> > Acked-by: Emil Velikov <emil.velikov@collabora.com>
> Just to be sure. Was this an Ack for the full series or only this patch?
> I started processing the patches, and the ones where I have got an
> explicit ack or r-b is queued already (without your ack).
> 
For the lot -> For the series.

> There are still ~20 patches without feedback in this series,
> and I would love to have them processed and pushed out.
> 
Personally I'm inclined that we can push the series even with an ack-by.
Any potential issues raised by a #include reshuffle would be caught by a
build - which you've already done.

Tl;Dr: If it were me - ship it :-P

HTH
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel