From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH v3] gpu/drm_memory: fix a few warnings Date: Mon, 15 Jul 2019 12:02:28 +0100 Message-ID: <20190715110228.GD20839@arch-x1c3> References: <1562685190-1353-1-git-send-email-cai@lca.pw> <1562960735.8510.30.camel@lca.pw> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1562960735.8510.30.camel@lca.pw> Sender: linux-kernel-owner@vger.kernel.org To: Qian Cai Cc: akpm@linux-foundation.org, corbet@lwn.net, airlied@linux.ie, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rfontana@redhat.com, gregkh@linuxfoundation.org, joe@perches.com, linux-spdx@archiver.kernel.org, tglx@linutronix.de, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org Hi Qian, On 2019/07/12, Qian Cai wrote: > Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit > about SPDX can pick this up. It occurs to me none of DRM maintainers cares about > this as there is no feedback from any of them for months since v1. > AFAICT there are a couple of reasons why this has gone unnoticed: - summary is the pretty ambiguous - commit does two thigs Another thing to consider is that this patch touches a single file, while the exact same issue is also present in many other files. Quick look at the following lists: head -n2 drivers/gpu/drm/drm_*[ch] | less drm_agpsupport.c drm_dma.c drm_legacy_misc.c drm_lock.c drm_memory.c drm_scatter.c drm_vm.c If you can fixup the s|/**|/*| in the above, I'd gladly merge the patch. On the topic of SPDX - no objection on my end, but it should be a separate patch, which replaces the explicit verbose license text with the tag. Thanks Emil