From: Sam Ravnborg <sam@ravnborg.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: david@lechnology.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/10] drm/tinydrm: Clean up tinydrm_spi_transfer()
Date: Wed, 17 Jul 2019 15:09:09 +0200 [thread overview]
Message-ID: <20190717130909.GA4852@ravnborg.org> (raw)
In-Reply-To: <20190717115817.30110-6-noralf@tronnes.org>
On Wed, Jul 17, 2019 at 01:58:12PM +0200, Noralf Trønnes wrote:
> Prep work before moving the function to mipi-dbi.
>
> tinydrm_spi_transfer() was made to support one class of drivers in
> drivers/staging/fbtft that has not been converted to DRM yet, so strip
> away the unused functionality:
> - Start byte (header) is not used.
> - No driver relies on the automatic 16-bit byte swapping on little endian
> machines with SPI controllers only supporting 8 bits per word.
Keeping unused code around is never a good idea.
On the other hand, should we not try to get the driver in questions
ported so we have a user and we do not need to re-add this later?
What driver/display needs this?
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-17 13:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 11:58 [PATCH 00/10] drm/tinydrm: Remove tinydrm.ko Noralf Trønnes
2019-07-17 11:58 ` [PATCH 01/10] drm: Add SPI connector type Noralf Trønnes
2019-07-17 19:24 ` David Lechner
2019-07-19 9:17 ` Daniel Vetter
2019-07-19 12:34 ` Noralf Trønnes
2019-07-19 12:39 ` Daniel Vetter
2019-07-17 11:58 ` [PATCH 02/10] drm/tinydrm: Use spi_is_bpw_supported() Noralf Trønnes
2019-07-17 11:58 ` [PATCH 03/10] drm/tinydrm: Remove spi debug buffer dumping Noralf Trønnes
2019-07-17 11:58 ` [PATCH 04/10] drm/tinydrm: Remove tinydrm_spi_max_transfer_size() Noralf Trønnes
2019-07-17 11:58 ` [PATCH 05/10] drm/tinydrm: Clean up tinydrm_spi_transfer() Noralf Trønnes
2019-07-17 13:09 ` Sam Ravnborg [this message]
2019-07-17 16:18 ` Noralf Trønnes
2019-07-17 18:13 ` Sam Ravnborg
2019-07-17 19:37 ` David Lechner
2019-07-17 11:58 ` [PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer() Noralf Trønnes
2019-07-17 13:15 ` Sam Ravnborg
2019-07-17 16:20 ` Noralf Trønnes
2019-07-17 19:48 ` David Lechner
2019-07-18 12:14 ` Noralf Trønnes
2019-07-25 14:16 ` Noralf Trønnes
2019-07-25 14:29 ` David Lechner
2019-07-17 11:58 ` [PATCH 07/10] drm/tinydrm: Move tinydrm_machine_little_endian() Noralf Trønnes
2019-07-17 20:09 ` David Lechner
2019-07-18 12:20 ` Noralf Trønnes
2019-07-17 11:58 ` [PATCH 08/10] drm/tinydrm/repaper: Don't use tinydrm_display_pipe_init() Noralf Trønnes
2019-07-17 11:58 ` [PATCH 09/10] drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats() Noralf Trønnes
2019-07-17 20:38 ` David Lechner
2019-07-17 11:58 ` [PATCH 10/10] drm/tinydrm: Move tinydrm_display_pipe_init() to mipi-dbi Noralf Trønnes
2019-07-17 13:34 ` Sam Ravnborg
2019-07-17 20:46 ` David Lechner
2019-07-18 12:27 ` Noralf Trønnes
2019-07-17 13:31 ` [PATCH 00/10] drm/tinydrm: Remove tinydrm.ko Sam Ravnborg
2019-07-17 16:22 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717130909.GA4852@ravnborg.org \
--to=sam@ravnborg.org \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox