From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/vgem: use normal cached mmap'ings Date: Fri, 19 Jul 2019 11:09:49 +0200 Message-ID: <20190719090949.GG15868@phenom.ffwll.local> References: <20190716164221.15436-1-robdclark@gmail.com> <20190716164221.15436-2-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 793A06E3F2 for ; Fri, 19 Jul 2019 09:09:54 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id w20so33815892edd.2 for ; Fri, 19 Jul 2019 02:09:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190716164221.15436-2-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: Rob Clark , Deepak Sharma , Rodrigo Siqueira , Eric Biggers , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Emil Velikov List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMTYsIDIwMTkgYXQgMDk6NDI6MTVBTSAtMDcwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IEZyb206IFJvYiBDbGFyayA8cm9iZGNsYXJrQGNocm9taXVtLm9yZz4KPiAKPiBTaW5jZSB0 aGVyZSBpcyBubyByZWFsIGRldmljZSBhc3NvY2lhdGVkIHdpdGggdmdlbSwgaXQgaXMgaW1wb3Nz aWJsZSB0bwo+IGVuZCB1cCB3aXRoIGFwcHJvcHJpYXRlIGRldi0+ZG1hX29wcywgbWVhbmluZyB0 aGF0IHdlIGhhdmUgbm8gd2F5IHRvCj4gaW52YWxpZGF0ZSB0aGUgc2htZW0gcGFnZXMgYWxsb2Nh dGVkIGJ5IHZnZW0uICBTbywgYXQgbGVhc3Qgb24gcGxhdGZvcm1zCj4gd2l0aG91dCBkcm1fY2Zs dXNoX3BhZ2VzKCksIHdlIGVuZCB1cCB3aXRoIGNvcnJ1cHRpb24gd2hlbiBjYWNoZSBsaW5lcwo+ IGZyb20gcHJldmlvdXMgdXNhZ2Ugb2YgdmdlbSBibyBwYWdlcyBnZXQgZXZpY3RlZCB0byBtZW1v cnkuCj4gCj4gVGhlIG9ubHkgc2FuZSBvcHRpb24gaXMgdG8gdXNlIGNhY2hlZCBtYXBwaW5ncy4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BjaHJvbWl1bS5vcmc+Cj4g LS0tCj4gUG9zc2libHkgd2UgY291bGQgZG1hX3N5bmNfKl9mb3Jfe2RldmljZSxjcHV9KCkgb24g ZG1hYnVmIGF0dGFjaC9kZXRhY2gsCj4gYWx0aG91Z2ggdGhlIC0+Z2VtX3ByaW1lX3twaW4sdW5w aW59KCkgQVBJIGlzbid0IHF1aXRlIGlkZWFsIGZvciB0aGF0IGFzCj4gaXQgaXMuICBBbmQgdGhh dCBkb2Vzbid0IHJlYWxseSBoZWxwIGZvciBkcml2ZXJzIHRoYXQgZG9uJ3QgYXR0YWNoLwo+IGRl dGFjaCBmb3IgZWFjaCB1c2UuCj4gCj4gQnV0IEFGQUlDVCB2Z2VtIGlzIG1haW5seSB1c2VkIGZv ciBkbWFidWYgdGVzdGluZywgc28gbWF5YmUgd2UgZG9uJ3QKPiBuZWVkIHRvIGNhcmUgdG9vIG11 Y2ggYWJvdXQgdXNlIG9mIGNhY2hlZCBtbWFwJ2luZ3MuCgpJc24ndCB0aGlzIGdvaW5nIHRvIGhv cnJpYmx5IGJyZWFrIHRlc3RpbmcgYnVmZmVyIHNoYXJpbmcgd2l0aCBTb0MKZGV2aWNlcz8gSSdk IGFzc3VtZSB0aGV5IGFsbCBleHBlY3Qgd3JpdGVjb21iaW5pbmcgbW9kZSB0byBtYWtlIHN1cmUg c3R1ZmYKaXMgY29oZXJlbnQ/CgpBbHNvIGNvdWxkIHdlIGdldCBhd2F5IHdpdGggdGhpcyBieSBz aW1wbHkgZXh0ZW5kaW5nIGRybV9jZmx1c2hfcGFnZXMgZm9yCnRob3NlIGFybSBwbGF0Zm9ybXMg d2hlcmUgd2UgZG8gaGF2ZSBhIGNsZmx1c2ggaW5zdHJ1Y3Rpb24/IFllcyBJIGtub3cKdGhhdCds bCBnZXQgcGVvcGxlIHNjcmVhbWluZywgSSdsbCBzaHJ1ZyA6LSkKCklmIGFsbCB3ZSBuZWVkIHBh dGNoIDEvMiBmb3IgaXMgdGhpcyB2Z2VtIHBhdGNoIHRoZW4gdGhlIGF1ZGl0aW5nIG5lZWRlZCBm b3IKcGF0Y2ggMSBkb2Vzbid0IGxvb2sgYXBwZWFsaW5nIC4uLgotRGFuaWVsCgo+IAo+ICBkcml2 ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jIHwgNyArKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS92Z2VtL3ZnZW1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Ry di5jCj4gaW5kZXggMTFhOGY5OWJhMThjLi5jY2YwYzNmYmQ1ODYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92Z2Vt L3ZnZW1fZHJ2LmMKPiBAQCAtMjU5LDkgKzI1OSw2IEBAIHN0YXRpYyBpbnQgdmdlbV9tbWFwKHN0 cnVjdCBmaWxlICpmaWxwLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgCWlmIChyZXQp Cj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gLQkvKiBLZWVwIHRoZSBXQyBtbWFwaW5nIHNldCBieSBk cm1fZ2VtX21tYXAoKSBidXQgb3VyIHBhZ2VzCj4gLQkgKiBhcmUgb3JkaW5hcnkgYW5kIG5vdCBz cGVjaWFsLgo+IC0JICovCj4gIAl2bWEtPnZtX2ZsYWdzID0gZmxhZ3MgfCBWTV9ET05URVhQQU5E IHwgVk1fRE9OVERVTVA7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+IEBAIC0zODIsNyArMzc5LDcgQEAg c3RhdGljIHZvaWQgKnZnZW1fcHJpbWVfdm1hcChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikK PiAgCWlmIChJU19FUlIocGFnZXMpKQo+ICAJCXJldHVybiBOVUxMOwo+ICAKPiAtCXJldHVybiB2 bWFwKHBhZ2VzLCBuX3BhZ2VzLCAwLCBwZ3Byb3Rfd3JpdGVjb21iaW5lKFBBR0VfS0VSTkVMKSk7 Cj4gKwlyZXR1cm4gdm1hcChwYWdlcywgbl9wYWdlcywgMCwgUEFHRV9LRVJORUwpOwo+ICB9Cj4g IAo+ICBzdGF0aWMgdm9pZCB2Z2VtX3ByaW1lX3Z1bm1hcChzdHJ1Y3QgZHJtX2dlbV9vYmplY3Qg Km9iaiwgdm9pZCAqdmFkZHIpCj4gQEAgLTQxMSw3ICs0MDgsNyBAQCBzdGF0aWMgaW50IHZnZW1f cHJpbWVfbW1hcChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwKPiAgCWZwdXQodm1hLT52bV9m aWxlKTsKPiAgCXZtYS0+dm1fZmlsZSA9IGdldF9maWxlKG9iai0+ZmlscCk7Cj4gIAl2bWEtPnZt X2ZsYWdzIHw9IFZNX0RPTlRFWFBBTkQgfCBWTV9ET05URFVNUDsKPiAtCXZtYS0+dm1fcGFnZV9w cm90ID0gcGdwcm90X3dyaXRlY29tYmluZSh2bV9nZXRfcGFnZV9wcm90KHZtYS0+dm1fZmxhZ3Mp KTsKPiArCXZtYS0+dm1fcGFnZV9wcm90ID0gdm1fZ2V0X3BhZ2VfcHJvdCh2bWEtPnZtX2ZsYWdz KTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+IC0tIAo+IDIuMjEuMAo+IAoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==